UFO: Alien Invasion Issue Tracker
UFO: Alien Invasion
Go to the previous open issue
Go to the previous issue (open or closed)
star_faded.png
Please log in to bookmark issues
icon_project.png UFO: Alien Invasion / Open Submit Patch #5558 » Open Submit Patch #5434 improve CountSpawnpoints test
Go to the next issue (open or closed)
Go to the next open issue
Issue basics
  • Type of issue
    Submit Patch
  • Category
    Not determined
  • Targetted for
    Not determined
  • Status
    Open
  • Priority
    Not determined
User pain
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
Affected by this issue (0)
There are no items
People involved
Times and dates
  • Posted at
  • Last updated
Issue details
Attachments (2)
Duplicate issues (0)
This issue does not have any duplicates
Description
The test is very helpfull, but seems to be done in a hurry and/or left unfinished. As is, imo there are some problems with it, mainly:<BR>
1) It tests for dropship, even if the mapdef does not define any (in testCountSpawnpointsForMapWithAssembly).<BR>
2) If the mapdef defines multiplayer, only the multiplayer map is loaded and evaluated. Thus some singleplayer maps will never get testet. For multiplayer it loops through all defined gametypes, but only uses the values from he last orbit (in testCountSpawnpointsForMapWithAssemblyAndAircraftAndUfo).<BR>
I tried to improve the code, but my knowledge is very limited, so if somebody could take a look and give some feedback that would be very welcome. <BR>
Oc now the test loads every map combination possible, which is a huge number (~1000). I am not absolutly sure about that, but that seems what the original intention was.<BR>
Further, I would like to use the numteam values from the aircraft and UFO defs within the test (to replace magic numbers and other stuff). If I could get a hint how this could be achieved (if at all), this would be great. Without this, the test will report a lot of non-existent problems.
Todos (0 / 0)
Issue created
footer_logo.png The Bug Genie 4.3.1 | Support | Feedback spinning_16.gif