[http://sourceforge.net/p/ufoai/patches/448 Item 448] imported from sourceforge.net tracker on 2013-01-28 20:39:33

Now (in trunk rev 27645) UFO's disassebly time is not affected by stored UFO's condition and distance to UFO Yard.
Attached patch corrects this situation.
I modified 3rd parameter of function PR_CalculateProductionPercentDone to const storedUFO_t * - now it is possible to get info of condition and installation. I also moified calls of given function.
===== Comments Ported from Sourceforge =====

====== nobody (2009-12-27 18:27:06) ======

A patch file against SVN trunk rev 27645
====== geever (2009-12-28 11:38:55) ======

Interesting. My comments:
- It was intentional UFOs condition didn't affect disassembly time. (by design)
- I didn't implement distance penalty yet as that would raise the need to be able to transfer UFOs. The backend system can handle it (however it's not a real transfer) but I didn't do the UFO Yards menu yet.
- changing component_t to storedUFO_t of PR_CalculateProductionPercentDone would mean we can't have other assemlies than UFO disassemblying which is the case now (we don't have) but I would like to have a more flexible system here however this can do it for now..

The patch is nice otherwise, Thank you. I'll discuss it with designers in the evening.

-geever
====== btaxis (2009-12-28 22:56:30) ======

Other than the points mentioned by geever, I see no reason why this patch should not be used.
====== tlh2000 (2009-12-31 12:34:02) ======

what's the state here?
====== geever (2010-01-01 16:22:53) ======

Appiled to trunk in r27708 without ufo condition modifier. Thank you!

If we decide not to use distance penalty in 2.3 we can still disable it in the branch.

-geever