[http://sourceforge.net/p/ufoai/bugs/2978 Item 2978] imported from sourceforge.net tracker on 2013-01-28 19:54:51

As title say landed UFOs disappear from the geoscape when the game is loaded (see attached save, there was a landed UFO in United America when saved), the UFOs are still there and will take off once the mission ends.

revision: 2aa65d09174f3835ceeda4899c2a713c218700e5
===== Comments Ported from Sourceforge =====

====== darkrainx (2011-08-21 23:06:55) ======


====== darkrainx (2011-08-21 23:07:56) ======


====== marcush11 (2011-08-22 14:14:08) ======

This happens to me regularly (playing 2.3.1), with any enroute dropships redirected back to homebase, but if you advance time the same landed UFO site shows up immediately with the alert/pause. You can then send back the dropships to the sites, and everything seems to work out, usually.

I've had it where the site disappears again almost an hour (gametime) after the load, and the dropship heads back to base, only to have a new landed UFO site showing up elsewhere (again immediately; mine happened in the same area/funding entity). At about the same time I had another landed UFO site disappear completely (few hours after same game load). This extra weirdness only happened to me once, when there was a lot of UFO/alien activity (two UFO crash sites, one terror site, two landed UFO sites...my two assault teams weren't catching any breaks heh).
====== geever (2011-08-22 22:13:50) ======

Ok, it was hard... I've spent an hour or more with debugging, but got it finally.

First I checked the savesystems themselves. UFOs' "landed" and "detected" properties were ok, but missions' "onGeoscape" property not. The value is saved and loaded just fine but later changed somehow....

I won't annoy you with the tens of breakpoints and traces I had to check in order to find the bug but write what was wrong:

After everything is loaded some post processors are needed. First, base subsystems post processors set up correct capacity values and building statuses for the base buildings then aircraft subsystem resolves missionID-s - it's needed due to a circular dependency of aircraft and missions - and some more...

B_ResetAllStatusAndCapacities function - well, it does what it's name suggest. It however triggers the init function of buildings - like radar. In radar Init the visibility of the mission was rechecked, and failed.

A mission is always detected if it has UFO, it's detected and landed -- at least this is the case which should have been found. BUT! mission->ufo pointer is only resolved in aircraft subsystems post processing function.

Consequence: AIR_PostLoadInit() have to preced B_PostLoadInit()

Voi'la the fix is swapping two lines....

-geever
====== darkrainx (2012-01-06 02:03:31) ======

Fixed