[http://sourceforge.net/p/ufoai/bugs/2769 Item 2769] imported from sourceforge.net tracker on 2013-01-28 19:47:16

Productiontime is reset everytime a savegame is loaded and the gametime advances.

I think the bug was introduced with Commit:bb4707645ecdf38334df669b0e44716112646bb3 * fixed production time calculations and PR_ProductionRollBottom_f was called with a wrong base

In cp_produce.c:

The function PR_LoadXML sets the value prod->percentDone but does not change prod->frame.
But the function PR_ProductionRun increments prod->frame and calculates prod->percentDone from prod->frame
So after a game is loaded the last productiontime i displayed (from prod->percentDone) but if gametime advances productiontime is reset.

===== Comments Ported from Sourceforge =====

====== geever (2011-01-06 23:42:39) ======

mattn introduced this prod->frame stuff but did not ensure it is saved/loaded.
I decided saving prod->frame and calculate precentDone on loading.

The savegame format changed but no break. The game can load them just productions reseted once more.

Thanks for reporting!
-geever

====== geever (2011-01-07 00:05:04) ======

Ok, I reopen this. The major issue is fixed but found a little cosmetic bug.

On Save->Load the remaining hours value on production page is MAX+1, when you start the time it's fixed.
The issue happens because on load time base capacities are not fully set up, it's done in a second round.

-geever
====== geever (2011-01-07 22:43:08) ======

Fixed the last issue too (see previous coment), closing.

-geever
====== sf-robot (2011-01-21 23:20:03) ======

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).