[http://sourceforge.net/p/ufoai/bugs/2702 Item 2702] imported from sourceforge.net tracker on 2013-01-28 19:47:16

user reported on IRC that 2.4-dev broke savegame like this:

..Running subsystem 'mission'
Error while loading rescue mission (missionidx 388, aircraftidx: 3, category: 10, stage: 5)

The game was probably a continued 2.3 save, so everything possible, but needs investigation

-geever
===== Comments Ported from Sourceforge =====

====== geever (2010-10-18 22:12:12) ======

savegame
====== natewr (2010-10-23 04:22:41) ======

I just got this on a 2.4 save begun today. My interceptor was shot down, I saved while my firebird was en route. Then exited the game, compiled the village maps (compiling as I go!). Then I was unable to load my save and I get this error.

I'll attach the ufoconsole.log and the save game.
====== natewr (2010-10-23 04:23:21) ======


====== natewr (2010-10-23 04:23:45) ======


====== tlh2000 (2010-10-23 15:51:27) ======

the resuce missions are making trouble again
====== tlh2000 (2010-10-23 15:52:15) ======

Error while loading rescue mission (missionidx 51, aircraftidx: 2, category: 10, stage: 5)

====== tlh2000 (2010-10-23 15:53:01) ======

i've added a testcase to the unittests for this bug

run ./testall --only-CampaignTests
====== geever (2010-10-23 18:35:51) ======

It was broken by http://ufoai.git.sourceforge.net/git/gitweb.cgi?p=ufoai/ufoai;a=commitdiff;h=9373abc4bd7ad449cf9c236ce3b5559d99fa8720

in short: crashed aircraft were not saved, these savegames are corrupted.

Fixed in 63d2c282482100d170151bc3e03f9592469e0d7d.

The unittest is useless as it has a corrupted save which should not be loaded.

-geever
====== natewr (2010-10-23 20:11:15) ======

New ufoconsole.log 2010-10-24
====== natewr (2010-10-23 20:12:06) ======

New save game that doesn't load 2010-10-24
====== natewr (2010-10-23 20:12:51) ======

Appears to still exist after new compile. New ufoconsole.log and save uploaded.
====== natewr (2010-10-23 20:27:07) ======

New save game (before crash) 2010-10-24
====== geever (2010-10-23 21:38:18) ======

Okay, there was another bug in it. AIR_AircraftGetFromIDX also used AIR_GetNextFromBase which didn't return crashed aircraft.

3611870f5029a4c1ec3293eabc20d9d319774912 should really fix it now.

Note: this save is okay.

-geever

====== sf-robot (2010-11-06 23:20:02) ======

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).