UFO: Alien Invasion Issue Tracker
UFO: Alien Invasion
Go to the previous open issue
Go to the previous issue (open or closed)
star_faded.png
Please log in to bookmark issues
icon_project.png UFO: Alien Invasion / Closed Bug report #2681 Earth's city lights always turned on even @ daytime
Go to the next issue (open or closed)
Go to the next open issue
This issue has been closed with status "Closed" and resolution "Not determined".
Issue basics
  • Type of issue
    Bug report
  • Category
    Campaign
  • Targetted for
    Not determined
  • Status
    Closed
  • Priority
    4. Useful
User pain
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
Affected by this issue (0)
There are no items
People involved
Times and dates
  • Posted at
  • Last updated
  • Estimated time
    Not estimated
Issue details
  • Resolution
    Not determined
  • Reproducability
    Not determined
  • Severity
    Not determined
  • Complexity
    Not determined
  • Platform
    Not determined
  • Architecture
    Not determined
Attachments (0)
There is nothing attached to this issue
Duplicate issues (0)
This issue does not have any duplicates
Description
[http://sourceforge.net/p/ufoai/bugs/2681 Item 2681] imported from sourceforge.net tracker on 2013-01-28 19:43:45

Checked out current git version from September 11, 2010 - Seems to be a relatively new bug, because this does not happen in latest svn version r32055, so this seems to have been introduced after changing to git.
===== Comments Ported from Sourceforge =====

====== tlh2000 (2010-09-12 07:47:13) ======

please do a git bisect session and tell us the exact revision where this was introduced
====== mcr2010 (2010-09-12 08:15:16) ======

I am sorry to tell you that I do not know how to exactly do that ?!
Still have to learn quite everything about git.
====== tlh2000 (2010-09-12 09:13:26) ======

git bisect start
git bisect bad
git checkout HEAD~1500
rebuild ufo - check whether problem is there or not, if problem is not there, type:
git bisect good
rebuild ufo - check whether problem is there or not, if problem is there, type:
git bisect bad (otherwise good of course)
do this until you get a revision that introduced the problem. it's quite fast to get there, git is doing a binary search to nail down the rev that caused this very fast.
====== mcr2010 (2010-09-12 09:39:13) ======

I do not even know how to get to the ufoai working directory, so...
$ git bisect start gives me the error:
fatal: Not a git repository (or any of the parent directories): .git

Also I would like to work with TortoiseGit instead of the commandline version...
But it seems that there is no bisect option there...
====== tlh2000 (2010-09-12 10:20:01) ======

start the gitmsys shell (there is a bat file in the installation directory)
cd /driverletter/path/to/ufoai-git-repo
====== mcr2010 (2010-09-12 10:21:07) ======

Did exactly that. But will try again.

====== mcr2010 (2010-09-12 10:23:01) ======

Got it. / instead of \

====== mcr2010 (2010-09-12 10:59:13) ======

7b10260108486cb4c4a45a0da7755354263794e1 is the first bad commit
Date Sat Sep 4 10:00:57 2010 +0200
* fixed more floating point related warnings

====== tlh2000 (2010-09-12 13:28:50) ======

this revision does not change anything on the renderer, are you really sure?

http://ufoai.git.sourceforge.net/git/gitweb.cgi?p=ufoai/ufoai;a=commitdiff;h=7b10260108486cb4c4a45a0da7755354263794e1#patch8
====== mcr2010 (2010-09-12 14:18:00) ======

I am not sure about anything regarding git, but I am quite sure that I did the correct bisect stuff. After each bisect I did a fresh compile with c:b & the result @ the end was this...
Sorry I cannot help more.

====== tlh2000 (2010-11-16 20:21:58) ======

de55b0d157d0ff35f2b8b806409d159595aa17c3 this is the updated commit id after the history change
====== tlh2000 (2010-11-16 20:33:17) ======

this is fixed in latest master
Steps to reproduce this issue
Nothing entered.
Todos (0 / 0)
Issue created
footer_logo.png The Bug Genie 4.3.1 | Support | Feedback spinning_16.gif