[http://sourceforge.net/p/ufoai/bugs/2467 Item 2467] imported from sourceforge.net tracker on 2013-01-28 19:35:59

Forum discussion located at http://ufoai.ninex.info/forum/index.php?topic=4600.0

I'm experiencing the same problem as the person who posted that thread. I have three soldiers eligible for becoming Senior Warrant Officers, yet they are stuck at Warrant Officer rank. People have gotten things to work by modifying the medals.ufo file to add "killed_others 2" to the requirements, after which they have progressed properly. Default value is supposed to be 0 and according to Kildor it does not need to be written out again. Or at least it should not need to be, but it may be possible that there is some problem with this (since it's not working as designed, by definition something is wrong).

A possible fix would be to add "killed_others 1" (or 2) value for all ranks past Warrant Officer, so that rank progression would work normally. In the forum thread Kildor asked save files (both .lint and .xml) of an unmodified game. I have attached a zip file with my latest save (build 29486 from Destructavator's installer) with the three WOs who should be promoted (Saurav Buckner, Ben Coffey, Magdalena Chernovsky).

Hopefully the save will allow fixing the problem.
===== Comments Ported from Sourceforge =====

====== edirr (2010-04-27 08:42:49) ======


====== edirr (2010-04-28 11:31:11) ======

maskim reported in the forum thread that testing with the attached save file, promotions only started happening past Warrant Officer rank if the higher rank requirements contained "killed_others 1" or greater value in medals.ufo. According to his test, "killed_others 0" has no effect, promotions don't happen. This means that for some reason the game is unable to correctly process the default value 0 for the killed_others variable, even if it is explicitly stated.
====== tlh2000 (2010-04-28 19:24:48) ======

should be fixed in r29641 - feedback is welcome
====== edirr (2010-04-30 21:56:37) ======

This works as it should in build 29651 (which is the latest one I've compiled). So it can be closed and marked as fixed. Do you want to do the honors Mattn or shall I?
====== edirr (2010-05-02 16:24:36) ======

I'm closing this, since as of build 29651 promotions have been happening as they should. Thank you! :D