[http://sourceforge.net/p/ufoai/bugs/2385 Item 2385] imported from sourceforge.net tracker on 2013-01-28 19:30:37

I was playing the game in r28786

I did a save, and tried to load the game later, this was the error I got loading the saved game.

Error: UFO 'Craft_ufo_fighter' is not linked to any missions.

===== Comments Ported from Sourceforge =====

====== markhawrylak (2010-03-05 01:48:21) ======

this save game is broken
====== markhawrylak (2010-03-05 02:07:53) ======

the issues get more complex.

I have attached "save - prior to all issues.zip" that is the save game prior to the game stuffing up.
1. Complete the mission the firebird it moving toward (near the phalanx base)
2. allow the firebird to return to the main base
3. save the game (this is attached as save - causes assertion.zip")
4. load the save game taken in step 3
5. clicking fast forward time causes the assertions

Assertion failed!
Program: C:\development\ufoai\ufo.exe
File: C:\development\ufoai\src\client\campaign\cp_ufo.c
Line: 496
Expression: ufo->mission

the save game attached as "save - unable to load game.zip" is after the entire mess has occured. ie that save game is from after the firebird was in the main base, and then I played a few more missions and that is the attached game
====== markhawrylak (2010-03-05 02:08:23) ======

save - prior to all issues.zip
====== markhawrylak (2010-03-05 02:08:59) ======

save - causes assertion
====== tlh2000 (2010-03-05 07:21:22) ======

afair geever fixed that already - but maybe only in the savegame break branch?
====== geever (2010-03-05 19:35:50) ======

I've loaded the "prior to all issues" save, it's corrupted as well. Your save must have been saved between r28510-r28627. That bug is fixed.

..UFO - Fighter (craft_ufo_fighter) - status: 6 - pos: -98:46
...linked to mission 'cat7_interest156_0'
..UFO - Fighter (craft_ufo_fighter) - status: 6 - pos: 81:-23
...linked to mission 'cat7_interest156_0'

Due to a bug in that rev-range more missions could get the very same id. We save these ids only so on loading more UFOs got linked to the same mission. When finished such a mission some UFOs were left without mission.

I wrote a way of fixing such corrupted saves to the forum: http://ufoai.ninex.info/forum/index.php?topic=4475.msg34273#msg34273

I copy it here as links can break:
"This was a bug between r28510-r28627.
To "fix" your save you should load your save (which is only possible with versions < r28550) with a DEBUG build and type the following commands into the game console:
> debug_delmissions
> debug_destroyufos

This will remove all the UFOs and missions, resave then update to r28627 or later to prevent it happen again."

-geever
====== markhawrylak (2010-03-10 01:55:44) ======

thanks. I have done the supplied steps, and the issue has been resolved.
closed defect