[http://sourceforge.net/p/ufoai/bugs/2376 Item 2376] imported from sourceforge.net tracker on 2013-01-28 19:30:37

svn r28750, linux

Situation: On dead alien exists - plasma pistol, plasma gun, 2xpistol ammo, 1xgun ammo

Piking up the plasma pistol and placing on an actors inventory causes the plasma gun on the ground to also vanish (and instead another plasma pistol appears in the ground location where the pistol was located, just as if it would have been 2 PPs stacked).
Picking up this 2nd PP, it suddenly turns back into a plasma Gun once placed in an actor backpack.
===== Comments Ported from Sourceforge =====

====== tlh2000 (2010-03-03 19:39:23) ======

it's showing the biggest item on that floor container - first come, first serve, if the order changed due to move movement, that might change (it's a linked list and not in the order it's show in the floor container when you open the inventory).

so i wouldn't count this as a bug imo
====== stedevil (2010-03-03 21:26:11) ======

I am talking about the items visible on the ground in the INVENTORY screen of a character, not what item is visible on the ground from a distance.

Surely it must be a bug that item B turns into item A when item A is removed from the ground? This fake item A then turns back to item B if case you pick up also the fake A item. Duing this whole morphing process we are continuously in the inventory screen using TUs to move things from the ground to the actor (ground -> backpack, hands, holster)
====== tlh2000 (2010-03-04 06:39:59) ======

is this reproducible? if yes, how, please give step by step maybe with screenshots if possible.
====== stedevil (2010-03-04 13:33:28) ======

Screenshots are hard to make since pressing print screen during a item drag(&drop) causes a dragged item to be released in the game. So I only have a starting situation pic for you . No "after movement pic either since this time the game even crashed when moving the plasma pistol from floor to actor hand (server crash output at the end)


However, as soon as you have a plasma gun on the floor, things become very screwed up. Trying move the plasma PISTOL by grabbing it on the "top box row" will actually make you select the plasma GUN. And this time, grabbing the PISTOL from the "lower box row" allowed me to correctly move the PISTOL, but as I mentioned upon release in the actors left hand the game crashed.

on't know if updating svn 28750 -> 28780, me recompiling all the maps last night (to get rid of the broken move between levels maps) made this change in behavior or if this crash was just a random occurrence (certainly looks item related though).


Team 0 ended round, team 1's round started!
********************
ERROR: Game Error: Could not find item in inventory of ent 45 (type 2) at 11:1
********************
Shutdown server: Server crashed.
==== ShutdownGame ====
./ufo(Sys_Backtrace+0x1f)[0x819d3d2]
./ufo(Com_Error+0xf6)[0x8145aa2]
./ufo[0x816695c]
[0xa1979d9f]
./ufo(SV_ExecuteClientMessage+0x124)[0x816decc]
./ufo(SV_ReadPacket+0x60)[0x8168ee7]
./ufo(NET_Wait+0x27a)[0x815250d]
./ufo(Qcommon_Frame+0x116)[0x814790e]
./ufo(main+0x5c)[0x819c1c3]
/lib/tls/i686/cmov/libc.so.6(__libc_start_main+0xe6)[0xb71fbb56]
./ufo[0x806bec1]
music change to karlmacklin_geoscape (from PsymongN5)
====== stedevil (2010-03-04 13:35:09) ======

Start situation standing on alien corpse
====== stedevil (2010-03-04 14:53:14) ======

And another servercrash trying to pick up a plasma pistol (no plasma gun present this time).

The only thing the same for both crashes is the location on map africa that the alien was killed in, if it can have anything to do with it. (generally picking up plasma pistols seems to work fine).

I guess this could be split out as a separate bug.

********************
ERROR: Game Error: Could not find item in inventory of ent 42 (type 2) at 4:0
********************
Shutdown server: Server crashed.
==== ShutdownGame ====
./ufo(Sys_Backtrace+0x1f)[0x819d3d2]
./ufo(Com_Error+0xf6)[0x8145aa2]
./ufo[0x816695c]
[0xa400fd9f]
./ufo(SV_ExecuteClientMessage+0x124)[0x816decc]
./ufo(SV_ReadPacket+0x60)[0x8168ee7]
./ufo(NET_Wait+0x27a)[0x815250d]
./ufo(Qcommon_Frame+0x116)[0x814790e]
./ufo(main+0x5c)[0x819c1c3]
/lib/tls/i686/cmov/libc.so.6(__libc_start_main+0xe6)[0xb71fbb56]
./ufo[0x806bec1]

====== stedevil (2010-03-04 16:37:08) ======

Seems the crasher subbug affects not just plasma pistols, but probably in general taking items of the ground on specifically africa map in a certain area. Don't have a screenshot, but I had a crash 3 times now (picking up a plasma pistol ammo this time).

ERROR: Game Error: Could not find item in inventory of ent 42 (type 2) at 8:0
********************
Shutdown server: Server crashed.
==== ShutdownGame ====
./ufo(Sys_Backtrace+0x1f)[0x819d3d2]
./ufo(Com_Error+0xf6)[0x8145aa2]
./ufo[0x816695c]
[0xa400fd9f]
./ufo(SV_ExecuteClientMessage+0x124)[0x816decc]
./ufo(SV_ReadPacket+0x60)[0x8168ee7]
./ufo(NET_Wait+0x27a)[0x815250d]
./ufo(Qcommon_Frame+0x116)[0x814790e]
./ufo(main+0x5c)[0x819c1c3]
/lib/tls/i686/cmov/libc.so.6(__libc_start_main+0xe6)[0xb71fbb56]
./ufo[0x806bec1]

====== tlh2000 (2010-03-04 18:32:40) ======

i wasn't able to reproduce it - can you provide an exact step by step what must be done to get this crash?
====== stedevil (2010-03-04 19:00:27) ======

IIRC the Xs marks the spots of the dead alien.
====== stedevil (2010-03-04 19:07:23) ======

The crashes so far only happened in a very limited area on map africa. I believe the image I attached shows the 3 respective places where the dead body of the alien was that I was taking items from at the time of the crash.

Meanwhile, did you manage to reproduce the morphing plasma weapons? That is not africa map specific and should be visible on any map (well farm and africa at least, didnt try on others yet).

As a reminder, the crash is probably not related to the morphing, I just accidentally stumbled across it since I kept running into aliens at the same location on Africa while trying to get screen shots for the morphing bug.
====== tlh2000 (2010-03-05 08:08:06) ======

no i wasn't - please give me a detailed step-by-step to reproduce it (if possible with screenshots, too).
====== tlh2000 (2010-03-05 08:08:52) ======

if no screenshots are possible, drawings or something like that would do the job, too
====== stedevil (2010-03-07 23:58:38) ======

Ok, today I bumped into something that I suspect could be the same bug as this.

An actor is holding an assault rifle and having a sniper rifle in the backpack. Wanted to switch weapon (drop ass, pick out sniper, pick up ass and put in backpack).

When Im dropping the Assault rifle to the floor, it simply vanishes into thin air. It's not visible in either the map not the inventory floor. Next turn, it has magically come back and is now lying on the floor, possible to pick up and put in backpack.

Screenshots of the event, but it doesnt show very much.
...

On a later map (tropic), I try to do exactly the same thing. The assault rifle again vanishes. When trying to pick it up the next round I again get a crash. What is common with this crash and all other 3 crashes when picking up items from the ground is that it has been near cliffs/elevation changes in the map. Could this be the reason why the item can't be properly found by the game engine when trying to pick it up from the ground?


Unfortunately don't have a screen for this situation, the actor was sitting crouched on the rocky high position to the near the dropship
CM_LoadMap: "-tropic/tr_ +h01 +h02 +h03 +h04 +craft_drop_firebird +craft_ufo_fighter +h01 +f06 +f02 +f06 +h04 +f02 +f02 +f06 +f07 +p02 +f02 +p01 +f03 +f02 +f07" "0 -16 0 -24 -16 0 0 -8 0 -8 24 0 0 16 0 -16 0 0 0 8 0 -24 24 0 -8 -8 0 -24 -24 0 16 8 0 -24 16 0 -8 -16 0 -8 -24 0 8 -24 0 16 -24 0 16 -16 0 -24 8 0 16 -8 0 -24 0 0 16 0 0"


ERROR: Game Error: Could not find item in inventory of ent 24 (type 2) at 4:0
********************
Shutdown server: Server crashed.
==== ShutdownGame ====
./ufo(Sys_Backtrace+0x1f)[0x819d6ba]
./ufo(Com_Error+0xf6)[0x8145b92]
./ufo[0x8166a74]
[0xa20e7e67]
./ufo(SV_ExecuteClientMessage+0x124)[0x816dfe4]
./ufo(SV_ReadPacket+0x60)[0x8168fff]
./ufo(NET_Wait+0x27a)[0x81525fd]
./ufo(Qcommon_Frame+0x116)[0x81479fe]
./ufo(main+0x5c)[0x819c48b]
/lib/tls/i686/cmov/libc.so.6(__libc_start_main+0xe6)[0xb7315b56]
./ufo[0x806bef1]

====== stedevil (2010-03-08 00:01:42) ======


====== stedevil (2010-03-08 00:05:45) ======


====== stedevil (2010-03-08 19:36:29) ======

Yet another crash interacting with on gound items.
Had a base attack and the game didnt pick the 8 slodiers from the dropship, but traded 1 for a guy that had no equipment and "lying in hospital". So I set out to give this unarmed soldier a few weapons and grenades from another soldier. I picked up 1 Grendade lanucher, 1 knife and 2 grenades that I had dropped. To my surprise, this left a grenade item lying on the ground. Wondering if perhaps I had made an error and dropped 3 grenades, I tried to pick up also this 3rd grenade. CRASH.

ERROR: Game Error: Could not find item in inventory of ent 14 (type 2) at 15:0
********************
Shutdown server: Server crashed.
==== ShutdownGame ====
./ufo(Sys_Backtrace+0x1f)[0x819d6ba]
./ufo(Com_Error+0xf6)[0x8145b92]
./ufo[0x8166a74]
[0xa0f71e67]
./ufo(SV_ExecuteClientMessage+0x124)[0x816dfe4]
./ufo(SV_ReadPacket+0x60)[0x8168fff]
./ufo(NET_Wait+0x27a)[0x81525fd]
./ufo(Qcommon_Frame+0x116)[0x81479fe]
./ufo(main+0x5c)[0x819c48b]
/lib/tls/i686/cmov/libc.so.6(__libc_start_main+0xe6)[0xb7358b56]
./ufo[0x806bef1]


This however was not near an edge, as far as I know. But it certainly is related to items showing/not showing on the ground as they should.
====== stedevil (2010-03-12 10:54:18) ======

Another crash involving actor picking up item lying on not even ground (a hill in this case).
Sniper dropped rifle, took flamer from backpack, tried to pick up rifle and put in backpack -> Crash

That is 5 out of 6 crashes for sure around elevation changes.

ERROR: Game Error: Could not find item in inventory of ent 4 (type 2) at 7:1
********************
Shutdown server: Server crashed.
==== ShutdownGame ====
./ufo(Sys_Backtrace+0x1f)[0x819d6ba]
./ufo(Com_Error+0xf6)[0x8145b92]
./ufo[0x8166a74]
[0xa3902e67]
./ufo(SV_ExecuteClientMessage+0x124)[0x816dfe4]
./ufo(SV_ReadPacket+0x60)[0x8168fff]
./ufo(NET_Wait+0x27a)[0x81525fd]
./ufo(Qcommon_Frame+0x116)[0x81479fe]
./ufo(main+0x5c)[0x819c48b]
/lib/tls/i686/cmov/libc.so.6(__libc_start_main+0xe6)[0xb72bfb56]
./ufo[0x806bef1]


CM_LoadMap: "-forest/fr_ +craft_drop_firebird +craft_ufo_harvester +a1 +a1 +a2 +h1 +h2 +w6 +w8 +f1 +f10 +f10 +a2 +f6 +f6 +f3 +f1 +f1 +f2 +f2 +f3 +f7 +a1 +f8 +f2 +w3 +w1 +w2 +w2 +f8 +f8" "0 -24 0 -8 0 0 -8 32 0 -8 0 0 -24 -8 0 -24 8 0 -8 -16 0 -32 -16 0 -24 -32 0 0 -8 0 8 -8 0 0 32 0 16 -32 0 -8 -32 0 24 -16 0 -32 0 0 -24 0 0 16 32 0 -32 16 0 24 32 0 -32 24 0 -24 32 0 -16 32 0 0 -32 0 8 -32 0 -16 -24 0 -16 -16 0 -24 -16 0 -32 -32 0 -32 -24 0 -24 -24 0"

====== tlh2000 (2010-03-15 20:55:31) ======

could you please retry with r29015
====== stedevil (2010-03-16 14:38:31) ======

Retry if plasma gun is morphing or not or if things still crash?

1st i didnt try yet, but crashes for sure still occur (svn 29029)

I actor threw a medpack to another actor, 2nd actor tried to pick it up.

ERROR: Game Error: Could not find item in inventory of ent 1 (type 2) at 4:1
********************
Shutdown server: Server crashed.
==== ShutdownGame ====
./ufo(Sys_Backtrace+0x1f)[0x819e63e]
./ufo(Com_Error+0xf6)[0x8145c86]
./ufo[0x8166b68]
[0xa1965d9c]
./ufo(SV_ExecuteClientMessage+0x124)[0x816e0d4]
./ufo(SV_ReadPacket+0x60)[0x81690ef]
./ufo(NET_Wait+0x27a)[0x81526f1]
./ufo(Qcommon_Frame+0x116)[0x8147af2]
./ufo(main+0x5c)[0x819d40f]
/lib/tls/i686/cmov/libc.so.6(__libc_start_main+0xe6)[0xb731eb56]
./ufo[0x806c011]

====== tlh2000 (2010-08-21 10:48:42) ======

please try again with revisions >= r31694 (see bug #3019816) - setting this to pending because the wrong floor container pointer was most likely also the reason for this bug.
====== sf-robot (2010-09-29 19:26:02) ======

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).