[http://sourceforge.net/p/ufoai/bugs/2363 Item 2363] imported from sourceforge.net tracker on 2013-01-28 19:30:37

Game build 28412 posted by Destructavator in the windows forum.
Crashed ufo missions are appearing on the map after a save load.
The event triggering the missions appearing after loading is unknown atm.
There are four crashed ufo's on the map.Two are legitimately shot down by sam sites.
The first bugged mission is the crash in the revolutionary countries showing a terror mission icon and mission description.
The second bugged mission is the crashed ufo(phalanx HQ) with a base atack description.
Neither of these ufo\'s were shot down and both appeared after loading a save.
Attached in the saves.zip are 4 save games and ufoconsole.log from after a slot 5 crash.
Slot 7 is the save 3 game days before slot 0.There are no problems with this save.Included it just in case it might be useful.
Slot 0 is the first appearance of the mission in revolutionary countries.The mission is playable but does not appear to be crashed on the battlescape.
Slot 3 is the first appearance of the base attack crash.Attempting to do the mission results in a never ending black screen with a crosshair cursor.
Slot 5 both missions present and advancing the time will give the following error and ctd
\"Assertion failed!
Program: D:\\ufoai-2.3-dev\\ufo.exe
File: D:\\ufoai\\src\\client\\campaign\\cp_ufo.c
Line: 496
Expression: ufo->mission\"

System info.
Stock ASUS G50V laptop
Vista 64 (fresh reinstalled within 2 weeks,fully updated)
Intel core2 duo 4GHZ
4GB ram
NVIDIA 9700m GT 512MB
Realtek high defifition audio
C drive 31GB free space
D drive 76GB free space
===== Comments Ported from Sourceforge =====

====== lilstinker (2010-02-16 00:07:55) ======


====== lilstinker (2010-02-16 00:08:38) ======


====== lilstinker (2010-02-16 00:10:29) ======

saves.rar split to two files due to upload size limit
====== thilosf (2010-02-16 21:38:50) ======

I can also report this failed assertion (ufo->mission), but under different circumstances.

I consider the savegame from which i can reproduce this bug clean, as there's a short period of time when 'debug_listufo' in the console shows no ufos; so this seems to be related to new ufos/missions spawned in-game (if that's how it works). After two or three ufos appear in debug_listufo, there consistently appears one ufo which has no mission assigned to it: "linked to mission: '' ".

Sometimes instead of empty quotes (where the mission name is supposed to be), there are crappy characters, and once it even read 'chnellspeichern', which is part of the german word for quicksave (perhaps a pointer pointing to a really wrong location?).

Thus prepared, i have experienced two conditions that lead to the game crashing with the failed 'ufo->mission' assertion:

1. The ufo appears on geoscape and is shot down either by sam sites/base defense or by interceptors. The game crashes the moment when the crash mission is supposed to appear on the geoscape.

2. I save the game and restore it, with or without restarting ufoai. The console log complains about 'mission "xy" not found' (or similar) in the aircraft subsystem of the savegame-loading-procedure; most times the savegame is restored anyway. debug_listufo lists one ufo with 'linked to mission: 'no mission''. The game crashes the moment i unstop the time.

This bug first appeared (to me) while i stuck with r28400 for some time, but also happens with r28621, which i'm currently running (under debian lenny).

====== thilosf (2010-02-16 21:45:01) ======

Whoops, if forgot: once the ufo with no correct mission assigned to it appears, it is no use to wait until it disappears. When it has completed its route (as shown by debug_listufo), another ufo of the same type (with me, it is always a fighter) immediately appears in the list. It has a different route length (current: 0), and also has no mission assigned. And so on ...
====== geever (2010-02-28 16:33:13) ======

lilstinker, some UFOs have negative damage (HP) (-5, -10) in your saves. How did you do it if not shot them down?

I'm a bit confused of r28412. There was a bug that could cause savegame corruption and ufo->mission assert but later than r28412, and that issue is fixed. All I see is that these saves are somehow corrupted but not the why. If you could reproduce it with the latest and maybe describe what has happened that would help a lot.

-geever

-geever
====== lilstinker (2010-03-01 21:17:49) ======

Maybe that could be a side effect of trying to use console commands to get rid of the bugged missions?
Tried to (without success and repeatedly) use a console command to remove all missions from the map.I just assumed it did'nt do anything since it did'nt work.
Now that i think about it,it all started sometime after using the console to destroy a ufo unavoidably incoming to the main base.
The base mission crash bug is still present in that build IIRC.It became a game breaking event since i had nothing to shoot it down with at that point.

There's 2 that were a legit shot down by sams but the other 2 i did'nt shoot down at all.The missions just appeared out of thin air(oops pun)
I have'nt had it happen again yet.currently using 28632.
I'll see what i can do about breaking your toys again =P
====== geever (2010-03-15 09:49:04) ======

No idea. Please reopen if you could reproduce with a new campaign.

-geever