[http://sourceforge.net/p/ufoai/bugs/2246 Item 2246] imported from sourceforge.net tracker on 2013-01-28 19:26:38

svn:27675
I have a save game attached where the units 7 and 8 are unable to reload their 7.65mm handgun.
The handgun is in the inventory, and has no ammo in it from the start of the mission.
The firebird craft has travelled from the main base where there is ample ammo.

1. why is the gun not fully reloaded at the start of the round? if units are unable to reload when returning to base, a warning msgbox should fire to indicate that the units are unable to fully reload.
2. why can't I reload the gun in the battlespace. the units 7 and 8 both have ammo for the gun in their inventory.
I dont understand the way reloads of weapons are handled when a plane returns. But maybe the reload failed to occur to the unit hand guns from the previous mission.
===== Comments Ported from Sourceforge =====

====== markhawrylak (2009-12-29 06:11:16) ======

unable to reload weapon for unit 7 and 8
====== markhawrylak (2009-12-30 05:58:14) ======

I figured the answer to Item 1. the gun has no ammo to load is in the base.
therefore, I worked out that each gun consumes 1 ammo when the unit is in the base. plus any ammo the units have in their kit. I purchased some more ammo for the 7.65 handgun and the gun was loaded with the ammo.
Given the solution to Item 1. There needs to be a warning when the aircraft return to base to say that units were unable to fully re-equip, and to list the unit and the ammo type.
Issue 2 still holds true, I was unable to reload the weapon in the battlespace.

====== voovoos (2009-12-31 08:35:52) ======

About 1 - yes, a warning could be nice. Though the way of reloading and reequipping will most probably change after 2.3 release.
About 2 - I will check that later.
Thanks for the report.
====== voovoos (2010-01-03 01:20:17) ======

Checked your savegame. Reloading pistol for units 7 and 8 during battlescape works - simply move magazine over pistol, you will notice it reloads (sound + color update). Gun was not reloaded at round start, because you choose to put ammo into belt, so it can be automaticaly used for reloading. If you are asking why it wasn't reloaded at base, the answer is simply: this is the way current reloading algorithm works.

I am setting this to pending, because autoequip feature just works this way, there is no bug there. As I wrote, it will be (most probably) redesigned, but for next version.

You could open a new bug about lack of sending mail after returning to base if there is not enough ammo to reequip squad.
====== markhawrylak (2010-01-03 06:47:14) ======

re-tested in r27771. yes, opening inventory screen and dragging the ammo into the gun reloaded the weapon. I was not aware that was an alternative reload method.

In the defect I was refering to the reload button on the HUD. The button was disabled despite the ammo being in the inventory.
setting status to Open.
====== voovoos (2010-01-05 23:28:46) ======

using HUD reload button should be fixed in r27865; please test it with weapons in RIGHT hand only (weapons in LEFT hand produces other problems, which will be addressed later); in case all works ok for reloading RIGHT-handed weapon, please drop a note here
====== markhawrylak (2010-01-12 12:06:43) ======

tested in r27972 - FAILED
I got the error "No Weapon in hand" when I tried to reload the weapon. I used the save game that is supplied.
set status to Open
====== tlh2000 (2010-02-06 08:39:03) ======

i've changed a lot of the hud code in the last few days - would be nice if someone could retest. i'm not sure about the savegame that is provided, but it should work in general.
====== markhawrylak (2010-02-06 11:45:19) ======

I have retested in r28450
realod appears to work correct for the RH in normal circumstances, however the issue reported by the attached save game is not resolved.

====== tlh2000 (2010-02-07 19:05:37) ======

should be fixed in r28487
====== markhawrylak (2010-02-08 11:19:34) ======

tested in r28496 - Passed
tested using the supplied save game.