[http://sourceforge.net/p/ufoai/bugs/2226 Item 2226] imported from sourceforge.net tracker on 2013-01-28 19:26:38

Steps to reproduce: Skirmish --> Start Game --> End turn a few times.

Version:
URL: https://ufoai.svn.sourceforge.net/svnroot/ufoai/ufoai/trunk
Repository Root: https://ufoai.svn.sourceforge.net/svnroot/ufoai
Repository UUID: 39b98707-f80d-0410-bc7e-c6b02f5409da
Revision: 27496
Node Kind: directory
Schedule: normal
Last Changed Author: geever
Last Changed Rev: 27496
Last Changed Date: 2009-12-16 23:21:31 +0100 (Wed, 16 Dec 2009)

OS:
Linux aaa 2.6.28-17-generic #58-Ubuntu SMP Tue Dec 1 21:27:25 UTC 2009 x86_64 GNU/Linux

Backtrace:
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7f0f1b477760 (LWP 6328)]
0x00007f0f09542c49 in G_ClientEndRound (player=0x1524f598, quiet=qtrue) at src/game/g_round.c:216
216 p->pers.last = NULL;
(gdb) bt full
#0 0x00007f0f09542c49 in G_ClientEndRound (player=0x1524f598, quiet=qtrue) at src/game/g_round.c:216
p = (player_t *) 0x0
i = 0
#1 0x00007f0f0952e10d in AI_Run () at src/game/g_ai.c:914
player = (player_t *) 0x1524f598
ent = (edict_t *) 0x152d42a8
i = 1
j = 52
#2 0x00007f0f0953e034 in G_RunFrame () at src/game/g_main.c:422
No locals.
#3 0x0000000000530925 in SV_RunGameFrame () at src/server/sv_game.c:418
No locals.
#4 0x0000000000533231 in SV_Frame (now=288711, data=0x0) at src/server/sv_main.c:772
No locals.
#5 0x000000000050cb46 in tick_timer (now=288711, data=0x10fdaec8) at src/common/common.c:979
timer = (struct timer *) 0x10fdaec8
old_interval = 100
lateness = 2
#6 0x000000000050d00f in Qcommon_Frame () at src/common/common.c:1130
time_to_next = 0
event = (struct event *) 0x175a8a38
#7 0x0000000000567e7d in main (argc=7, argv=0x7fff1b5f1bd8) at src/ports/linux/linux_main.c:53
No locals.
===== Comments Ported from Sourceforge =====

====== tlh2000 (2009-12-17 06:58:04) ======

this is not reproducible here - any other info? which map and so on?

r27499 catches the null ptr and throws an error - but this is of course not a real fix.
====== wrwrwr (2009-12-17 17:39:18) ======

Still crashes (rev. 27499), but now with some message loop (all defaults, Africa map, not doing anything other than maybe moving towards aliens, so it ends quicker :-)

[STATS] 2009/12/17 18:32:44 - End of game - Team 7 is the winner
[STATS] 2009/12/17 18:32:44 - End of game - Team 7 is the winner
Team 7 ended round, team 0's round started!
********************
ERROR: Game Error: Could not find player for team -1
********************
Shutdown server: Server crashed.
==== ShutdownGame ====

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fe5ed853760 (LWP 6773)]
0x000000000053bd33 in INVSH_EmptyContainer (i=0x2e2dd50, container=0x6314ca4) at src/game/inv_shared.c:1114
1114 ic = ic->next;
(gdb) bt full
#0 0x000000000053bd33 in INVSH_EmptyContainer (i=0x2e2dd50, container=0x6314ca4) at src/game/inv_shared.c:1114
old = (invList_t *) 0x7fe5db6d59c0
ic = (invList_t *) 0x7fe5db6d59c0
cnt = 0
__PRETTY_FUNCTION__ = "INVSH_EmptyContainer"
#1 0x0000000000456c45 in LE_Cleanup () at src/client/battlescape/cl_localentity.c:1229
i = 40
le = (le_t *) 0x2e2dae0
inv = {c = {0x20, 0x101010101010101, 0x0, 0x7fe5ea44f276, 0x2012058, 0x7fe5ed85ba3b, 0x7fff19c9a670, 0x5157fa,
0x2be11e8, 0x2e8ba2e8ba2e8ba3, 0x3a000000075, 0x8, 0x3ad160fb2b0, 0x5b20e7, 0x3f33333300000000, 0x569b20}}
#2 0x000000000042c058 in GAME_Drop () at src/client/cl_game.c:500
list = (const gameTypeList_t *) 0x569b20
#3 0x0000000000436c40 in CL_Drop () at src/client/cl_main.c:183
No locals.
#4 0x000000000050b1fe in Com_Error (code=1, fmt=0x5b1ac3 "Game Error: %s") at src/common/common.c:242
argptr = {{gp_offset = 24, fp_offset = 48, overflow_arg_area = 0x7fff19c9a7a0, reg_save_area = 0x7fff19c9a6e0}}
msg = "Game Error: Could not find player for team -1", &#039;\0&#039; <repeats 4050 times>
recursive = qtrue
#5 0x000000000052ff8c in SV_error (fmt=0x7fe5db429e08 <Address 0x7fe5db429e08 out of bounds>) at src/server/sv_game.c:85
msg = "Could not find player for team -1\000\000\000\000\000\000\0000�\222\003\000\000\000\000\020�\222\003\000\000\000\000\200�Y\000\000\000\000\000\210\025Z\003\000\000\000\000\000�\226\001\000\000\000\000\220��\031�\177\000\000��L\000\000\000\000\000���\031\003\001\000\000��\222\003\000\000\000\000\000\000�\031\001\000\000\000�$Z\003\000\000\000\000\000\000\000\000\001\000\000\000`", &#039;\0&#039; <repeats 11 times>, "�\001\000\000 _�\026\000\000\000\000���\031�\177\000\000�]Q\000\000\000\000\000���\002\000\000\000\000\220�&\030A\002\000\000�\031�\177\000\000�"...
argptr = {{gp_offset = 16, fp_offset = 48, overflow_arg_area = 0x7fff19c9aca0, reg_save_area = 0x7fff19c9abe0}}
#6 0x00007fe5db3f3c6e in ?? ()
No symbol table info available.
#7 0x0000000111bbf558 in ?? ()
No symbol table info available.
#8 0x00000000160fa0a8 in ?? ()
No symbol table info available.
#9 0x0000000000000000 in ?? ()
No symbol table info available.

====== tlh2000 (2009-12-22 09:12:10) ======

please retry with r27549 - i was still not able to reproduce it, but i think the latest backtrace helped me to track it down.
====== wrwrwr (2009-12-22 10:02:30) ======

Almost, no crashes, but sometimes (3/4 tries) the "mission won" appears a bit too early (on aliens&#039; turn start, just before last phalanx is/are killed).

So it goes like: my turn ends, aliens&#039; turn starts, "Mission Won" message, aliens shoot and kill, all aliens are shown, popup over menu appears.

Also aliens once got another turn after winning:

Mission won for team 7
[STATS] 2009/12/22 10:26:03 - End of game - Team 7 is the winner
Team 7 ended round, team 7&#039;s round started!
Shutdown gametype &#039;Skirmish mode&#039;
====== tlh2000 (2009-12-22 19:36:33) ======

"popup over menu" - over the main menu i hope?

i&#039;ve removed the broadcast of that message - as it does not make sense to send it later (because that&#039;s a hud message, and the hud is gone later already)
====== tlh2000 (2009-12-22 22:36:08) ======

"Team 7 ended round, team 7&#039;s round started!"
is just a client side message of a pending event.

if the popup appears over the main menu i would say this one is fixed - if there are other issues that are not related to the crash, please open a new ticket for this. settings this to pending.
====== wrwrwr (2009-12-23 01:16:44) ======

Yes, over the main menu. Sure, fixed.