[http://sourceforge.net/p/ufoai/bugs/1899 Item 1899] imported from sourceforge.net tracker on 2013-01-28 19:12:13

On battle, original HUD, firemodes don't open up on clicking the button so we can't fire (manually).

I've checked: the click happens, even CL_DisplayFiremodeEntry runs. Maybe problem with Cbuf_AddText("confuncs") ?

-geever
===== Comments Ported from Sourceforge =====

====== bayo-fr (2008-11-26 09:02:45) ======

Problem come from by revision 20383

Precondition of this revision is confunc name is unique; but it's not (for example "hud" and "althud") (i dont think its very nice, but its done like that). So, with this revision, your problem come from we call the wrong node from "althud" instead of from "hud".

I fix that by an override of the node adress of menus when we push it on the renderer. We push "althud" or "hud".

But we must do more, to no more have problems like that:
* How to prevent confunc homonymous (it can create problems)
* How and when allowing confunc homonymous (the code use it, we cant do without)

Maybe we can do something like that:
* common case: Dont allowing any homonymous confunc. Registration at the parsing time, with a warning/error (not a debug one).
* extends of menu: we can allow it here. When we script something like that, we know we will have confunc with same name, so we will not call a confunc if we have not already push the menu. We can allow, only here the patch of the revision 20401.

It will maybe work safe. But not yet done :)
====== bayo-fr (2008-11-27 08:44:14) ======

I patch something yesterday, but i dont read very well new warning it introduce; it dont fix all the case.

The last case is a callback function fired when a cvar change (for exemple looking change of "cl_name"). If we look at each use, we can see it is every time used for edition of text. That why, maybe, we can :
* Create a new node "listener" to allow random number of callback using the same command (we call all functions instead of the first one on the top of the stack); registring it when we push a menu; ununregistring it when we pop it.
* But we also can create the "textentry" node (with a change action) and see if we can use it for all this cases.

Both are easy to implement. The second will take more time, but maybe i will begin with it.