[http://sourceforge.net/p/ufoai/bugs/862 Item 862] imported from sourceforge.net tracker on 2013-01-28 18:38:45

SVN r10564.

Clicking on the "V" doesn't apply the current soldier's skin to every other soldier aboard a vehicle.

Best regards


Danai

===== Comments Ported from Sourceforge =====

====== danai (2007-08-05 22:46:14) ======


====== tlh2000 (2007-08-06 07:09:12) ======

Logged In: YES
user_id=116930
Originator: NO

Most likely due to the character list changes hoehrer introduced recently
====== tlh2000 (2007-08-06 08:42:52) ======

Logged In: YES
user_id=116930
Originator: NO

revision 10537 is the reason.
http://ufoai.svn.sourceforge.net/viewvc/ufoai?view=rev&revision=10537

This revision is only setting the skin for the current selected soldier (which was already done, so this function is now completly useless)

the removed for loop must be readded to change the skin for every soldier on board.
====== voovoos (2007-08-06 10:02:13) ======

Logged In: YES
user_id=194458
Originator: NO

This patch should restore CL_ChangeSkinOnBoard_f() functionality with the new way of handling teams. It does not taking care about 2x2 actors (Do 2x2 actors have skins at all?). Untested.

Index: src/client/cl_team.c
===================================================================
--- src/client/cl_team.c (revision 10569)
+++ src/client/cl_team.c (working copy)
@@ -435,7 +435,7 @@
*/
static void CL_ChangeSkinOnBoard_f (void)
{
- int sel, newSkin;
+ int i, sel, newSkin;
aircraft_t *aircraft = NULL;

if (!baseCurrent)
@@ -458,9 +458,12 @@
newSkin = Cvar_VariableInteger("mn_skin");
if (newSkin >= NUM_TEAMSKINS || newSkin < 0)
newSkin = 0;
-
- assert(chrDisplayList.chr[sel]);
- chrDisplayList.chr[sel]->skin = newSkin;
+ for (i = 0; i < MAX_ACTIVETEAM; i++) {
+ if (aircraft->teamIdx[i] > -1) { /* Other values means soldier onboard. */
+ assert(chrDisplayList.chr[sel]);
+ chrDisplayList.chr[i]->skin = newSkin;
+ }
+ }
}
}

====== voovoos (2007-08-06 10:04:21) ======

Logged In: YES
user_id=194458
Originator: NO

assert(chrDisplayList.chr[sel]); -> assert(chrDisplayList.chr[i]); in the patch
====== hoehrer (2007-08-06 10:24:02) ======

Logged In: YES
user_id=1434318
Originator: NO

Woah, don&#039;t answer this fast, I already started fixing this ;)
The faulty revision was a misunderstanding on my side, I thought the function does something else. :)
Please test if revision 10571 fixes this?

Werner
====== danai (2007-08-07 22:11:53) ======

Logged In: YES
user_id=1643496
Originator: YES

SVN r10625.

This bug has been fixed. Thanks a lot!


Danai