UFO: Alien Invasion Issue Tracker
UFO: Alien Invasion
Go to the previous open issue
Go to the previous issue (open or closed)
star_faded.png
Please log in to bookmark issues
icon_project.png UFO: Alien Invasion / Closed Submit Patch #5120 [PATCH] * Testall: split apart test suite and test registration
Go to the next issue (open or closed)
Go to the next open issue
This issue has been closed with status "Closed" and resolution "WON'T FIX".
Issue basics
  • Type of issue
    Submit Patch
  • Category
    Not determined
  • Targetted for
    Not determined
  • Status
    Closed
  • Progress
  • Priority
    Not determined
User pain
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
Affected by this issue (0)
There are no items
People involved
Times and dates
  • Posted at
  • Last updated
Issue details
  • Resolution
    WON'T FIX
Attachments (1)
  • icon_download.png Patch 5120 revision 1
    0001-Testall-split-apart-test-suite-and-test-registration.patch uploaded Sep 10, 2013 by unknown user
Duplicate issues (0)
This issue does not have any duplicates
Description
For aDuke. He was trying to use a "test property" from the command line to determine whether or not a test would be run. But the command line was parsed ''after'' all of the tests were registered. It wasn't possible to just rearrange a few lines in main(). Instead, I split apart the test suite registration and the test registration to provide the required flexibility.


(I also made some line spacing consistent, changed a few NULLs to nullptrs, and fixed a few unimportant copy-paste errors in the test names.)


Order of actions was:
* test suites and tests registered
* command line parsed (needs test suites to be registered already)

Order of actions is now:
* test suites registered
* command line parsed (needs test suites to be registered already)
* tests registered (needs test suites to be registered already) (needs command line parsed already)

Possible improvements:
* new "step" parameter to registration functions uses hard-coded 0 and 1 instead of enums or defines.
* the RandomMapAssemblyTests do something unique with cvars. I kept that code with the test suite registration part.
Todos (0 / 0)
Issue created
footer_logo.png The Bug Genie 4.3.1 | Support | Feedback spinning_16.gif