UFO: Alien Invasion Issue Tracker
UFO: Alien Invasion
Go to the previous open issue
Go to the previous issue (open or closed)
star_faded.png
Please log in to bookmark issues
icon_project.png UFO: Alien Invasion / Closed Submit Patch #4820 Add PTL_InitStartup() to CL_Shutdown
Go to the next issue (open or closed)
Go to the next open issue
This issue has been closed with status "Closed" and resolution "Not determined".
Issue basics
  • Type of issue
    Submit Patch
  • Category
    General
  • Targetted for
    Not determined
  • Status
    Closed
  • Priority
    1. Very low
User pain
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
Affected by this issue (0)
There are no items
People involved
Times and dates
  • Posted at
  • Last updated
Issue details
Attachments (0)
There is nothing attached to this issue
Duplicate issues (0)
This issue does not have any duplicates
Description
[http://sourceforge.net/p/ufoai/patches/693 Item 693] imported from sourceforge.net tracker on 2013-01-28 20:46:59

PTL_InitStartup also serves as the particle shutdown function.
===== Comments Ported from Sourceforge =====

====== tlh2000 (2012-10-22 16:51:19.680000) ======

there should be shutdown function - or the function should get a new name - calling an init function in a shutdown function isn't semantically the best imo.
====== drane (2012-10-22 16:58:24.783000) ======

In complete agreement re startup/shutdown names. I didn't like it either, but I didn't want to start building a bike shed*. And making two copies of the exact same function is just ugly. Even making one as a stub to call the other invites trouble if the code changes. Et cetera.

* Bike shed: https://en.wikipedia.org/wiki/Parkinson's_Law_of_Triviality
====== tlh2000 (2012-10-22 17:03:41.467000) ======

that's not the point - then we should rename it. the name does not fit anymore if it's called in a shutdown context.
====== drane (2012-10-22 17:05:32.648000) ======

Sorry. I wasn't disagreeing with you. I explained why I didn't rename it myself, and why I didn't like the other alternatives to renaming.

If you'd like, I can submit a patch to rename it to PTL_Clear or similar tonight. Just let me know.
Todos (0 / 0)
Issue created
footer_logo.png The Bug Genie 4.3.1 | Support | Feedback spinning_16.gif