UFO: Alien Invasion Issue Tracker
UFO: Alien Invasion
Go to the previous open issue
Go to the previous issue (open or closed)
star_faded.png
Please log in to bookmark issues
icon_project.png UFO: Alien Invasion / Closed Submit Patch #4758 BaseSubMenuToBaseSubMenuSwitchPatch
Go to the next issue (open or closed)
Go to the next open issue
This issue has been closed with status "Closed" and resolution "Not determined".
Issue basics
  • Type of issue
    Submit Patch
  • Category
    Scripts (.ufo)
  • Targetted for
    Not determined
  • Status
    Closed
  • Priority
    5. Important
User pain
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
Affected by this issue (0)
There are no items
People involved
Times and dates
  • Posted at
  • Last updated
Issue details
Attachments (0)
There is nothing attached to this issue
Duplicate issues (0)
This issue does not have any duplicates
Description
[http://sourceforge.net/p/ufoai/patches/631 Item 631] imported from sourceforge.net tracker on 2013-01-28 20:46:59

This makes it easy to switch from base submenu to base submenu.
If the submenu is not available or functional in the base switched to the main base menu of the new base is opened.

I was not able to produce any error with this version (tested with a savegame with 6 or 7 bases, multiple aircraft hangars, hospitals and multiple installations, so all kind of switching combinations were tested).
IMHO this could go to 2.4 as well. Feel free to test :)
===== Comments Ported from Sourceforge =====

====== mcr2010 (2011-10-08 15:32:38) ======

git diff
====== mcr2010 (2011-10-08 15:55:07) ======

5 bases savegame for testing
====== mcr2010 (2011-10-08 15:55:39) ======

Attached a savegame with 5 bases for easy testing...
====== mcr2010 (2011-10-09 09:29:00) ======

Attached updated version of the patch (further optimized):
====== mcr2010 (2011-10-09 09:30:07) ======

<- this is the optimized, updated version
====== mcr2010 (2011-10-19 10:00:46) ======

This is working flawlessly and I can see no better solution anywhere on the horizon, but still this patch is not applied.

I cannot understand the reason for this, but it certainly does not help my motivation to create new stuff for ufoai.

====== accumulator (2012-02-08 14:41:08) ======

Hi,

I merged this somewhat older patch against master, tested it and it works perfectly. I also would like to request this to be merged, the snap back to the building screen is quite annoying :)

Couldn&#039;t find how to attach files, so I uploaded it here (rebased against master) : http://www.outrightsolutions.nl/~sander/ubuntu/ufoai/ufoai-submenu.patch
====== accumulator (2012-02-11 23:24:45) ======

Any objections if I merge this??

====== tlh2000 (2012-02-12 07:57:51) ======

this wasn&#039;t merged yet because we once had that feature and it produced problems. this is something we would like to apply after 2.4 was released.
====== accumulator (2012-02-12 11:07:27) ======

I am playing now with the patch for about a week, and am still to encounter issues.

I hope someone else can also apply this patch locally, test, and provide feedback. It would be great to have this, from a usability standpoint!

====== accumulator (2012-03-03 15:50:52) ======

After a month of playing with this patch, I haven&#039;t seen any ill effects, so I decided to merge it to master.
====== tlh2000 (2012-10-15 11:07:16.493000) ======

- **status**: pending --> closed
Todos (0 / 0)
Issue created
footer_logo.png The Bug Genie 4.3.1 | Support | Feedback spinning_16.gif