UFO: Alien Invasion Issue Tracker
UFO: Alien Invasion
Go to the previous open issue
Go to the previous issue (open or closed)
star_faded.png
Please log in to bookmark issues
icon_project.png UFO: Alien Invasion / Closed Submit Patch #4741 Colored cli output on Windows
Go to the next issue (open or closed)
Go to the next open issue
This issue has been closed with status "Closed" and resolution "Not determined".
Issue basics
  • Type of issue
    Submit Patch
  • Category
    General
  • Targetted for
    Not determined
  • Status
    Closed
  • Priority
    1. Very low
User pain
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
Affected by this issue (1)
People involved
Times and dates
  • Posted at
  • Last updated
Issue details
Attachments (0)
There is nothing attached to this issue
Duplicate issues (0)
This issue does not have any duplicates
Description
[http://sourceforge.net/p/ufoai/patches/614 Item 614] imported from sourceforge.net tracker on 2013-01-28 20:46:59

ufo2map still put error Messages on a Messagebox
To mark errors red, warnings yellow or whatever on the cli
i've this proposal

===== Comments Ported from Sourceforge =====

====== tlh2000 (2011-06-11 09:50:55) ======

thanks for the patch.

please recheck our coding guidelines and use camelCase for variables
====== tlh2000 (2011-06-11 09:54:35) ======

imo it would be better to add a console to ufo2map for windows - and use Com_Printf with color codes like "^1This is a message", no?
====== mutonufoai (2011-06-13 06:17:01) ======

Com_Printf is unable to use stderr for a message ...

If you ask me
there should be only one function for any kind of output
define colors for win && *nix
a function with
a bitmask to know where to redirect the output
the colorcode
the message

But at the moment
i want simply to get rid of this messagebox used by ufo2map
====== tlh2000 (2011-06-13 08:18:07) ======

that's fine - and i will apply this patch once it meets our coding guidelines.
====== mutonufoai (2011-07-03 05:26:33) ======


====== mutonufoai (2011-07-03 05:27:30) ======

New patch uploaded
====== tlh2000 (2011-07-03 07:03:42) ======

reworked patch
====== tlh2000 (2011-07-03 07:05:11) ======

i've reworked the patch - but as i don't have windows, i can't test. Will leave this here until i get green light from a windows user.

* reduced code duplication
* applied coding guidelines
* renamed function
* moved comments and removed doxygen markers
====== tlh2000 (2011-07-04 19:38:01) ======

Applied to master - thanks
====== tlh2000 (2012-10-15 11:07:21.205000) ======

- **status**: pending --> closed
Todos (0 / 0)
Issue created
footer_logo.png The Bug Genie 4.3.1 | Support | Feedback spinning_16.gif