[http://sourceforge.net/p/ufoai/feature-requests/283 Item 283] imported from sourceforge.net tracker on 2013-01-28 20:16:10

aircraft buy/sell window does not use the same parts as the usual item buy/sell window, thus is missing some functionality.
it should use the same code, whenever possible.
===== Comments Ported from Sourceforge =====

====== geever (2008-07-19 16:45:09) ======

Logged In: YES
user_id=1729226
Originator: NO

I think I'm ready with this. I'll do the same with produce menu if okay.

-geever
File Added: ufoai.20080719.patch.zip
====== geever (2008-07-19 21:10:34) ======

updated patch
====== geever (2008-07-19 21:10:35) ======

Logged In: YES
user_id=1729226
Originator: NO

Updated patch attached. Modified
* coding guidelines
* const stuff
* removed some console command calls
Modified background picture will come with the next post.
Language files have been excluded from this patch.

-geever
File Added: ufoai.20080719-2.patch
====== geever (2008-07-19 21:32:39) ======

Logged In: YES
user_id=1729226
Originator: NO

I left some space below the box I've added for a 'Buy/Save' (and maybe 'Reset') button, see: https://sourceforge.net/tracker/index.php?func=detail&aid=1913891&group_id=157793&atid=805245

-geever
File Added: buy_lr.jpg
====== geever (2008-07-20 10:22:23) ======

Logged In: YES
user_id=1729226
Originator: NO

Removing obsolete patch.
-geever
====== geever (2008-07-26 22:18:43) ======

Logged In: YES
user_id=1729226
Originator: NO

Patch for the new design attached, see data_source/images/buy.xcf.bz2

-geever
File Added: ufoai.20080727.patch
====== geever (2008-07-27 08:31:36) ======

Logged In: YES
user_id=1729226
Originator: NO

File Added: buy.png
====== geever (2008-07-27 20:43:44) ======

Logged In: YES
user_id=1729226
Originator: NO

The new buy/sell menu was introduced in r17999.
Produce menu still needs to be changed.

-geever
====== stedevil (2008-07-27 23:05:00) ======

Logged In: YES
user_id=1256145
Originator: NO

My bug [1] was made a duplicate to this bug, but Im not sure I agree.

They seem to be touching the same area, but this one seems to mainly be about reusing existing code.
My bug is about actual GUI placement of functions and removing silly prerequisites for buying/selling/manufacturing.

That said, this bug could easily be expanded to include mine, but presently this doesnt (to me) seem to be the case.

[1] https://sourceforge.net/tracker/?func=detail&atid=805242&aid=2000790&group_id=157793
====== stedevil (2008-07-27 23:42:30) ======

Logged In: YES
user_id=1256145
Originator: NO

Ok, did SVN UP and it does seem that the patches here do what my bug suggests, and even more, so I agree with closing it. :)

Some quick feedback on the new buymenu.

Maybe there are too many different sections? 8 feels a tad much given that there is very few items in some of them.
Suggest merging
Miscellaneous + Personal Armour -> Personal Equipment
and
Heavy Weapons + Other -> Other
for a total of 6 instead of 8 subsections.
====== geever (2008-07-29 21:36:56) ======

Logged In: YES
user_id=1729226
Originator: NO

So here is a patch for the produce screen as I promised.
It's draft, maybe needs to polish somewhere but workin'. ;)

@stedevil : Sorry, I should have explained the planned solution in details.

-geever
File Added: prodscreenpatch.zip
====== tlh2000 (2008-07-30 10:00:09) ======

Logged In: YES
user_id=116930
Originator: NO

i've applied the coding guidelines, please please, use tabs and indent correctly.
File Added: coding_guidelines.diff
====== geever (2008-07-31 20:01:46) ======

Logged In: YES
user_id=1729226
Originator: NO

The new produce menu was applied to r18103. job done.

-geever