UFO: Alien Invasion Issue Tracker
UFO: Alien Invasion
Go to the previous open issue
Go to the previous issue (open or closed)
star_faded.png
Please log in to bookmark issues
icon_project.png UFO: Alien Invasion / Closed Bug report #3058 Reaction fire on/off icon
Go to the next issue (open or closed)
Go to the next open issue
This issue has been closed with status "Closed" and resolution "RESOLVED".
Issue basics
  • Type of issue
    Bug report
  • Category
    General
  • Targetted for
    Not determined
  • Status
    Closed
  • Progress
  • Priority
    4. Useful
User pain
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
Affected by this issue (0)
There are no items
People involved
Times and dates
Issue details
  • Resolution
    RESOLVED
  • Reproducability
    Not determined
  • Severity
    Not determined
  • Complexity
    Not determined
  • Platform
    Not determined
  • Architecture
    Not determined
Attachments (0)
There is nothing attached to this issue
Duplicate issues (0)
This issue does not have any duplicates
Description
[http://sourceforge.net/p/ufoai/bugs/3058 Item 3058] imported from sourceforge.net tracker on 2013-01-28 19:58:38

Trying to check if implementation matches specification for reaction fire. It's one of the open elements on 2.4 TODO page here:

http://ufoai.ninex.info/wiki/index.php/TODO/2.4

In the specification, it said that reaction fire should be On/Off, that there should be no single/multi selection and on should always work like multi (ie - the unit will continue to fire reaction shots as long as it is possible).
===== Comments Ported from Sourceforge =====

====== aduke1 (2012-03-03 23:20:22) ======

RF already works as 'always multi', so it's just the GUI selection that needs to be reduced to on/off.
bayo, can you help here ?
====== tlh2000 (2012-03-04 07:57:45) ======

does that also mean that STATE_REACTION_ONCE and STATE_REACTION_MANY are history?

see e_event_actorstatechange.c for the confuncs of the huds (startreactionmany and startreactiononce). these confuncs should be removed then.
====== tlh2000 (2012-03-04 08:06:14) ======

removed multishot reaction fire
====== tlh2000 (2012-03-04 08:06:38) ======

i've attached a patch that removes the multi shot reaction fire stuff from the hud and the game code
====== bayo-fr (2012-03-04 12:02:47) ======

I reassign it, i am not competant in that. Plus i never understand how the RF works
====== tlh2000 (2012-03-08 07:14:23) ======

the patch is now part of master - 6ae041686e66c17e7d17474685d95dcc089afe46
====== aduke1 (2012-03-10 20:52:08) ======

Patch works as intended.
But wouldn't it be better to use the 'multiple shots' icon ?
Because we have dumped single shot RF.
Steps to reproduce this issue
Nothing entered.
Todos (0 / 0)
Issue created
footer_logo.png The Bug Genie 4.3.1 | Support | Feedback spinning_16.gif