[http://sourceforge.net/p/ufoai/bugs/3006 Item 3006] imported from sourceforge.net tracker on 2013-01-28 19:58:38

rev. d0224a3c604f8cfd76f2b50dbfa49e943cf16185
Excerpt from ufoconsole.log:
2011/09/17 19:22:25 tiles: -farm/f_ +craft_ufo_harvester +field_a +craft_drop_firebird +road_h1 +road_h +road_h +road_rt +road_h +road_v1 +road_v +road_v +road_v +road_v +road_v +road_v +road_v +road_v +road_v +filler_l_b +filler_s +filler_m_a +silo +farmhouse_c +filler_s +filler_s +silo +filler_m_a +filler_m_a +filler_m_a +filler_m_a +filler_m_a +filler_m_a +filler_l_a +filler_l_a +filler_l_a +filler_m_b +filler_l_b +filler_l_a +filler_l_a +filler_l_a +filler_l_a +filler_l_b +wind +barn_a +filler_l_b +filler_l_b +filler_m_b +stables_b +stables_a +filler_m_b +barn_b
2011/09/17 19:22:25 pos: -48 -16 0 -40 16 0 16 24 0 32 -40 0 24 -40 0 40 -40 0 8 -40 0 16 -40 0 8 -32 0 8 -24 0 8 -16 0 8 -8 0 8 0 0 8 8 0 8 16 0 8 24 0 8 32 0 8 40 0 -48 16 0 -48 40 0 -8 40 0 0 32 0 -8 16 0 -8 32 0 0 -40 0 0 -32 0 -8 -24 0 -8 -16 0 -8 -8 0 -8 0 0 -8 8 0 32 -48 0 8 -48 0 -16 -48 0 16 40 0 40 32 0 40 8 0 -24 -40 0 -40 -48 0 -24 -32 0 -32 -24 0 -48 -48 0 -48 -24 0 -40 -40 0 16 0 0 24 0 0 32 8 0 32 -16 0 24 -32 0 16 -32 0 16 -16 0
2011/09/17 19:22:25 tiles: 51
2011/09/17 19:22:25 CM_LoadMap: "-farm/f_ +craft_ufo_harvester +field_a +craft_drop_firebird +road_h1 +road_h +road_h +road_rt +road_h +road_v1 +road_v +road_v +road_v +road_v +road_v +road_v +road_v +road_v +road_v +filler_l_b +filler_s +filler_m_a +silo +farmhouse_c +filler_s +filler_s +silo +filler_m_a +filler_m_a +filler_m_a +filler_m_a +filler_m_a +filler_m_a +filler_l_a +filler_l_a +filler_l_a +filler_m_b +filler_l_b +filler_l_a +filler_l_a +filler_l_a +filler_l_a +filler_l_b +wind +barn_a +filler_l_b +filler_l_b +filler_m_b +stables_b +stables_a +filler_m_b +barn_b" "-48 -16 0 -40 16 0 16 24 0 32 -40 0 24 -40 0 40 -40 0 8 -40 0 16 -40 0 8 -32 0 8 -24 0 8 -16 0 8 -8 0 8 0 0 8 8 0 8 16 0 8 24 0 8 32 0 8 40 0 -48 16 0 -48 40 0 -8 40 0 0 32 0 -8 16 0 -8 32 0 0 -40 0 0 -32 0 -8 -24 0 -8 -16 0 -8 -8 0 -8 0 0 -8 8 0 32 -48 0 8 -48 0 -16 -48 0 16 40 0 40 32 0 40 8 0 -24 -40 0 -40 -48 0 -24 -32 0 -32 -24 0 -48 -48 0 -48 -24 0 -40 -40 0 16 0 0 24 0 0 32 8 0 32 -16 0 24 -32 0 16 -32 0 16 -16 0"

<...>

2011/09/17 19:22:39 ********************
2011/09/17 19:22:39 ERROR: R_ModAddMapTile: maps/farm/f_stable.bsp not found
2011/09/17 19:22:39 ********************

<...>
(full log attached)

Note that there are &#039;+stables_b&#039; and &#039;+stables_a&#039; in the map definition but no +stable it seems that the loadmap string is getting cut when the RMA selects many tiles for an assembly, it sometimes takes a few tries to reproduce and seems to be more likely to happen when the craft_ufo_harvester tile is used.
===== Comments Ported from Sourceforge =====

====== darkrainx (2011-09-18 00:56:52) ======


====== darkrainx (2011-09-18 01:04:36) ======

A couple of other interesting instances of the same bug I&#039;ve found:

2011/09/17 18:36:27 tiles: 48
2011/09/17 18:36:27 CM_LoadMap: "-farm/f_ +craft_ufo_harvester +field_a +craft_drop_firebird +road_h1 +road_h +road_h +road_hs +road_h +road_h +road_h +road_h +road_h +road_h +road_h +road_h +filler_m_b +barn_b +filler_l_a +filler_l_a +silo +filler_l_a +filler_l_a +filler_s +filler_l_b +filler_m_b +barn_a +filler_s +filler_s +filler_m_b +filler_m_b +farmhouse_a +filler_l_a +filler_m_a +stables_a +filler_m_a +wind +filler_l_a +filler_m_a +filler_m_a +filler_m_a +stables_b +silo +filler_m_a +filler_l_a +filler_m_a +filler_m_b +farmhouse_b +filler_l_b" "-32 -8 0 16 -40 0 16 32 0 -40 -48 0 -48 -48 0 -32 -48 0 -24 -48 0 -16 -48 0 -8 -48 0 0 -48 0 8 -48 0 16 -48 0 24 -48 0 32 -48 0 40 -48 0 40 32 0 0 32 0 -16 24 0 -24 32 0 -24 24 0 -24 40 0 -48 24 0 -48 16 0 -40 0 0 -48 0 0 -48 -16 0 -32 32 0 -32 40 0 -48 32 0 -40 32 0 -48 -40 0 -48 -24 0 -32 -16 0 -24 -40 0 -24 -24 0 -16 -16 0 -8 -24 0 0 -16 0 0 -40 0 0 -32 0 8 -8 0 8 16 0 8 24 0 16 16 0 24 24 0 40 16 0 24 -8 0 40 -8 0"
<...>
2011/09/17 18:36:44 ERROR: R_ModAddMapTile: maps/farm/f_.bsp not found

-------------------------------------------

2011/09/17 18:56:09 tiles: 51
2011/09/17 18:56:09 CM_LoadMap: "-farm/f_ +craft_ufo_harvester +field_a +craft_drop_firebird +road_h1 +road_hs +road_h +road_h +road_h +road_h +road_h +road_h +road_h +road_h +road_rt +road_h +road_v1 +road_v +road_v +road_v +road_v +road_v +silo +filler_l_a +wind +farmhouse_c +filler_m_b +silo +filler_l_b +filler_m_a +filler_m_b +filler_l_b +filler_m_b +filler_m_a +filler_l_a +filler_s +filler_m_a +filler_m_a +filler_l_a +filler_m_a +field_a +filler_l_b +filler_l_a +filler_m_a +filler_m_b +barn_a +stables_a +filler_m_b +filler_m_a +filler_m_b +filler_s +filler_s" "-32 -40 0 -24 0 0 24 32 0 24 -8 0 -32 -8 0 -24 -8 0 -16 -8 0 -8 -8 0 0 -8 0 8 -8 0 16 -8 0 32 -8 0 40 -8 0 -48 -8 0 -40 -8 0 -48 0 0 -48 8 0 -48 16 0 -48 24 0 -48 32 0 -48 40 0 -32 -48 0 -24 -48 0 0 -48 0 -48 -24 0 -48 -40 0 -48 -48 0 -40 -48 0 -40 0 0 -40 8 0 -32 8 0 -40 24 0 -40 40 0 -32 32 0 -24 40 0 -16 40 0 -8 32 0 0 40 0 8 32 0 16 -48 0 8 -40 0 8 -16 0 32 -16 0 8 0 0 8 16 0 16 0 0 40 0 0 24 16 0 40 16 0 24 24 0 32 24 0"
<...>
2011/09/17 18:56:23 ERROR: R_ModAddMapTile: maps/farm/f_fille.bsp not found
====== tlh2000 (2011-09-18 12:02:41) ======

maybe: the buffer for the map tiles is too small to hold the full map string

but: we should not increase it! we should fix the ump to use less tiles
====== geever (2011-09-19 16:17:59) ======

mattn, I have to disagree. Less tiles == smaller map == less fun.

If you don&#039;t like mapstring buffer method, change the underlying structure, but don&#039;t limit the game please.

-geever
====== tlh2000 (2011-09-19 17:08:34) ======

and i have to disagree here, too - we have to stay in the limits and not increase them blindly. and less tiles does not mean smaller maps. but 1x1 fillers and a map with over 20 of those small tiles is just too much.
====== aduke1 (2011-10-21 21:31:43) ======

tlh2000, geever, I agree with both of you :)
But there is a rather easy way out.

The limit seems to be 512 (didn&#039;t find the limiting string, though) and the above string is around 540.
If we just renamed the fillers from eg. filler_m_b to fi_mb, it should do the trick.
That would also help SV_RmaPrintMap a lot btw.

Do you prefer to
a) do that yourself or
b) explain to me how to do a git rename ? *bg*
====== tlh2000 (2011-10-21 22:24:38) ======

it&#039;s done in SV_SetConfigString (CS_TILES, CS_POSITIONS)
====== aduke1 (2011-10-24 18:17:03) ======

Thx tlh2000, I&#039;ve been there.
But configstrings can be MAX_TOKEN_CHARS long, which is 256.
That wouldn&#039;t explain the truncation at 512.

Now I see that CS_TILES occupies several ie. MAX_TILESTRINGS=25 consectutive configstrings.
So that wouldn&#039;t explain the truncation at 512 either, right ?
====== tlh2000 (2011-10-24 20:02:48) ======

the two are specials configstrings that are using more than one slot
====== aduke1 (2011-10-24 20:19:26) ======

Err...that&#039;s what I was saying below. In configstrings those two strings can have 25x256 bytes. So where are they truncated to 512 ??
====== tlh2000 (2011-10-25 06:14:09) ======

cl_configstrings
sv_configstrings

these two commands might help to find the truncation - my suspect is still that they are cut in the configstring handling

i&#039;m currently not even sure whether SV_New_f is doing the right thing (tm)
there is a loop over all configstrings that does not take into account that some configstrings are using several slots.

but that would only explain a truncation at 256, not at 512
====== aduke1 (2011-10-26 22:39:38) ======

tlh2000, you were right, the prob was in SV_New_f.
I fixed it for CS_TILES and CS_POSITIONS, but technically this could also happen to
#define CS_PLAYERNAMES (CS_MODELS+MAX_MODELS)
#define CS_GENERAL (CS_PLAYERNAMES+MAX_CLIENTS)

Could you plz take a look ?
====== tlh2000 (2011-10-27 05:31:26) ======

CS_PLAYERNAMES and CS_GENERAL should not be affected, they are using multiple slots, yes - but only one entry per slot.

81bd0326dc9735c2405ed84cf4d3ba7f2f975a2e
====== darkrainx (2012-01-06 02:05:37) ======

Fixed