[http://sourceforge.net/p/ufoai/bugs/2728 Item 2728] imported from sourceforge.net tracker on 2013-01-28 19:47:16

I get an assertion failed when trying to sell an aircraft

I previously had problems with having more than 64 aircraft using 2.3 stable. (see bug) I am now using 2.3.1 (1291330966)
using Muton's ufoai-2.3.1-1291330966-Release-pentium3-O1-sse-7z-small-win32.exe

Error Message is Assertion failed!
Program: Q:\Games\UFOAI-2.3.1\ufo.exe
File: C\UFOAIwin32BUILDenv.old\MinGW\ufo...\cp_transfer.c
Line: 1633
Expression: aircraft->idx >=0 && aircraft->idx < MAX_AIRCRAFT
screenshot of error message attached

Error can be reproduced using attached savegame
In base 1 USA sell a Stilleto aircraft and that&#039;s when I get the assertion failed

Additional info in case it is relevant. That base has 9 aircraft, I am planning to have 8 aircraft in each base, but instead of transferring any aircraft, I am removing equipment then selling them and buying in another base as I have seen reported issues when transferring aircraft.
I could not find a way through the UI to select which aircraft I wanted to sell, so as a workaround I have instructed the other Stilletos to take off so the remaining one with no equipment gets sold.
===== Comments Ported from Sourceforge =====

====== grufff (2010-12-07 13:51:00) ======

screenshot of assertion error message
====== grufff (2010-12-07 13:52:09) ======

savegame
====== grufff (2010-12-07 13:53:05) ======

savegame
====== grufff (2010-12-07 13:56:18) ======

The bug I encountered with >64 aircraft was bug 3115394

====== geever (2010-12-09 23:35:36) ======

In 3bed84d03423978a0604cba0df06dff875690266 I removed that assert but that&#039;s quite a hack. :(

From 1314a61ecc73c1f5c66ae421e4948ce441c2bb0f you cannot buy or produce more aircraft than 64 (the UI will notify you).

Grufff, I do my best on fixing these bugs but you see your save is already corrupted to hell. Only one obvious fix I didn&#039;t do yet: Namely, we should deny loading savegames with bad aircraft indexes - but that would mean you cannot continue it...

Well, only two aircraft had wrong idx-es (Sou Lit6 LPPA => 64, Stiletto I => 67 (USA)) so I fixed your save for now (attached).

-geever

====== grufff (2010-12-10 19:53:00) ======

Geever,

thank you very much but did you attach the fixed .savx?
I can&#039;t see it here

Grufff
====== geever (2010-12-10 22:01:19) ======

fixedsave
====== geever (2010-12-10 22:02:27) ======

Sorry. In this shit (SF bugTracker) commenting and uploading doesn&#039;t work at the same time or what...

-geever
====== grufff (2010-12-11 10:07:28) ======

Awesome.
Thank you so much Geever

And yes i agree with the comment about sourceforge&#039;s bug tracker - it seems like you can upload files and add comments at the same time, but it seems you have to do one then the other

thank you again for all your help

--- grufff