[http://sourceforge.net/p/ufoai/bugs/2549 Item 2549] imported from sourceforge.net tracker on 2013-01-28 19:39:33

The old assertion failure crash to desktop bug with Phalanx craft mission pointer not being set has been fixed by geever earlier.

I just encountered another one:

I had sent two stilettos out of their homebase to chase a UFO when another UFO appeared and initiated a base attack. I was going to load a different savegame in any case, so I just set the base defense to auto mission, equipped soldiers and pressed go and then got an immediate crash to desktop with the following error message:

QUOTE
Assertion failed!

Program: [ufoai-installdirpath]\ufo.exe
File: [ufoai-sourcecodepath]\cp_aircraft.c
Line: 923

Expression: base != aircraft -> homebase

For information on how la-di-da-di-da and so on and so forth
END QUOTE

Looks like in the event that a base is destroyed while the aircraft assigned to that base are on a mission, the game has no mechanism for handling the sudden change with unassigned aircraft and then does what computer programs in that situation often do: Crashes and burns like a scout UFO faced with two Stilettos.


The problem could probably be solved by one of the following mechanisms:

Base destroyed and aircraft on mission causes a check for free hangars in other bases and immediate reassignment for the craft at large.

If the craft has no sufficient fuel to reach the new home base, the craft is destroyed (crash before it can refuel)

OR the craft is transferred to the base (it refueled on the way or landed elsewhere and commenced a transport mission to the new destination). In the latter case living quarter space must be checked that it can accommodate the pilot and possible soldiers as well, which probably makes this much more of a headache coding-wise. Unless extra personnel are immediately fired upon reaching the new base and available for recruitment to other bases in the Employees screen

If there are no free hangars, either the craft are destroyed or sold and personnel assigned to them fired and available for recruitment in the employee screen.

OR there is some other solution that is not obvious to me.


In any case it looks like a right royal headache to do unless you take the shortest route (the nuclear option for unassigned aircraft).

Screenshot attached. No ufoconsole.log available, since the crash information was not generated.
===== Comments Ported from Sourceforge =====

====== edirr (2010-05-30 15:20:25) ======

Assertion failure screenshot
====== geever (2010-06-02 19:36:28) ======

This assert was a just bug. But you were right about that some cases were not handled on auto-redirecting.

This assert was hit when we tried to redirect the aircraft to the same base as it was before. Bug, fixed.
If there were no possible base to redirect to the aircraft was simply left on geoscape. There another assert could have hit later somewhere (probably). Now aircraft destroyed in this case. (still not the final solution)
If aircraft was returning home when it's homebase destroyed and got redirected to a nearby base it would still go to the old base's position on geoscape. Bug, fixed.

These fixes were made in r30312 (trunk), r30313 (2.3).

-geever
====== sf-robot (2010-06-17 02:20:12) ======

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).