[http://sourceforge.net/p/ufoai/bugs/2531 Item 2531] imported from sourceforge.net tracker on 2013-01-28 19:39:33

Version: latest dev trunk r30085
OS: Ubuntu 9.10 Karmic Koala

In battlescape, once the player reserve some TU for fire, the time units can't be un-reserved for later use.

How to reproduce: Start battlescape, select any unit, press TU fire reservation button (handgun symbol), select any amount of fire units to reserve, try to select back "0 TU (No reservation)". The game won't allow.
===== Comments Ported from Sourceforge =====

====== tanelk (2010-05-21 08:14:01) ======

Not reproducible with alternative HUD. Should be related to original HUD reaction fire handling, they are obviously different.

althud:
1. press reaction fire
2. the least TU consuming fire mode is automatically checked
3. un-reserving and selecting other reaction fire modes works perfectly

Original HUD:

1. press reaction fire
2. TU-s are shown reserved, not the minimal amount though
3. reaction fire mode IS NOT automatically selected
4. selecting reaction fire mode (or un-reserving it) TU-s are added to the initial amount.
5. the TU-s initially reserved when reaction fire mode was not selected can not be un-reserved.

The method of reaction fire selection oforiginal HUD is not foolproof. Apparently it assumes that one doesn't press reaction fire before selecting the fire mode.

Why are the differences necessary anyway??
====== tanelk (2010-05-21 08:27:35) ======

Sorry, scratch the part about reaction fire mode selection/pressing the reaction fire button on the original HUD. The order is not relevant, it's just that reaction fire mode can't be turned off, only reduced to the least TU expensive mode (snap shot for example).

Althud still works :)

tested with trunk revision 30088
====== dodon (2010-05-21 11:00:57) ======

"0 TU (No reservation)" does not work (is always deselected) for both hud's, but the rightclick on the reservation button releases the reserved TUs

@tanelk :
don't mix "resereve TUs for schooting" and "reactionfire". Both reserve TUs but for different purposes

====== tanelk (2010-05-21 14:26:55) ======

Duh... don't know why I mixed the reaction fire and reservation for shooting. I seem to have "tested" them both...

What is the reason for not being able to un-reserve TU-s for shooting? It seems more consistent and logical to at least be able to select 0TU directly as well, even if the right-click method exists.

It's kind of a pain, I think I once noticed the right-click method among hints, but had forgotten.
====== dodon (2010-05-21 17:34:38) ======

My comment was a bit short.

"0 TU (No reservation)" should set the reserved TUs to 0 (and it did that a while ago). I tested this with both hud's and it did not work. So this IS a bug.

I attached a patch which should make it work again. The patch is for trunk, but it might also be necessary for the 2.3 branch.

@tanelk
look at
http://ufoai.ninex.info/wiki/index.php/Gameplay_Proposals/TUReservation



====== dodon (2010-05-21 17:45:59) ======

can't attach a patch to this thread so look here for the patch
http://sourceforge.net/tracker/?func=detail&aid=3005447&group_id=157793&atid=805244
====== tlh2000 (2010-05-23 07:32:57) ======

should be fixed with patch https://sourceforge.net/tracker/index.php?func=detail&aid=3005447&group_id=157793&atid=805244
====== sf-robot (2010-06-07 02:20:09) ======

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).