[http://sourceforge.net/p/ufoai/bugs/2489 Item 2489] imported from sourceforge.net tracker on 2013-01-28 19:35:59

Game reezes and locks with Red Error flashing on console.
Upon the last alien death and as experience points are being allocated to the Dropship team. When the error happens, you are forced to close down the game.
The screenshot (forum link supplied) is a subsequent occurrence. (not the first) A soldier was sent up the left side of the screen to "reveal" close aliens. As soon as the LOS (red line) appeared the error happened.
The error repeats at different stages of the game after each re-load of the save just before the mission. Sometimes at the very start, before the first soldier is moved, other times at different stages during the mission and after reloading the from the save point each time.

See http://ufoai.ninex.info/forum/index.php?topic=4726.0 screenshots, savegame and ufoconsole.log

Happened with builds: r29535, r29545, r29605, r29629, r29641, r29652, r29672 and my latest, r29728.
===== Comments Ported from Sourceforge =====

====== gren01 (2010-05-11 08:16:40) ======


====== gren01 (2010-05-11 08:22:23) ======

I'm not able to identify the conditions that bring on the error - however, it doesn't seem to rely on any particular build. As it stands, If I load up this save game, I am unable to progress any further, as you can see from the screenies, even taking on the mission from different bases produces the error as soon as the mission is loaded up and the team spawn is completed.

Has anyone tried loading my savegame to test - or is that not possible?

I tried loading up from a few games before and can usually get through one or perhaps two missions, but eventually, the error re-presents itself.

Maybe a suggestion would be to re-visit the solution applied the last time the error condition was identified.

Attached latest build console log file (r29845)
====== gren01 (2010-05-11 08:26:54) ======


====== gren01 (2010-05-11 08:28:51) ======

lint file compressed
====== gren01 (2010-05-11 08:29:30) ======

Attached save game files.
====== gren01 (2010-06-11 17:42:44) ======

ufoconsole.log
====== gren01 (2010-06-11 17:43:29) ======


====== gren01 (2010-06-11 17:45:49) ======

Created a new clean ufoconsole.log using debug commands to complete missions quickly until the error presented itself. When the error did occur, the ufoconsole.log was interrupted at the end, so I copied the text from the floating console window and pasted it into a text document.
====== geever (2010-06-11 21:09:56) ======

Tip: Next time, use `logfile 2' console command to force ufoconsole.log flushed from OS's cache on every write.

-geever
====== geever (2010-06-11 21:15:51) ======

You have quite few (337) free inventory slots from the beginning, strange... It should be near to 1000.
Could you upload the fresh save too? (only savx needed)

-geever
====== gren01 (2010-06-11 21:37:51) ======

game save file before error
====== gren01 (2010-06-11 21:41:05) ======

Save game file uploaded.
====== geever (2010-06-11 21:48:08) ======

Ok, the low free slots right after starting the ufoai made me thinking...

I started a game, waited for a mission. On start there were 973 free slots. Reloaded and tried again, same result.
Reloaded, cheated tons of guns at my first base, opened in-base equip screen. On mission start there were 880 free slots..

Conclusion: The in-base equip screen uses the same temp container that used for missions and seems not cleaned up on mission start. 337 still seems bit too few, but who knows... at least we have line to follow.

-geever
====== tlh2000 (2010-06-11 22:12:23) ======

i'm not sure whether this is an error geever, that's the way the items are stored - where exactly did you store or move the items from/to?
====== gren01 (2010-06-11 22:30:13) ======

Good progress... what you have mentioned reminded me that the slots ran out much quicker before I set uo autosell for collected items at the bases, so I guess you may be on-track. I guess it's not down to the way that the items are stored - more likely that something is not being cleared or re-initialised properly after a mission is completed (I suppose this would be when the dropship lands back at base) and before the next mission is selected.
====== gren01 (2010-06-18 14:27:56) ======


====== gren01 (2010-06-18 14:28:55) ======

This is still happening in r30545.
====== gren01 (2010-08-09 18:46:18) ======


====== gren01 (2010-08-09 18:47:53) ======

Any further progress on this problem please? Attached Screenshot from r31316. Would appreciate any suggestions you might have..

Thanks.
Gren
====== tlh2000 (2010-08-10 20:29:08) ======

The problem is, that we need a reliable way to reproduce this. Once such a way is found, it should be (relative) easy to fix this nasty problem.
====== tlh2000 (2010-08-10 21:07:00) ======

there are messages about free inventory slots now in r31366 and higher - please report these in case you hit this bug again with a the savegame or a new game.
====== tlh2000 (2010-08-11 06:36:49) ======

if you can reproduce this after 2 or 3 missions, we need to know what exactly you did in those missions. e.g. did an alien die? maybe a civilian, did you try to pick something up from the ground. Did you maybe see aliens changing their weapons when they pick something up. Everything here might be important to find the bug
====== gren01 (2010-08-11 08:35:10) ======

We have been at this stage before and I have submitted savegame files so that the error can be reproduced, unless you are telling me that you cannot run the game using the savegames sent.

The error appears at the very end of the 2nd or 3rd mission taken in continuation, when the last alien is killed and the experience points are being allocated to the team which has just completed the mission.

The game screen locks and in the centre of it, the floating console appears showing the details of the last solder's experience points allocation:

eg; "[STATS] Soldier {ABC123} earned XX experience points in skill #9 (total experience: XXXX) It is now: XXXX higher.

INVSH_AddInvList: No free inventory space!"

In the earlier missions, all aliens are killed. There are occasional wounded soldiers returning, but rarely any killed. All items auto-collected from the missions are normally auto-sold on return to the base. I rarely manually collect items by picking them up, so I do not think this has any importance here. Some civilians are killed in all missions.

I will run a few missions using r31366 and report back with savegame and log when the error appears.
====== tlh2000 (2010-08-11 10:07:34) ======

i tried three missions with your savegame - no crash - still 337 free inventory slots.
====== gren01 (2010-08-11 11:03:19) ======

Attached is result after 6 missions (7th mission crashed) Savegame is 2 missions before crash, which I used the console to kill team 7 to speed things up. Other missions were as described before - all aliens killed, no manually collected items, some civilian casualties in all missions, some wounded team members.

Console log also attached.
====== gren01 (2010-08-11 11:03:55) ======


====== gren01 (2010-08-11 11:04:43) ======


====== gren01 (2010-08-11 11:09:37) ======

slot3.savx is 313k and too large to upload here. Download from my Mediafire account if required:

http://www.mediafire.com/file/3ar0c59m26krn1m/slot3.savx

====== tlh2000 (2010-08-11 12:56:26) ======

that is really strange:
2010/08/11 11:48:05 Free inventory slots after battle: 122

so there are 122 left.

i've extended the debug output in r31373 and would beg you to retry it (i wasn't able to reproduce it, maybe it's windows-only)

to activate the debug output and see the new messages i've added you have to open the game console (shift+esc) and type "setdeveloper DEBUG_SHARED". after loading your savegame you should already see some messages about "I_AddInvList" - upload the ufoconsole.log after you got that error again.

thank you very much for your help. i hope we get it fixed soon
====== tlh2000 (2010-08-11 14:14:00) ======

http://ufoai.ninex.info/forum/index.php?topic=5265.0;topicseen

4) Tinkering with your inventory in the battlescape crashes you back to geoscape. It happened when I would take an item from the ground and try to put it in my backpack such that it overlapped an item already in my backpack. The specific items I used were a medkit and a plasma blaster and a heavy laser and a d-f magazine. This caused the battle to crash back to geoscape with an "no room in inventory message. After reproducing it, I avoided it in the future by carefully arranging cargo and never overlapping items.
====== gren01 (2010-08-11 15:56:44) ======

r31375 - Using the same savegame - I played 2 missions and killed off team 7 on the next mission - then the error appeared. Log attached.

I haven't confirmed/checked the problem with manually collecting items yet, but will do next task.
====== gren01 (2010-08-11 15:57:17) ======


====== gren01 (2010-08-11 16:06:16) ======


====== gren01 (2010-08-11 17:10:30) ======

Confirmation of crashing back to geoscape after manually adding items to inventory.

In "The Bridge" shot and killed Armoured Ortnok and picked up his pistol, dropping it on to the same pistol in my soldier's holster.
====== tlh2000 (2010-08-11 18:47:12) ======

[quote]Confirmation of crashing back to geoscape after manually adding items to inventory.[/quote]

i'm still not able to reproduce this, too. the holster can only hold one weapon, there is no space to drop a second pistol of the same type there.
====== gren01 (2010-08-11 19:51:20) ======

There may not be sufficient space in the holster, but I have reproduced this error twice by dropping the pistol over the top of the existing one. It does not happen easily, I had to repeat the action of dropping the weapon a few times before crashing out.

See attached shot...
====== gren01 (2010-08-11 19:52:00) ======


====== tlh2000 (2010-08-12 07:07:10) ======

is this also "working" (the crash happens) when you drop you own weapon and try to pick it up with another soldier? or must the equipment be from one of the aliens?
====== gren01 (2010-08-12 09:33:22) ======

I have been doing some inventory testing in a mission this morning, but have not been able to reproduce a crash. However, something quite strange is happening when exchanging soldiers weapons for dead alien weapons of the same type.

I have attached a couple of shots (before and after the last test) and a text document of various steps taken.

I am still testing....
====== gren01 (2010-08-12 09:34:06) ======


====== gren01 (2010-08-12 09:34:36) ======


====== gren01 (2010-08-12 09:35:11) ======


====== gren01 (2010-08-12 11:33:28) ======

I am not able to complete this latest mission because of the error. It is a Harvesting mission on the [Oriental big] map.

I have played through the mission to the end successfully, but then had the error. I have re-loaded the savegame 3 or 4 times and used the console to kill and stun team 7, but the error always appears at the end.

If you need the savegame it is on Mediafire: http://www.mediafire.com/file/27blmdvvjb9nkr2/slot7.savx

The ufoconsole.log and screenshot attached.
====== gren01 (2010-08-12 11:33:57) ======


====== gren01 (2010-08-12 11:34:28) ======


====== gren01 (2010-08-13 10:32:49) ======

Compiled and installed r31415. 1st mission: Port Moresby, Terror mission against alien corrupter. Set DEBUG_SHARED and killed team 7. INVErr crash - Screenshot and Log attached.
====== gren01 (2010-08-13 10:33:22) ======


====== gren01 (2010-08-13 10:33:53) ======


====== tlh2000 (2010-08-13 10:50:53) ======

Speed up on GeoScape, enter mission => crashes immediately ("No free inventory space!").
====== tlh2000 (2010-08-13 11:20:22) ======

i wonder whether can somehow nail it down to died aliens or dead spawned aliens. i'm getting the same in a multiplayer game - so maybe every inventory that is not yours (as in alien, or human opponent) gets out of sync over time
====== gren01 (2010-08-13 11:32:34) ======

A good train of thought....
I have noticed that the smaller the alien craft in the mission (crew members) the more missions I can do before the error appears, but I don't think that will help you very much. Is there something you can record in the log to do a dead alien body count? or their inventory perhaps?
====== gren01 (2010-08-13 11:40:14) ======

Further thought on this is the seemingly worrying fact that the log records and reports spare slots available, when the error condition appears for the human player in SP mission, telling us that there is no inventory space. So its logical to think that you could be on the right track by looking elsewhere.
====== tlh2000 (2010-08-13 12:16:24) ======

i won't be around the weekend - if you find something more, attach it here, but don't expect responses until the start of the next week
====== gren01 (2010-08-18 11:37:19) ======

Now running on windows 7. Link below is to ufoconsole.log and a couple of screenshots after successfully completing a run of around 9 missions. (too large to attach here)

running updated version: r31556 - with DEBUG_SHARED enabled.

http://www.mediafire.com/file/b9hop7q7jlkqifo/UFOAIErrDets.zip

====== tlh2000 (2010-08-18 13:54:55) ======

9 missions - file from external link
====== tlh2000 (2010-08-18 13:55:15) ======


====== tlh2000 (2010-08-18 13:55:32) ======


====== tlh2000 (2010-08-18 13:58:28) ======

the more i look at this, the more i think you just have too many items ;)

maybe we have to increase the limit.
====== gren01 (2010-08-18 14:30:55) ======

It's not too clear to me where you think I am holding too many items. Do you think my soldiers carry too much equipment, or am I holding too much at base storage level? If you can point me at the areas you suspect, I can reduce items accordingley and do some more testing with different levels.

Gren
====== tlh2000 (2010-08-18 15:30:52) ======

both might be possible - but if it's possible to carry that many items in base storage or soldier equipment (they are all using the same inventory list) - then we should increase the limit. try to sell a few hundret items on the market and see whether this bug pops up again.
====== tlh2000 (2010-08-18 15:33:14) ======

it depends on how many soldiers you have and how many bases you have...

each soldier and each base can have the (amount of items from the scripts) * (the amount of containers)

for each base that would already be 8*108 - not counting the soldiers - it's highly unlikly that a player would place all possible items in each base. but it's possible. so we should think about changing this.
====== tlh2000 (2010-08-18 17:34:04) ======

please check r31567 - it should be fixed there - feedback is more than welcome.
====== gren01 (2010-08-18 19:58:39) ======

Thank you for the time spent on this Martin. It looks to be running much better... I have had an hour or so of continuous missions without INV error. Having said that, I just had a crash, but I think it is a completely different problem and one which I want to test for further.

On the death of the last alien, right clicking anywhere on the map causes the game to hang.. It has actually happened once before on a different map, but I would like to test again.

I would leave this bug set at "Pending" until after my next long run, but so far its looking rather good. ;)

Gren
====== tlh2000 (2010-08-19 05:49:34) ======

set back to pending

that looks like a different bug - if it hangs, please go into gdb and try to find the location where it loops
====== tlh2000 (2010-08-19 05:49:53) ======

oh... and open a new ticket for that bug if you found something
====== sf-robot (2010-09-29 19:25:47) ======

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).