UFO: Alien Invasion Issue Tracker
UFO: Alien Invasion
Go to the previous open issue
Go to the previous issue (open or closed)
star_faded.png
Please log in to bookmark issues
icon_project.png UFO: Alien Invasion / Closed Bug report #2090 splash damage does not take armour or randomnes into account
Go to the next issue (open or closed)
Go to the next open issue
This issue has been closed with status "Closed" and resolution "Not determined".
Issue basics
  • Type of issue
    Bug report
  • Category
    Battlescape
  • Targetted for
    Not determined
  • Status
    Closed
  • Priority
    5. Important
User pain
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
Affected by this issue (1)
People involved
Times and dates
  • Posted at
  • Last updated
  • Estimated time
    Not estimated
Issue details
  • Resolution
    Not determined
  • Reproducability
    Not determined
  • Severity
    Not determined
  • Complexity
    Not determined
  • Platform
    Not determined
  • Architecture
    Not determined
Attachments (0)
There is nothing attached to this issue
Duplicate issues (0)
This issue does not have any duplicates
Description
[http://sourceforge.net/p/ufoai/bugs/2090 Item 2090] imported from sourceforge.net tracker on 2013-01-28 19:18:54

In file src/game/g_combat.c:536 (trunk rev 23981, which is HEAD at the time of this writing) it seems like that splash damage does not take armour protection into account, only distance. Nowhere in the code is spldmg[1] being used (the random part of the splash damage), so I believe this is also not taken into account.
I have not verified this bug in-game (too dificult to set up reliably), only by code inspection, so I might be mistaken.
--dumper
===== Comments Ported from Sourceforge =====

====== c-oreills (2010-04-22 18:34:30) ======

Armour is taken into account, but you're right, spldmg[1] doesn't seem to be.

On g_combat.c:534 splash damage calls G_Damage, a generic damage function which checks for armour starting on line 351.

A grep for spldmg[1] doesn't show it anywhere in the source, but this seems to be intentional - from inv_shared.h:124:

vec2_t spldmg; /**< G_SplashDamage(), currently we use only first value (spldmg[0]) for apply splashdamage effect */

Therefore I don&#039;t think this is a bug, but would possibly be valid as a feature request to implement the random component of splash damage.
====== dumper (2011-01-07 01:19:13) ======

I filed this bug long ago and just remembered about it. I am closing it now because it is not really a bug, and may divert attention from more necessary tasks. Thanks, c-oreills.
Steps to reproduce this issue
Nothing entered.
Todos (0 / 0)
Issue created
footer_logo.png The Bug Genie 4.3.1 | Support | Feedback spinning_16.gif