project-navigation
Personal tools

Author Topic: Recoding Hospital  (Read 4146 times)

Offline stevenjackson

  • Rookie
  • ***
  • Posts: 90
    • View Profile
Recoding Hospital
« on: May 17, 2008, 08:34:33 am »
Hi

I was wondering what the plans for the Hospitals were.
Are there any plans to rework some of the aspects?

I noticed on the forums there were quite a few comments on the effectiveness of the hospitals.
I'm interested in making some changes to the hospitals to be included in the trunk and i was just wondering were they were at, plans wise and if i wanted to implement some changes, what the process was?

Steve

Offline blondandy

  • Sergeant
  • *****
  • Posts: 391
    • View Profile
Re: Recoding Hospital
« Reply #1 on: May 17, 2008, 08:37:09 am »
submit a patch to the tracker on sf.net.

Offline stevenjackson

  • Rookie
  • ***
  • Posts: 90
    • View Profile
Re: Recoding Hospital
« Reply #2 on: May 17, 2008, 11:07:57 am »

I'm happy just to make all the changes.

I'm wondering more about what are the criteria under which it'll be accepted.  I dont want to make the code changes if it gets knocked back.  Or would i just get some feedback on the changes needed to the patch for acceptance?

Steve

Offline BTAxis

  • Administrator
  • PHALANX Commander
  • *******
  • Posts: 2607
    • View Profile
Re: Recoding Hospital
« Reply #3 on: May 17, 2008, 11:34:27 am »
Like blondandy said, make the changes you want, then make a patch out of that and send it to the SF tracker, along with a description of what it does. You will need to adhere to the coding guidlines. If your patch is judged acceptable, one of the devs will apply it to trunk. If not, you'll be told why.

Offline stevenjackson

  • Rookie
  • ***
  • Posts: 90
    • View Profile
Re: Recoding Hospital
« Reply #4 on: May 17, 2008, 01:19:47 pm »
ok, thanks.

I'll do that.

Steve

Offline blondandy

  • Sergeant
  • *****
  • Posts: 391
    • View Profile
Re: Recoding Hospital
« Reply #5 on: May 19, 2008, 11:03:01 am »
mattn (aka tlh2000) is very good at checking the patch tracker. you will generally get feedback quickly. patches get acted on much faster than bug reports.

Offline Mattn

  • Administrator
  • PHALANX Commander
  • *****
  • Posts: 4831
  • https://github.com/mgerhardy/vengi
    • View Profile
    • Vengi Voxel Tools
Re: Recoding Hospital
« Reply #6 on: May 19, 2008, 03:34:05 pm »
[...]patches get acted on much faster than bug reports.[...]

because it's less work to review a patch than to fix a bug :-D