UFO:Alien Invasion

Development => Coding => Topic started by: stevenjackson on May 17, 2008, 08:34:33 am

Title: Recoding Hospital
Post by: stevenjackson on May 17, 2008, 08:34:33 am

Hi

I was wondering what the plans for the Hospitals were.
Are there any plans to rework some of the aspects?

I noticed on the forums there were quite a few comments on the effectiveness of the hospitals.
I'm interested in making some changes to the hospitals to be included in the trunk and i was just wondering were they were at, plans wise and if i wanted to implement some changes, what the process was?

Steve

Title: Re: Recoding Hospital
Post by: blondandy on May 17, 2008, 08:37:09 am

submit a patch to the tracker on sf.net.

Title: Re: Recoding Hospital
Post by: stevenjackson on May 17, 2008, 11:07:57 am

I'm happy just to make all the changes.

I'm wondering more about what are the criteria under which it'll be accepted.  I dont want to make the code changes if it gets knocked back.  Or would i just get some feedback on the changes needed to the patch for acceptance?

Steve

Title: Re: Recoding Hospital
Post by: BTAxis on May 17, 2008, 11:34:27 am

Like blondandy said, make the changes you want, then make a patch out of that and send it to the SF tracker, along with a description of what it does. You will need to adhere to the coding guidlines (http://ufoai.ninex.info/wiki/index.php/Coding_guidelines). If your patch is judged acceptable, one of the devs will apply it to trunk. If not, you'll be told why.

Title: Re: Recoding Hospital
Post by: stevenjackson on May 17, 2008, 01:19:47 pm

ok, thanks.

I'll do that.

Steve

Title: Re: Recoding Hospital
Post by: blondandy on May 19, 2008, 11:03:01 am

mattn (aka tlh2000) is very good at checking the patch tracker. you will generally get feedback quickly. patches get acted on much faster than bug reports.

Title: Re: Recoding Hospital
Post by: Mattn on May 19, 2008, 03:34:05 pm

Quote from: blondandy on May 19, 2008, 11:03:01 am

[...]patches get acted on much faster than bug reports.[...]

because it's less work to review a patch than to fix a bug :-D