[fixed] R27939 - reaction fire reservation doesn't work

[Halleth]

When I toggle reaction fire reservation nothing changes - no "green stripe" is shown, I am still able to use all the points. However, if I set the reaction fire mode "ON" and I assure enough TU's, reaction fire can be triggered.

[Spyro]

I have this problem as well. I am using r27965, and here are the symptoms...
Reaction fire - single and multiple - does not work (see illustration)
Reserving TUs for shooting does not reserve the TUs
Reserving TUs for standing/crouching does not reserve the TUs

I have tried with a new campaign, a saved campaign, and a skirmish. The same problems exist regardless of the type of game that I start.

The problem must have come about in r27939, because r27938 did not have any of the above problems (also, the code changes in 27939 altered the TU reservations system).

http://ufoai.svn.sourceforge.net/viewvc/ufoai/ufoai/trunk/src/client/battlescape/cl_actor.c?r1=27939&r2=27938&pathrev=27939

On a slightly unrelated note, multiple shot reaction fire has not worked for me for quite some time (or atleast the indicator - the green bar - never displays it).

[Spyro]

Undoing the changes in 97939 brings back the TU reservation system. Additionally, reaction fire was not broken before, but it might as well have been because there were no TUs being reserved (and I am not nearly clever enough to survive without that feature).

I have attached a very simple patch that rolls back the changes in 97939. This patch should be applied against 27965. More recent revisions may or may not apply cleanly.

To use this patch:
* Place the tu_fix.diff into your ufoai source code directory (the same place you run ./configure, make, etc)
* Open a terminal, go to that directory, and run the following

Code: [Select]

patch -p0 < ./tu_fix.diff
Edit: Forgot to attach the file!

[Mattn]

please fix the bug, not the symptoms - the reservation must be handled on the server side, and is send back to the client in the newly introduced network event. there must be the problem.

[Spyro]

Ah, thanks for the reply. I have taken a quick peek at the event in question but I didn't see anything that jumped out as being problematic.

I will dig a little deeper over the weekend.

[Halleth]

Thanks guys!

[Spyro]

Thanks mattn! And while I'm at it, thanks to everyone else who contributes to this wonderful game!

Now I can split my time on the weekend between playing and digging around the source code... Until recently I had not realized that ufoai has one of the larger C codebases among open source games. Next time I have a problem, I am hopefully able to address the problem itself rather than the just the symptoms.