[q] about stable v2.2.1: research code

[bfett14]

Found this piece in cl_research.c. It looks to me it never goes beyond first if().
Anybody can hint what was original intent here?

void RS_CheckAllCollected (void)
{
   int i;
   technology_t *tech = NULL;
   requirements_t *required = NULL;

   if (!required)
      return;

   if (!baseCurrent)

[geever]

Found this piece in cl_research.c. It looks to me it never goes beyond first if().
Anybody can hint what was original intent here?

In the latest revision, there is no function named like that. That must have been a bug.

-geever

[criusmac]

He's not talking about the latest revision.

He's talking about the stable v2.2.1: research code.

This function originally was used to ensure that we looted all the items needed to be able to properly buy and sell things. It was called from cl_market.c "BS_BuyType_f" which was the init function for the buy and sell menu list. There was a todo on the call asking if it was even needed. I'm guessing not since in the latest revision, the function does not exist.

However, in v2.2.1, yes, the function is called, and yes, actually did nothing since it returns immediately on the first if statement.

I've noticed the developers tend to ignore anything older than the latest revision here in regards to the code. I recommend to play the ancient stable v2.2.1 if you just want to enjoy the game, but to not look at its code unless it is the latest revision of code. This is probably why Geever just looked at only the latest revision, and ... not much else. He is right though, just not verbose.