project-navigation
Personal tools

Author Topic: Figthers unreparable.  (Read 12918 times)

Offline cevaralien

  • Rookie
  • ***
  • Posts: 85
    • View Profile
Figthers unreparable.
« on: July 06, 2014, 10:50:53 pm »
When the fighters are at 50% of damage, the craft doesn´t repair. I must sell the aircraft and buy another one.

I think this is a bug.

Offline anonymissimus

  • Sergeant
  • *****
  • Posts: 347
    • View Profile
Re: Figthers unreparable.
« Reply #1 on: July 07, 2014, 05:08:43 pm »
Never happened to me, but if they repair if they are below 50% and continue to do so once they reach 50% you could carefully get them some more damage instead of selling.

Offline cevaralien

  • Rookie
  • ***
  • Posts: 85
    • View Profile
Re: Figthers unreparable.
« Reply #2 on: July 08, 2014, 02:58:36 am »
Yeah, but less than 50% is a dead fighter normaly. So, i prefer to sell the craft.

Offline cevaralien

  • Rookie
  • ***
  • Posts: 85
    • View Profile
Re: Figthers unreparable.
« Reply #3 on: August 07, 2016, 04:43:45 pm »
Hi.

I retake this post because i had the problem of 2014. I begun a new game and i notice that my craft aren't repairing more than 50% of the initial health. This is a bug or is a natural condition of the game?

Offline geever

  • Project Coder
  • PHALANX Commander
  • ***
  • Posts: 2561
    • View Profile
Re: Figthers unreparable.
« Reply #4 on: August 07, 2016, 06:41:45 pm »
The aircraft are slowly repaired while idle in the hangar. Could you upload the savegame so I can check?

-geever


Offline cevaralien

  • Rookie
  • ***
  • Posts: 85
    • View Profile
Re: Figthers unreparable.
« Reply #5 on: August 12, 2016, 05:15:05 am »

Offline geever

  • Project Coder
  • PHALANX Commander
  • ***
  • Posts: 2561
    • View Profile
Re: Figthers unreparable.
« Reply #6 on: August 14, 2016, 04:13:17 pm »
Sure, no problem.

https://www.dropbox.com/sh/sm8u0ua16tbjq85/AABv_YSjJb_Pa7wOgO_MhZzna?dl=0

@cevaralien are you playing a modded version of the game? Asking because your savegame is not compatible with the main game (neither 2.5 nor 2.6 versions).

-geever

Offline cevaralien

  • Rookie
  • ***
  • Posts: 85
    • View Profile
Re: Figthers unreparable.
« Reply #7 on: August 17, 2016, 04:49:19 am »
Yes, it is a mod. I'm playing 2.5, Linux version, but my own mod.

Offline cevaralien

  • Rookie
  • ***
  • Posts: 85
    • View Profile
Re: Figthers unreparable.
« Reply #8 on: August 20, 2016, 11:54:56 pm »
Do you need a copy of my mod, really? I was waiting for publishing, but, here it is:

https://www.dropbox.com/s/wrhw7byj2zhkpdt/Proyect%20Reality%20V2.zip?dl=0


Thanks for the help.


Offline geever

  • Project Coder
  • PHALANX Commander
  • ***
  • Posts: 2561
    • View Profile
Re: Figthers unreparable.
« Reply #9 on: August 24, 2016, 12:20:03 am »
Sorry for the late answer, I was busy with RL. Actually first, I wanted to fix the crash that happen on loading the savegame, then investigate the repair issue. The later has turned out to be a rounding issue, I fixed both issues in master (2.6-dev).

-geever

Offline geever

  • Project Coder
  • PHALANX Commander
  • ***
  • Posts: 2561
    • View Profile
Re: Figthers unreparable.
« Reply #10 on: August 24, 2016, 12:35:58 am »
Backported the fixes to ufoai_2.5 branch too.

-geever

Offline cevaralien

  • Rookie
  • ***
  • Posts: 85
    • View Profile
Re: Figthers unreparable.
« Reply #11 on: September 04, 2016, 04:37:43 pm »
Ok. Thanks.

Offline cevaralien

  • Rookie
  • ***
  • Posts: 85
    • View Profile
Re: Figthers unreparable.
« Reply #12 on: December 23, 2016, 02:11:32 am »
Hi friends.

I know why this bug is happening. If you mod the aircraft armour shield value, giving a number below +4, the game take it as a percentage. For example, i changed the value to +2 but the game shows 100%, not +2. When i put again on +4, the game show that value and the aircraft repair itself at base.

So, if you mod the aircraft shield armour, don't give values below +4.


Offline cevaralien

  • Rookie
  • ***
  • Posts: 85
    • View Profile
Re: Figthers unreparable.
« Reply #13 on: December 25, 2016, 02:27:41 am »
Well...

The game was working well, but... again, my aircraft isn't repairing.

  :-[

Offline cevaralien

  • Rookie
  • ***
  • Posts: 85
    • View Profile
Re: Figthers unreparable.
« Reply #14 on: December 30, 2016, 02:55:47 am »
Ok, i found the problem.

When the damage of the aircraft is changed to a value below 100, the craft don't repair. I search the source code and i found that the repair ecuation is divided by 100, so, i think it is a "problem" with the aircraft damage modding.