Equipment disapears

[Azrael0480]

Hi, i just realized that different items disappear randomly. This ranges from weapons, medikits, ir-goggles, grenades ...

I realized it in the nightly build from November 04, 2012.
In the build from October 18, 2012 there where no problems.

A savegame is atttached.

Azrael

[Mattn]

can you explain a little bit more when this might happen? what actions you did and so on? we recently made it possible to equip soldiers without an aircraft.

[Azrael0480]

Hi, i tried to reproduce it.
I equiped a squad and changed the armor and equipment from inactive to active squad members.
Then I took some sceens of the items I own, went on a mission. After winning the mission I looked at the buy/sell screen and saw that I lost 8 grenades (used only one in the mission), 5 medikits (used 2 in the mission), one grenade launcher + PA ammo was missing (owner wasn't even a active squad member and waiting "at home"), 2 IR goggles missing, 2 Plasma grenades missing..


Two squad members were killed during the mission, but i thought that all equipment of dead soldiers should be brought back with the transport after the mission. (I compared some screenshots before the transport arrived after the mission and after the transport arrived back home, and saw that the items of the dead soldier were brought back succesfully. So missing items are not from the dead squard members.)

I'm not sure but it could be that the missing items are all from squad members that stayed at home during the mission.
I'll try to reproduce and check that later.

Azrael

[Anarch Cassius]

Dead soldiers won't leave recoverable armor is one thing I've noticed.

I'm not sure this is a bug or a feature. On the one hand that armor being damaged is likely but on the other hand you can recover the aliens' armor.

[Lynol]

Greetings everybody!

I want to report the same / a similar problem like Azrael:

I use the nightly build of November 1st  and upgraded on the 4th and 6th. The bug first occured on the 5th. Win 7 64bit, full campaign, hard dif, no other problems occured so far.

In the attached save, a firebird returns from a mission. After it has landed, the soldiers will still have all their equipment in their portrait (menu: aircraft, goto Firebird, goto tab: soldiers).

But when you click on "Equip soldiers" on the firebird, several items will have disappeared. They are neither in the soldiers' inventory nor in storage.

E.g. The first soldier, "Sylvie" does not lose anything, while three others will lose all their equipment and armor.

The bug is reliably reproducable. The disappearing items are consistently the same, as far as I can see (which is why I initially thought of a memory problem; I hired more soldiers and buyed more weapons just before it happened and then maybe "item230 to item248" are cut off from an array or something like that).


If the bug is just the expected result from the recent changes you did to the equipment system, please ignore this. 

[johndo42]

Hello,

I also noticed this bug after "equip soldiers without an aircraft" feature was added. this feature is very useful and i like it much.

as the bug is quite much annoying, i gave a try to look in the code and commit logs of changes related to the new feature, and my findings are following:

in commit 3c13bdc675d91149b98fee3200e917103169ea54 from Oct 28, 2012
* allow equipping soldiers without aircraft (call: "ui_push equipment…

there was change to src/client/cgame/campaign/cp_campaign.cpp in function CP_StartSelectedMission (void):
-  CP_CleanupAircraftCrew(aircraft, &ccs.eMission);
+  CP_CleanupTeam(base, &ccs.eMission);
i understand this change as all soldiers in base are now equipped before any mission and their inventory is removed from the stock in base. before this change, only soldiers assigned to aircraft were equipped.

I found the logic happenning after the mission in src/client/cgame/campaign/cp_aircraft.cpp in function void AII_CollectingItems, which collects all items from the ground and carried (i believe) only by soldiers included in the mission (assigned to aircraft) and return it to the inventory...

so from my quite high level point of view, equipping all soldiers in a base before mission, but returning equipmnet of only soldiers included in combat seems to be the casue of equipment disappearing.

as this was my very first try to look in the code, which is quite complex, i might be wrong. anyway i still believe this information may be helpful to someone that is able to fix it (unfortunately i am not yet...).

 

[geever]

Equipping doesn't remove any items from the base storage at all (yet), but it's possible that I missed some trick in AII_CollectingItems, I'll check it as I find some free time.

-geever

[geever]

Update: The issue has been patched yesterday. Report back if still happens...

-geever

[Lynol]

Heh, great you looked into this. I guess it's not safegame compatible. Will report back when as soon as I have the time to start a new campaign.

[geever]

Heh, great you looked into this. I guess it's not safegame compatible. Will report back when as soon as I have the time to start a new campaign.

It is compatible. Ofc. It doesn't give you back the items were lost but otherwise works.

TBH, It was a temporary fix, I'm going to revamp the item collecting system when I find some time.

-geever

[Lynol]

Continued from the uploaded safe.

The same items disappeared (firebird landed, solderis have requip, click "euqip", item disappear). It's no gamebreaker, I'll buy replacements and check whether it happens again after the next mission.

[johndo42]

i tried the patch today and it was OK for me. i tried new mission from a quicksave which is automatically done before each mission and no item was lost, so i am even able continue my campaign.
ps: thanx.

[geever]

The same items disappeared (firebird landed, solderis have requip, click "euqip", item disappear).

Items of equipped soldiers of the base who were not on the mission were faultly deducted from storage.

-geever