new tile for +oriental

[Kildor]

The main problem in round things is pathfinding and square game.

[jerikojerk]

it's hard to understand without knowing the algorythm...

 i guess it can be a round thing with uncrossable objects in the square corner so we don't confuse the pathfinder.

edit: now i think i get it; pathfinder only know about 4 or 8 direction on a same level? if so round tower and square stair should fit ?

[H-Hour]

It could be done, but the circular staircase would have to be very large (at least 4x4 grid squares in-game) and there would be lots of wasted space. And it would be lots of work for what would be a slightly-annoying feature in-game.

[tilli]

thx kildor for the changes

the idea with a larger tile is good, I will implement that later.

I changed the walls texture of the minaret a little.

[Mattn]

add them to master and integrate them

[H-Hour]

Looks good!

[Mattn]

your new map or_house_i is missing in the oriental.ump.

[tilli]

your new map or_house_i is missing in the oriental.ump.

not any more, along with the other changes.

[Mattn]

https://github.com/ufoai/ufoai/commit/8ad98d14d0627d8ad9890ae3992a1c364859c597

i think you did something wrong - you readded the seedlist - and changed a lot of other things - i don't think that all changes were intentional. please doublecheck

[tilli]

you readded the seedlist

please explain what that means?

I only did the following:
changed order of entries, so same tile types (houses, stands, etc) are in the same block
added missing tiles
added tilesets
incorporated that in the maps

any consequences I'm not aware of?

[H-Hour]

Have a look at the link that mattn posted. It will give you a blow-by-blow account of what your commit changed in the .ump file. Anything with a red background and a (-) in the front is a line that was removed. Anything with a green background and a (+) in front was added.

From this you can see that your commit added a seedlist. Is it possible that you made your changes to what was not the latest copy of the file. You can see the file history as well.

[Mattn]

See the diff i posted

[tilli]

got it, my mistake 

will simply removing the seedlist be ok, or is more to do?

[H-Hour]

will simply removing the seedlist be ok, or is more to do?

You should be able to see from the diff if there is any change there you didn't intend (other than the seedlist). Removing the seedlist is probably enough, but doing a quick load-check on each assembly after you've made the change would be nice just to ensure there are no errors accidentally introduced.

[tilli]

finished some work on +oriental
- randomspawn
- added some buildings (houses, minaret, shed, stand)
- updated oriental.ump
- miscellaneous stuff

For the moment I would like to wrap it up, are there any issues, which need to be take care of in +oriental, which I'm not aware of?