[32055] stunned alien bug

[jerikojerk]

to get great improvement, we have to go through some bugs.

what happen: 255 aliens were rescaped from a mission i won.

what is noticeable is that i stunned an ortnok, then the very last remaining ortnok with the stun staff, the orthnok stay alert, then shot a burst of plasma riffle at this ortnok (whom die grrr) and get the following strange victory, immediatly followed by game over message.

[jerikojerk]

i think killing a alien who was already stunned is the key of this bug. 255 looks like unsigned issue for -1 as i suspect "remaining aliens" are computed from killed alien minus stunned alien.

If you allow to kill stunned alien, you have to increment killed alien count AND decrement stunned alien count.

Did i good guess?

[jerikojerk]

i noticed that you could stunned a alien two times, with stunned grenade, and get this victory and the game over.

[Mattn]

please let me know whether these nasty critters are still alive

http://ufoai.git.sourceforge.net/git/gitweb.cgi?p=ufoai/ufoai;a=commitdiff;h=d9cfa85d3ebe2562ec9fbbc2f662a0c7f521b8e4

[jerikojerk]

ok if i understand well, i apply the patch and pleasure check if it's fixed. I know about the repository been locked, but your project is the only one i follow on sourceforge been affected... what really happens?

[Kildor]

project has been switched to the git. Read news on main page, please.

[jerikojerk]

i'm trying to kill an stunned alien, it doesn't work anymore, so the victory message is ok. Your patch seems to work fine.

Code: [Select]

/**
  * @@ -350,14 +424,21 @@ static void G_ActorDie (edict_t * ent, const edict_t *attacker)
  * @todo Discuss whether stunned actor should really drop everything to floor. Maybe
  * it should drop only what he has in hands? Stunned actor can wake later during mission.
  */
i have the habit to remove all the weapons  who are lying on the floor, i don't want a alien to wake up and takes arms.

[Mattn]

killing a stunned alien should work....