Encumbrance/TU penalty

[Kildor]

cheater, cheater!!

[Thrashard96]

good one, have you read my signature below?

[DarkRain]

Do you think you can provide a little patch that makes auto placing call onChange ?

Well, Itried a little to work that out but it didn't work quite as expected, so I ended calling the update function right there, at least for now
Still that might be something worth checking as I'm not sure it was *only* an error on my side, as it seemed to work for all container nodes besides the backpack (where it crashed the game), will look at it later -- I'm in my other PC right now

Do you think you found all the events ?

Not yet, I'm aware of at least a couple situations that will throw things out of sync...

@keybounce:
DarkRain's implementation will apply the penalties in the most gradual way possible. So it's not like overloaded ? TUs -= 20%.

That's right I'm using an exponential function to calculate the penalty so it will progress slowly -- at the begining -- but if you seriously overload your soldiers they might end crushed under the weight of their equipment (but I'm talking of something like the double or more than they should carry)

[DarkRain]

Do you think you can provide a little patch that makes auto placing call onChange ?

Maybe something like the attached patch could do the trick -- not very elegant tough.

[bayo]

Hi, i dont read the problematic, and i dont have the full code here, anyway.

Some comments:

* please move assignation like "target = csi.idHolster" outside of param. (cause i dislike interleave like that (to me, it is hard to read, i prefer more lines, its the same for assignation inside if...).

* move UI_GetContainerNodeByContainerID to ui_node_container.c and .h

* first UI_GetContainerNodeByContainerID param should be a parent node (or a window node). UI_GetContainerNodeByContainerID (const uiNode_t* const parent... then u can use it like that UI_GetNode(parent, "holster"), and like that UI_GetContainerNodeByContainerID(node->parent, ...). We assume all containers have the same parent, it can be a panel (not only a window). Anyway it can be a deeper search, cause we dont call a lot this function.

* use a switch instead of the "if"s for UI_GetContainerNodeByContainerID. Better, check UI_ContainerNodeLoaded, we should use something like INVSH_GetInventoryDefinitionByID (namebyid, this name is hard coded somewhere (or in a script), we should not hardcode it another time). Also, "equip" is a little special (see UI_ContainerNodeLoaded), but battlescape only only use "equip" without sufix ATM. See the last note.

* Just a note, baseinventory is only used outside battlescape. And ATM only "equip_" is used outside the battlescape.

Anyway, sorry, the container code is very very bad ATM, and hard to clean.

[DarkRain]

Here's a new update on the onChange subject (wich I'm plannig to use for the encumbrance/TU penalty), this is a bit better than before

Anyway, sorry, the container code is very very bad ATM, and hard to clean.

Well when I said

not very elegant tough.

it was an understatment

edit: forgot to attach diff and changed subject

[bayo]

ammoNode = UI_GetNode(node->root, "equip_ammo")
i think ammoNode can be null. In this case it will crash. We also should protect null targetNode.

I can apply this current patch, and rework it a little. I dislike the way it work with "equip_ammo", anyway its greater than the previous code. Thanks a lot anyway, it's a good improvment for behaviour consistency.

One more time, i only talk about the node container code. Cause, the onChange event and everything from the UI script should not manage rules like that. That's the job of the inventory code (and all the crappy thing around, which anyway need, IMO, a deep refactoring).

[bayo]

How should i credit you? any name and mail?

[DarkRain]

spamtome [dot] 10 [at] gmail [dot] com


not really needed to credit me you know

[bayo]

I apply it to the master. Thanks again for your contribution.

[Duke]

I apply it to the master. Thanks again for your contribution.

Yeah thx, but I suppose that's just the *beginning* of DarkRain's contributions

@DarkRain:
Did you already manage to jump on the GIT train ?

[DarkRain]

@DarkRain:
Did you already manage to jump on the GIT train ?

Yes I did -- it took me the whole day but I managed it
(my internet conection has been limited to 512kbps since it failed -- more than two weeks ago now -- and the company just said 'We will investigate the case, if you dont receive an answer in one month please call again' when the report about the conection speed was filed)

[DarkRain]

It's been a while, I had some tech problems and then my internet connection died again. . .

Just so nobody thinks I just forgot about this I will attach here the output of 'git diff master encumbrance_work' in my local repo clone, it might take a while before I can get back to it tough. . .

Thing here untested as that was the next step before continuing with this