Testing request: 2.1.1 testinstaller.

[Zenerka]

We have prepared new testinstaller for UFO:AI 2.1.1 version, which is mainly focused on bugfixing. No new features. It can be downloaded from:
http://mattn.ninex.info/download/ufoai-2.1.1-win32.exe (windows version) [20.04.2007 - deprecated]
http://mattn.ninex.info/download/ufoai-2.1.1-linux.run (linux version) [20.04.2007 - deprecated]
Heavy testing is requested. This testinstaller contains new, rewritten from the scratch savegame subsystem with savegame serializer. Please test it as much as possible and report bugs here. Please don't report bugs mentioned in BUGS file.
After saving the game try to load it immediately before quitting the game. If it fails, post here the info from ufoconsole (from both saving and loading the game), which contains number of bytes saved and loaded for particular save subsystem.
Note that "old" saved games (from 2.1.0 release) won't be able to load here.
Please, help making 2.1.1 as bugfree as possible.

EDIT: Known bugs already fixed but not included in testinstaller:
1) saving the game when dropship is on the air and returns from the mission to the base will not allow to load the game - a workaround is to save when dropship will return to base
2) using more than two ships with teams assigned will produce either crash on loading or crash when trying to enter the base - a workaround is to use only one ship with assigned team (we are not sure if this bug will be hit in case of just simply more than one base - using only one base is recommended with current testinstaller)
EDIT2: new testinstaller fixes these two (and some more) bugs. You can download it from:
http://szklo.eu.org/~mattn/ufoai-2.1.1-win32.exe for windows [22.04.2007]
http://ufoai.neowifi.pl/ufoai-2.1.1-linux.run for linux [22.04.2007]
For those, who have previous testinstaller, we prepared updated binaries and scripts. One can download them from:
http://mattn.ninex.info/download/new/
Needed files are:
- 0ufos.pk3 to base/ directory
- ufo.exe for windows
- ufo for linux
EDIT3: new testinstaller, fixing some smaller bugs and one serious bug in savegame system (that means you cannot load savegames from previous versions). One can download them from:
- http://szklo.eu.org/~mattn/ufoai-2.1.1-win32.exe for windows [24.04.2007]
- http://szklo.eu.org/~mattn/ufoai-2.1.1-linux.run for linux [24.04.2007]
If nothing bad happens, this is supposed to be the "final" betainstaller.
EDIT4: new testinstaller, fixing two serious bugs related to saving and inventory (that maens you cannot load savegames from previous versions). One can download them from:
- http://szklo.eu.org/~mattn/ufoai-2.1.1-win32.exe for windows [26.04.2007]
- http://szklo.eu.org/~mattn/ufoai-2.1.1-linux.run for linux [26.04.2007]
If nothing bad happens, this is supposed to be "final" betainstaller.
EDIT5: new testinstaller, mainly improving some features (or includiing minor fixes). One can download them from:
- http://szklo.eu.org/~mattn/ufoai-2.1.1-win32.exe for windows [29.04.2007]
- http://szklo.eu.org/~mattn/ufoai-2.1.1-linux.run for linux [29.04.2007]
If nothing bad happens, this is supposed to be "final" betainstaller.
edit by mattn
please also send you system data: 64bit, 32bit, big endian, little endian and so on

[Mattn]

the linux version included 64bit binaries bulit on ubuntu feisty

there is even a md5 for the windows installer:
http://mattn.ninex.info/download/ufoai-2.1.1-win32.md5

[smalul]

Great work with the new update. No problem yet with loading and saving.

I wanted to ask - should I report other bugs here as well (not just about the load/save system), or should I keep submiting them to the bug tracker on SourceForge, under version 2.1 (no option for version 2.1.1 under group). I'm asking because I have a bug showing 4 soldiers "Currently healing" while only 3 are listed in the hospital, and I'm not sure where to report such a bug?

[IAX]

2.1.1. fixed my ufopaedia texts, but other issuer remain (crash on exit) and savegame doesn't work. Console dump:

Code: [Select]


CL_UpdateHireVar()... aircraft idx: 0, homebase: PHALANX Hima
Save 'slot1'
...subsystem 'base' - saved 11447 bytes
...subsystem 'campaign' - saved 212 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6199 bytes
...subsystem 'employee' - saved 4809 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 48 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 1605 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign 'haa' saved.
Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size 50423576 bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot0'
...subsystem 'base' - loaded 11397 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Cmd_AddCommand: popup_aircraft_action_click already defined
Cmd_AddCommand: ships_click already defined
Cmd_AddCommand: ships_rclick already defined
Cmd_AddCommand: multi_select_click already defined
Activate stage intro
...subsystem 'campaign' - loaded 252 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6199 bytes
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
...subsystem 'employee' - loaded 5530 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 48 bytes
...subsystem 'aircraft' - loaded 1 bytes
...subsystem 'messagesystem' - loaded 1268 bytes
...subsystem 'stats' - loaded 28 bytes
...subsystem 'nations' - loaded 32 bytes
File 'slot0' loaded.
Changing to Singleplayer
Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size 50423576 bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot1'
...subsystem 'base' - loaded 39963 bytes
...subsystem 'base' could not be loaded correctly - savegame might be broken (ffffffff)
Unknown command "game_timestop"
Changing to Singleplayer
Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size 50423576 bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8



So I have two savegames, slot0 saved before mission, slot1 after. After saving slot1, I loaded slot0 with success. Loading slot1 again failed.

IAX

[IAX]

Sorry, a correction: the game no longer segfaults on exit; still fails to restore X resolution with the following:

Code: [Select]


Save user settings to /home/oem/.ufoai/2.1.1/base/config.cfg
SDL audio device shut down.
X Error of failed request: BadValue (integer parameter out of range for operation)
  Major opcode of failed request: 135li
  Minor opcode of failed request: 10
  Serial number of failed request: 67613i
recursive shutdown

IAX

[blondandy]

playing on win xp sp2 using supplied 2.1.1 installer. got  a broken savegame after first mission. snip from log on saving.

Team 0 ended round, team 1's round started!
Team 1 ended round, team 7's round started!
InvAdd: message ignored... LE 16 not found (type: 0)
InvAdd: ignoring:
Item: plaspistol_ammo
... name          -> Plasma Pistol Charger
... type          -> ammo
... category      -> 48
... weapon        -> 0
... holdtwohanded -> 0
... firetwohanded -> 0
... twohanded     -> 0
... thrown        -> 0
... usable for weapon (if type is ammo):
    ... Plasma Pistol

InvAdd: ignoring:
Item: plaspistol
... name          -> Plasma Pistol
... type          -> pistol
... category      -> 50
... weapon        -> 1
... holdtwohanded -> 0
... firetwohanded -> 1
... twohanded     -> 0
... thrown        -> 0
... usable for weapon (if type is ammo):

InvAdd: message ignored... LE 21 not found (type: 0)
InvAdd: ignoring:
Item: plaspistol_ammo
... name          -> Plasma Pistol Charger
... type          -> ammo
... category      -> 48
... weapon        -> 0
... holdtwohanded -> 0
... firetwohanded -> 0
... twohanded     -> 0
... thrown        -> 0
... usable for weapon (if type is ammo):
    ... Plasma Pistol

InvAdd: ignoring:
Item: plaspistol
... name          -> Plasma Pistol
... type          -> pistol
... category      -> 50
... weapon        -> 1
... holdtwohanded -> 0
... firetwohanded -> 1
... twohanded     -> 0
... thrown        -> 0
... usable for weapon (if type is ammo):

Team 7 ended round, team 0's round started!
==== ShutdownGame ====
CL_UpdateHireVar()... aircraft idx: 0, homebase: PHALANX HQ
Save 'slot2'
...subsystem 'base' - saved 5961 bytes
...subsystem 'campaign' - saved 212 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6331 bytes
...subsystem 'employee' - saved 8663 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 9 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 918 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign '2' saved.
Save user settings to C:\Documents and Settings\HP_Owner\Application Data\UFOAI/2.1.1/base/config.cfg
Shutting down win api sound system

snip from log on loading. (I got a nice dialog telling me to look at the log).

...precaching 67 menus
====== UFO Initialized ======

Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size (null)u bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot2'
...subsystem 'base' - loaded 34801 bytes
...subsystem 'base' could not be loaded correctly - savegame might be broken (ffffffff)
Unknown command "game_timestop"
Changing to Singleplayer
Save user settings to C:\Documents and Settings\HP_Owner\Application Data\UFOAI/2.1.1/base/config.cfg
Shutting down win api sound system

Thanks for your hard work.

[Zenerka]

Thanks for your reports - that bug was unknown for us.
Additional question - did you both saved while your dropship returning from the mission was still in air? (did not returned to the base yet)
if yes, the temporary workaround (untill we fix that bug) is to wait till aircraft return to the base, and save after that.

[blondandy]

my dropship was in the air for that broken save.

i got another broken savegame, but i don't have the log for when i saved it. i will start from the last good save and see how things go.

[Mattn]

IAX: you saved to slot0 and loaded slot1 (or vice versa) - please make sure that you save and load the same slot - we need the size values from the log files - and they may differ from slot to slot.

[Mattn]

i'm sorry IAX: i just didn't see the second slot loaded, too

[smalul]

OK, I too got a problem with the loading system. Here is the log:

Save 'slot7'
...subsystem 'base' - saved 5815 bytes
...subsystem 'campaign' - saved 266 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6331 bytes
...subsystem 'employee' - saved 24360 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 22 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 18432 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign 'Shai40' saved.
Save 'slot0'
...subsystem 'base' - saved 5959 bytes
...subsystem 'campaign' - saved 266 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6331 bytes
...subsystem 'employee' - saved 24360 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 22 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 18432 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign 'Shai41' saved.
Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size (null)u bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot0'
...subsystem 'base' - loaded 5959 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Cmd_AddCommand: popup_aircraft_action_click already defined
Cmd_AddCommand: ships_click already defined
Cmd_AddCommand: ships_rclick already defined
Cmd_AddCommand: multi_select_click already defined
Activate stage intro
...subsystem 'campaign' - loaded 266 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6331 bytes
...subsystem 'employee' - loaded 24360 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 22 bytes
...subsystem 'aircraft' - loaded 1 bytes
...subsystem 'messagesystem' - loaded 18465 bytes
...subsystem 'messagesystem' could not be loaded correctly - savegame might be broken (3f)
Changing to Singleplayer
Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size (null)u bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot7'
...subsystem 'base' - loaded 5815 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Cmd_AddCommand: popup_aircraft_action_click already defined
Cmd_AddCommand: ships_click already defined
Cmd_AddCommand: ships_rclick already defined
Cmd_AddCommand: multi_select_click already defined
Activate stage intro
...subsystem 'campaign' - loaded 266 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6331 bytes
...subsystem 'employee' - loaded 24360 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 22 bytes
...subsystem 'aircraft' - loaded 1 bytes
...subsystem 'messagesystem' - loaded 18465 bytes
...subsystem 'messagesystem' could not be loaded correctly - savegame might be broken (3f)
Changing to Singleplayer
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot6'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot5'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot4'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot3'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot2'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot1'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot0'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot7'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot6'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot5'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot0'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot0'.

OK, I've tried all the saved games, and at some point I've started getting that "Error decompressing data" message from all slots.
Once again my game is lost...

[Zenerka]

IAX, blondandy, the problem you hit is solved. It was a bug in the code about saving alien cargo and item cargo - when i wrote the code i had used wrong loop counters.

smalul, bugs not related to saving should be reported on sourceforge tracker if they are not mentioned there yet as well as reported here - that's because if the bug will be release-stopper, we will try to fix it ASAP, while if the bug won't block release, we can postpone it for next days.
About the savegame bug with message subsystem, we will look into this, thanks for the report.

[blondandy]

i've got a new one. win xp sp2. did the first mission, waited til the dropship was home. saved...

                                   
images
Starting the game...
(player 0) It's team 1's round
Team 1 ended round, team 7's round started!
Team 7 ended round, team 0's round started!
Team 0 ended round, team 1's round started!
Team 1 ended round, team 7's round started!
Team 7 ended round, team 0's round started!
Team 0 ended round, team 1's round started!
==== ShutdownGame ====
CL_UpdateHireVar()... aircraft idx: 0, homebase: PHALANX HQ
Save 'slot1'
...subsystem 'base' - saved 5927 bytes
...subsystem 'campaign' - saved 212 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6331 bytes
...subsystem 'employee' - saved 8663 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 9 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 1106 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign '' saved.
Save user settings to C:\Documents and Settings\HP_Owner\Application Data\UFOAI/2.1.1/base/config.cfg
Shutting down win api sound system

then loaded. i got chucked back to the desktop with the standard annoying bill gates p-ping noise. no error dialog. here's the log excerpt

Shared Client/Server Info loaded
...precaching 67 menus
====== UFO Initialized ======

Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size (null)u bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot1'
...subsystem 'base' - loaded 5927 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Activate stage intro
...subsystem 'campaign' - loaded 212 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6331 bytes
...subsystem 'employee' - loaded 8663 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 9 bytes
...subsystem 'aircraft' - loaded 1 bytes
...subsystem 'messagesystem' - loaded 1106 bytes
...subsystem 'stats' - loaded 28 bytes
...subsystem 'nations' - loaded 32 bytes
File 'slot1' loaded.
Changing to Singleplayer
Save user settings to C:\Documents and Settings\HP_Owner\Application Data\UFOAI/2.1.1/base/config.cfg
Shutting down win api sound system

let me know if slot1.sav would be useful to you.

[smalul]

smalul, bugs not related to saving should be reported on sourceforge tracker if they are not mentioned there yet as well as reported here - that's because if the bug will be release-stopper, we will try to fix it ASAP, while if the bug won't block release, we can postpone it for next days.

OK, thanks. I've sent a few bugs to the tracker already.

About the savegame bug with message subsystem, we will look into this, thanks for the report.

OK, more on this bug - first of all, it now seems 2 of the 8 save files are working, so not all is lost. Second, it seems like there are 2 stages to this bug:
1. The first part is the "Error loading game. Error in loading a subsystem - see console for more information", which appears only when I try to load a broken save file. Good save files are working fine.
Here is a picture of the bug:

2. The second part is the "Error loading game. Error decompressing data". This part happens after you try to loading broken save files a few times in stage one ("Error in loading a subsystem"), and then you start getting this "decompressing data" error. In this stage, you can't load ANY of the save files, including the working ones, and all gives the same "decompressing data" error message.
Here is a picture of this stage:

I hope this would help you locate and fix this bug.

By the way, do you need my saved files for analysis?

[Zenerka]

Thanks to your reports as well as reports from people joining our ircchannel, i found and fixed another bug in saving. It occurs in case you have more than one base and/or more than one ship with team assignment.
The workaround for this is to use only one ship with team assigned to it.