UFO:Alien Invasion

Archive => Bugs prior to release 2.4 => Topic started by: ptbptb on September 20, 2011, 03:46:40 pm

Title: Alien Materials from Harvester disassembling
Post by: ptbptb on September 20, 2011, 03:46:40 pm

Disassembling an intact Harvester will produce 1600 Alien Materials. The product screen statistics state that 800 should be produced.

Title: Re: Alien Materials from Harvester disassembling
Post by: Mattn on September 20, 2011, 04:15:35 pm

Bug Ticket (https://sourceforge.net/tracker/?func=detail&aid=3411869&group_id=157793&atid=805242)

Title: Re: Alien Materials from Harvester disassembling
Post by: geever on September 22, 2011, 10:56:50 pm

Quote from: ptbptb on September 20, 2011, 03:46:40 pm

Disassembling an intact Harvester will produce 1600 Alien Materials. The product screen statistics state that 800 should be produced.

Please attach a savegame.

-geever

Title: Re: Alien Materials from Harvester disassembling
Post by: ptbptb on September 23, 2011, 02:14:01 pm

One hour till production finished at AtS. Zero Alien Materials before, 1600 after.

Title: Re: Alien Materials from Harvester disassembling
Post by: Mattn on September 23, 2011, 03:59:36 pm

attached it to the ticket, too

Title: Re: Alien Materials from Harvester disassembling
Post by: AndyZCS on September 28, 2011, 01:30:43 am

Approximate solution:

CAP_AddCurrent(base, CAP_ITEMS, PR_DisassembleItem(base, ufo->comp, ufo->condition, qfalse)); causes PR_DisassembleItem to be called twice in the inline function 'max'
This is where the inventory is added X 2
Calling PR_DisassembleItem seperately & saving size return value before calling CAP_AddCurrent(base, CAP_ITEMS, sizeret ) makes the invventory correct.

However the base stock level still adds 2 X the inventory.
Total stock is updated as PR_DisassembleItem adds each individual item to the seperate stock items so changing to
CAP_AddCurrent(base, CAP_ITEMS, 0  ) gives correct values.
This line should then do nothing (increases stock level by 0) so should be possible to delete.

Regards

  Andy

Title: Re: Alien Materials from Harvester disassembling
Post by: Mattn on September 28, 2011, 08:13:38 am

this patch should fix it - or at least the part where PR_DisassembleItem is called twice (other locations were broken, too)

Title: Re: Alien Materials from Harvester disassembling
Post by: geever on September 28, 2011, 12:48:43 pm

Quote from: Mattn on September 28, 2011, 08:13:38 am

this patch should fix it - or at least the part where PR_DisassembleItem is called twice (other locations were broken, too)

Your patch misses Doxygen documentations at first...

-geever