UFO:Alien Invasion

Technical support => Feature Requests => Topic started by: baba on August 21, 2007, 09:56:46 pm

Title: killed aliens doesn't count
Post by: baba on August 21, 2007, 09:56:46 pm

Hello,

when i kill an alien in the base, the counter for living aliens for this bases doesn't change.

Rev. 11027


[attachment deleted by admin]

Title: Re: killed aliens doesn't count
Post by: Punkiee on August 28, 2007, 09:19:04 pm

cant reproduce with rev11206. Both counters are set to zero upon killing all aliens.

There is bug that doesnt restore the aliens correctly upon loading a game though. The aliens do no longer appear in the list. counter for all alive alliens is zero while alive aliens counter for this base only is two.  ???

Code: [Select]

...subsystem 'size' - loaded 93 bytes
AL_FillInContainment()... type: Taman techIdx: 122
AL_FillInContainment()... type: Ortnok techIdx: 121
AL_FillInContainment()... type: Shevaar techIdx: 123
AL_FillInContainment()... type: Bloodspider techIdx: 119
B_Load: Could not find teamDesc '' - skipping the aliencont
B_Load: Could not find teamDesc '' - skipping the aliencont
B_Load: Could not find teamDesc '' - skipping the aliencont
B_Load: Could not find teamDesc '' - skipping the aliencont
...subsystem 'base' - loaded 10042 bytes

The saved string for the alientype is apparently empty.
With some extra output, you can see that there are 4 entrys saved but they contain nothing. even the counters for alive and dead are not correct.

Code: [Select]

B_Save: Alien Containment save '' alive 0 dead 0
B_Save: Alien Containment save '' alive 0 dead 0
B_Save: Alien Containment save '' alive 0 dead 0
B_Save: Alien Containment save '' alive 0 dead 0


Title: Re: killed aliens doesn't count
Post by: Zenerka on August 28, 2007, 09:51:05 pm

Nice catch (about problem with Alien Containment loading). That is most probably sideeffect of recent changes with team parsing. I will see what I can do to fix, thanks.

Title: Re: killed aliens doesn't count
Post by: Zenerka on September 04, 2007, 11:03:24 am

Punkiee, you can still reproduce this with current trunk?

Title: Re: killed aliens doesn't count
Post by: Punkiee on September 09, 2007, 04:15:44 pm

yup, still the same with revision
Last Changed Rev: 11620
Last Changed Date: 2007-09-09 14:46:15 +0200 (Sun, 09 Sep 2007)

no alien get saved.

submitted a patch 
1791064       add an alien to the containment
this adds a function for adding an alien to your containment facility. way easier :)
It doesnt fix the save bug though

Title: Re: killed aliens doesn't count
Post by: Punkiee on September 09, 2007, 07:10:04 pm

There was something wrong with killing all aliens in a base. It does work only when not selecting an alientype or when selecting the first (Taman). Other types didnt work.

Submitted a patch
1791131       kill all aliens in base doesnt work for all alien types

Title: Re: killed aliens doesn't count
Post by: Punkiee on September 09, 2007, 09:22:36 pm

patch 1791192 submitted https://sourceforge.net/tracker/index.php?func=detail&aid=1791192&group_id=157793&atid=805244 (https://sourceforge.net/tracker/index.php?func=detail&aid=1791192&group_id=157793&atid=805244)

This should fix the save problem.

Title: Re: killed aliens doesn't count
Post by: Punkiee on September 09, 2007, 09:54:13 pm

And now that all else is solved, i managed to reproduce baba's original problem :) the counter for living aliens in the base isnt updated.

A patch is ready at https://sourceforge.net/tracker/index.php?func=detail&aid=1791206&group_id=157793&atid=805244 (https://sourceforge.net/tracker/index.php?func=detail&aid=1791206&group_id=157793&atid=805244)

Please note that this was discovered and tested along with all other patches i submitted on the containment facility, 3 other patches if i recall correct. Since they all have to do with the same functionality, you have to take them all before you can test this patch.