UFO:Alien Invasion

Technical support => Feature Requests => Topic started by: Zenerka on April 20, 2007, 03:24:20 pm

Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 20, 2007, 03:24:20 pm
We have prepared new testinstaller for UFO:AI 2.1.1 version, which is mainly focused on bugfixing. No new features. It can be downloaded from:
http://mattn.ninex.info/download/ufoai-2.1.1-win32.exe (windows version) [20.04.2007 - deprecated]
http://mattn.ninex.info/download/ufoai-2.1.1-linux.run (linux version) [20.04.2007 - deprecated]
Heavy testing is requested. This testinstaller contains new, rewritten from the scratch savegame subsystem with savegame serializer. Please test it as much as possible and report bugs here. Please don't report bugs mentioned in BUGS file.
After saving the game try to load it immediately before quitting the game. If it fails, post here the info from ufoconsole (from both saving and loading the game), which contains number of bytes saved and loaded for particular save subsystem.
Note that "old" saved games (from 2.1.0 release) won't be able to load here.
Please, help making 2.1.1 as bugfree as possible.

EDIT: Known bugs already fixed but not included in testinstaller:
1) saving the game when dropship is on the air and returns from the mission to the base will not allow to load the game - a workaround is to save when dropship will return to base
2) using more than two ships with teams assigned will produce either crash on loading or crash when trying to enter the base - a workaround is to use only one ship with assigned team (we are not sure if this bug will be hit in case of just simply more than one base - using only one base is recommended with current testinstaller)
EDIT2: new testinstaller fixes these two (and some more) bugs. You can download it from:
http://szklo.eu.org/~mattn/ufoai-2.1.1-win32.exe for windows [22.04.2007]
http://ufoai.neowifi.pl/ufoai-2.1.1-linux.run for linux [22.04.2007]
For those, who have previous testinstaller, we prepared updated binaries and scripts. One can download them from:
http://mattn.ninex.info/download/new/
Needed files are:
- 0ufos.pk3 to base/ directory
- ufo.exe for windows
- ufo for linux
EDIT3: new testinstaller, fixing some smaller bugs and one serious bug in savegame system (that means you cannot load savegames from previous versions). One can download them from:
- http://szklo.eu.org/~mattn/ufoai-2.1.1-win32.exe for windows [24.04.2007]
- http://szklo.eu.org/~mattn/ufoai-2.1.1-linux.run for linux [24.04.2007]
If nothing bad happens, this is supposed to be the "final" betainstaller.
EDIT4: new testinstaller, fixing two serious bugs related to saving and inventory (that maens you cannot load savegames from previous versions). One can download them from:
- http://szklo.eu.org/~mattn/ufoai-2.1.1-win32.exe for windows [26.04.2007]
- http://szklo.eu.org/~mattn/ufoai-2.1.1-linux.run for linux [26.04.2007]
If nothing bad happens, this is supposed to be "final" betainstaller.
EDIT5: new testinstaller, mainly improving some features (or includiing minor fixes). One can download them from:
- http://szklo.eu.org/~mattn/ufoai-2.1.1-win32.exe for windows [29.04.2007]
- http://szklo.eu.org/~mattn/ufoai-2.1.1-linux.run for linux [29.04.2007]
If nothing bad happens, this is supposed to be "final" betainstaller.
edit by mattn
please also send you system data: 64bit, 32bit, big endian, little endian and so on
Title: Testing request: 2.1.1 testinstaller.
Post by: Mattn on April 20, 2007, 04:03:09 pm
the linux version included 64bit binaries bulit on ubuntu feisty

there is even a md5 for the windows installer:
http://mattn.ninex.info/download/ufoai-2.1.1-win32.md5
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 21, 2007, 09:20:51 am
Great work with the new update. No problem yet with loading and saving.

I wanted to ask - should I report other bugs here as well (not just about the load/save system), or should I keep submiting them to the bug tracker on SourceForge, under version 2.1 (no option for version 2.1.1 under group). I'm asking because I have a bug showing 4 soldiers "Currently healing" while only 3 are listed in the hospital, and I'm not sure where to report such a bug?
Title: Testing request: 2.1.1 testinstaller.
Post by: IAX on April 21, 2007, 11:09:22 am
2.1.1. fixed my ufopaedia texts, but other issuer remain (crash on exit) and savegame doesn't work. Console dump:
Code: [Select]

CL_UpdateHireVar()... aircraft idx: 0, homebase: PHALANX Hima
Save 'slot1'
...subsystem 'base' - saved 11447 bytes
...subsystem 'campaign' - saved 212 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6199 bytes
...subsystem 'employee' - saved 4809 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 48 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 1605 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign 'haa' saved.
Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size 50423576 bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot0'
...subsystem 'base' - loaded 11397 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Cmd_AddCommand: popup_aircraft_action_click already defined
Cmd_AddCommand: ships_click already defined
Cmd_AddCommand: ships_rclick already defined
Cmd_AddCommand: multi_select_click already defined
Activate stage intro
...subsystem 'campaign' - loaded 252 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6199 bytes
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
Com_GetItemByID: Item "" not found.
...subsystem 'employee' - loaded 5530 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 48 bytes
...subsystem 'aircraft' - loaded 1 bytes
...subsystem 'messagesystem' - loaded 1268 bytes
...subsystem 'stats' - loaded 28 bytes
...subsystem 'nations' - loaded 32 bytes
File 'slot0' loaded.
Changing to Singleplayer
Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size 50423576 bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot1'
...subsystem 'base' - loaded 39963 bytes
...subsystem 'base' could not be loaded correctly - savegame might be broken (ffffffff)
Unknown command "game_timestop"
Changing to Singleplayer
Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size 50423576 bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8



So I have two savegames, slot0 saved before mission, slot1 after. After saving slot1, I loaded slot0 with success. Loading slot1 again failed.

IAX
Title: Testing request: 2.1.1 testinstaller.
Post by: IAX on April 21, 2007, 12:03:06 pm
Sorry, a correction: the game no longer segfaults on exit; still fails to restore X resolution with the following:
Code: [Select]

Save user settings to /home/oem/.ufoai/2.1.1/base/config.cfg
SDL audio device shut down.
X Error of failed request: BadValue (integer parameter out of range for operation)
  Major opcode of failed request: 135li
  Minor opcode of failed request: 10
  Serial number of failed request: 67613i
recursive shutdown

IAX
Title: Testing request: 2.1.1 testinstaller.
Post by: blondandy on April 21, 2007, 01:21:19 pm
playing on win xp sp2 using supplied 2.1.1 installer. got  a broken savegame after first mission. snip from log on saving.

Quote
Team 0 ended round, team 1's round started!
Team 1 ended round, team 7's round started!
InvAdd: message ignored... LE 16 not found (type: 0)
InvAdd: ignoring:
Item: plaspistol_ammo
... name          -> Plasma Pistol Charger
... type          -> ammo
... category      -> 48
... weapon        -> 0
... holdtwohanded -> 0
... firetwohanded -> 0
... twohanded     -> 0
... thrown        -> 0
... usable for weapon (if type is ammo):
    ... Plasma Pistol

InvAdd: ignoring:
Item: plaspistol
... name          -> Plasma Pistol
... type          -> pistol
... category      -> 50
... weapon        -> 1
... holdtwohanded -> 0
... firetwohanded -> 1
... twohanded     -> 0
... thrown        -> 0
... usable for weapon (if type is ammo):

InvAdd: message ignored... LE 21 not found (type: 0)
InvAdd: ignoring:
Item: plaspistol_ammo
... name          -> Plasma Pistol Charger
... type          -> ammo
... category      -> 48
... weapon        -> 0
... holdtwohanded -> 0
... firetwohanded -> 0
... twohanded     -> 0
... thrown        -> 0
... usable for weapon (if type is ammo):
    ... Plasma Pistol

InvAdd: ignoring:
Item: plaspistol
... name          -> Plasma Pistol
... type          -> pistol
... category      -> 50
... weapon        -> 1
... holdtwohanded -> 0
... firetwohanded -> 1
... twohanded     -> 0
... thrown        -> 0
... usable for weapon (if type is ammo):

Team 7 ended round, team 0's round started!
==== ShutdownGame ====
CL_UpdateHireVar()... aircraft idx: 0, homebase: PHALANX HQ
Save 'slot2'
...subsystem 'base' - saved 5961 bytes
...subsystem 'campaign' - saved 212 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6331 bytes
...subsystem 'employee' - saved 8663 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 9 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 918 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign '2' saved.
Save user settings to C:\Documents and Settings\HP_Owner\Application Data\UFOAI/2.1.1/base/config.cfg
Shutting down win api sound system


snip from log on loading. (I got a nice dialog telling me to look at the log).

Quote
...precaching 67 menus
====== UFO Initialized ======

Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size (null)u bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot2'
...subsystem 'base' - loaded 34801 bytes
...subsystem 'base' could not be loaded correctly - savegame might be broken (ffffffff)
Unknown command "game_timestop"
Changing to Singleplayer
Save user settings to C:\Documents and Settings\HP_Owner\Application Data\UFOAI/2.1.1/base/config.cfg
Shutting down win api sound system


Thanks for your hard work.
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 21, 2007, 01:29:47 pm
Thanks for your reports - that bug was unknown for us.
Additional question - did you both saved while your dropship returning from the mission was still in air? (did not returned to the base yet)
if yes, the temporary workaround (untill we fix that bug) is to wait till aircraft return to the base, and save after that.
Title: Testing request: 2.1.1 testinstaller.
Post by: blondandy on April 21, 2007, 01:59:23 pm
my dropship was in the air for that broken save.

i got another broken savegame, but i don't have the log for when i saved it. i will start from the last good save and see how things go.
Title: Testing request: 2.1.1 testinstaller.
Post by: Mattn on April 21, 2007, 02:15:09 pm
IAX: you saved to slot0 and loaded slot1 (or vice versa) - please make sure that you save and load the same slot - we need the size values from the log files - and they may differ from slot to slot.
Title: Testing request: 2.1.1 testinstaller.
Post by: Mattn on April 21, 2007, 02:18:37 pm
i'm sorry IAX: i just didn't see the second slot loaded, too
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 21, 2007, 02:34:27 pm
OK, I too got a problem with the loading system. Here is the log:

Quote
Save 'slot7'
...subsystem 'base' - saved 5815 bytes
...subsystem 'campaign' - saved 266 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6331 bytes
...subsystem 'employee' - saved 24360 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 22 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 18432 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign 'Shai40' saved.
Save 'slot0'
...subsystem 'base' - saved 5959 bytes
...subsystem 'campaign' - saved 266 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6331 bytes
...subsystem 'employee' - saved 24360 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 22 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 18432 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign 'Shai41' saved.
Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size (null)u bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot0'
...subsystem 'base' - loaded 5959 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Cmd_AddCommand: popup_aircraft_action_click already defined
Cmd_AddCommand: ships_click already defined
Cmd_AddCommand: ships_rclick already defined
Cmd_AddCommand: multi_select_click already defined
Activate stage intro
...subsystem 'campaign' - loaded 266 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6331 bytes
...subsystem 'employee' - loaded 24360 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 22 bytes
...subsystem 'aircraft' - loaded 1 bytes
...subsystem 'messagesystem' - loaded 18465 bytes
...subsystem 'messagesystem' could not be loaded correctly - savegame might be broken (3f)
Changing to Singleplayer
Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size (null)u bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot7'
...subsystem 'base' - loaded 5815 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Cmd_AddCommand: popup_aircraft_action_click already defined
Cmd_AddCommand: ships_click already defined
Cmd_AddCommand: ships_rclick already defined
Cmd_AddCommand: multi_select_click already defined
Activate stage intro
...subsystem 'campaign' - loaded 266 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6331 bytes
...subsystem 'employee' - loaded 24360 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 22 bytes
...subsystem 'aircraft' - loaded 1 bytes
...subsystem 'messagesystem' - loaded 18465 bytes
...subsystem 'messagesystem' could not be loaded correctly - savegame might be broken (3f)
Changing to Singleplayer
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot6'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot5'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot4'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot3'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot2'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot1'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot0'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot7'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot6'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot5'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot0'.
Loading savegame
...version: 1
...game version: 2.1.1
Error decompressing data in 'slot0'
.

OK, I've tried all the saved games, and at some point I've started getting that "Error decompressing data" message from all slots.
Once again my game is lost...
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 21, 2007, 02:51:10 pm
IAX, blondandy, the problem you hit is solved. It was a bug in the code about saving alien cargo and item cargo - when i wrote the code i had used wrong loop counters.

smalul, bugs not related to saving should be reported on sourceforge tracker if they are not mentioned there yet as well as reported here - that's because if the bug will be release-stopper, we will try to fix it ASAP, while if the bug won't block release, we can postpone it for next days.
About the savegame bug with message subsystem, we will look into this, thanks for the report.
Title: Testing request: 2.1.1 testinstaller.
Post by: blondandy on April 21, 2007, 03:23:03 pm
i've got a new one. win xp sp2. did the first mission, waited til the dropship was home. saved...

Quote
                                   
images
Starting the game...
(player 0) It's team 1's round
Team 1 ended round, team 7's round started!
Team 7 ended round, team 0's round started!
Team 0 ended round, team 1's round started!
Team 1 ended round, team 7's round started!
Team 7 ended round, team 0's round started!
Team 0 ended round, team 1's round started!
==== ShutdownGame ====
CL_UpdateHireVar()... aircraft idx: 0, homebase: PHALANX HQ
Save 'slot1'
...subsystem 'base' - saved 5927 bytes
...subsystem 'campaign' - saved 212 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6331 bytes
...subsystem 'employee' - saved 8663 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 9 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 1106 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign '' saved.
Save user settings to C:\Documents and Settings\HP_Owner\Application Data\UFOAI/2.1.1/base/config.cfg
Shutting down win api sound system


then loaded. i got chucked back to the desktop with the standard annoying bill gates p-ping noise. no error dialog. here's the log excerpt

Quote
Shared Client/Server Info loaded
...precaching 67 menus
====== UFO Initialized ======

Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size (null)u bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot1'
...subsystem 'base' - loaded 5927 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Activate stage intro
...subsystem 'campaign' - loaded 212 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6331 bytes
...subsystem 'employee' - loaded 8663 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 9 bytes
...subsystem 'aircraft' - loaded 1 bytes
...subsystem 'messagesystem' - loaded 1106 bytes
...subsystem 'stats' - loaded 28 bytes
...subsystem 'nations' - loaded 32 bytes
File 'slot1' loaded.
Changing to Singleplayer
Save user settings to C:\Documents and Settings\HP_Owner\Application Data\UFOAI/2.1.1/base/config.cfg
Shutting down win api sound system


let me know if slot1.sav would be useful to you.
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 21, 2007, 05:50:26 pm
Quote from: "Zenerka"
smalul, bugs not related to saving should be reported on sourceforge tracker if they are not mentioned there yet as well as reported here - that's because if the bug will be release-stopper, we will try to fix it ASAP, while if the bug won't block release, we can postpone it for next days.

OK, thanks. I've sent a few bugs to the tracker already.

Quote from: "Zenerka"
About the savegame bug with message subsystem, we will look into this, thanks for the report.

OK, more on this bug - first of all, it now seems 2 of the 8 save files are working, so not all is lost. Second, it seems like there are 2 stages to this bug:
1. The first part is the "Error loading game. Error in loading a subsystem - see console for more information", which appears only when I try to load a broken save file. Good save files are working fine.
Here is a picture of the bug:
(http://img258.imageshack.us/img258/8221/ver211loadingerrormi4.th.jpg) (http://img258.imageshack.us/my.php?image=ver211loadingerrormi4.jpg)
2. The second part is the "Error loading game. Error decompressing data". This part happens after you try to loading broken save files a few times in stage one ("Error in loading a subsystem"), and then you start getting this "decompressing data" error. In this stage, you can't load ANY of the save files, including the working ones, and all gives the same "decompressing data" error message.
Here is a picture of this stage:
(http://img441.imageshack.us/img441/8204/ver211loadingerrorstagevg5.th.jpg) (http://img441.imageshack.us/my.php?image=ver211loadingerrorstagevg5.jpg)
I hope this would help you locate and fix this bug.

By the way, do you need my saved files for analysis?
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 21, 2007, 05:59:58 pm
Thanks to your reports as well as reports from people joining our ircchannel, i found and fixed another bug in saving. It occurs in case you have more than one base and/or more than one ship with team assignment.
The workaround for this is to use only one ship with team assigned to it.
Title: Testing request: 2.1.1 testinstaller.
Post by: blondandy on April 21, 2007, 07:31:07 pm
just to confirm.

The second broken sav I reported in this thread happenned when
-I had no aircraft out
-I had one base and one dropship.

So I think there are more critters out there to be eliminated.
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 22, 2007, 01:43:58 pm
I've updated first post in this topic about new testinstaller and updated binaries. More testing needed. Thanks for your help.
Title: Testing request: 2.1.1 testinstaller.
Post by: blondandy on April 22, 2007, 02:52:09 pm
I am using 2.1.1 with updated binaries from this morning 22 April.

I have got through quite a few missions, with no broken saves :D

marvelous work.
Title: Testing request: 2.1.1 testinstaller.
Post by: inquisiteur2 on April 22, 2007, 03:41:35 pm
So far this is my 4th download and each time I fail opening the file. Sometimes it cuts me before 100 megs, and on my last download I managed to download the whole thing but file was corrupt...Im trying again.

ok worked this time.
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 22, 2007, 06:02:27 pm
OK, I've downloaded ufo.exe and 0ufos.pk3, and replaced the original files in my installed directory. I'm guessing you changed the load/save system again, because if I try to load a game saved with the original version 2.1.1 (April 20th), the game crashes. Here is a picture of the crash:
(http://img63.imageshack.us/img63/4927/assertionfailedcrashsamre8.th.jpg) (http://img63.imageshack.us/my.php?image=assertionfailedcrashsamre8.jpg)



Actually, I'm posting here because I found another bug in the load/save system of the original 2.1.1. beta (April 20th). I have no idea if you fixed this bug already (like I said - I can't load any of the older saved games), but just in case you haven't, here is the bug: When I try to load a certain saved game, I get an "Assertion failed!" crash. Here is the picture of the crash:
(http://img63.imageshack.us/img63/1729/assertionfailedcrashzb5.th.jpg) (http://img63.imageshack.us/my.php?image=assertionfailedcrashzb5.jpg)
If I press retry, I get a full game crash:
(http://img63.imageshack.us/img63/8059/assertionfailedcrashretwr1.th.jpg) (http://img63.imageshack.us/my.php?image=assertionfailedcrashretwr1.jpg)
Let me know if you need a copy of the saved game which causes this crash.

I hope I don't bother you with this bug too much, and if you already located and fixed it - I'm sorry.
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 22, 2007, 06:42:53 pm
Another "Error in loading a subsystem", this time with version 2.1.1 from April 22th, 2007 (the version you released today, I just replaced the 2 files like it was written).
The log:
Code: [Select]
====== UFO Initialized ======

Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size (null)u bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot0'
...subsystem 'base' - loaded 5715 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Activate stage intro
...subsystem 'campaign' - loaded 256 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6331 bytes
...subsystem 'employee' - loaded 13067 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 48 bytes
...subsystem 'aircraft' - loaded 1 bytes
...subsystem 'messagesystem' - loaded 992 bytes
...subsystem 'messagesystem' could not be loaded correctly - savegame might be broken (e1)
Changing to Singleplayer
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 22, 2007, 06:56:22 pm
smalul, but you tries the new game, not old loads from previous testinstaller, do you? The old loads won't work because of bugfixes we introduced.
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 22, 2007, 07:53:42 pm
Quote from: "Zenerka"
smalul, but you tries the new game, not old loads from previous testinstaller, do you? The old loads won't work because of bugfixes we introduced.

I don't quite understand your question, but I have installed today's update (you really should give each version a different number, and not refer to the release date as the version).
Anyway, my last post is about a bug in the latest release - the one from April 22th. I had that bug in version 2.1.1 from April 20th as well.

The post before that one (the post with the pictures) refers to version 2.1.1 from April 20th. I wrote I have no way of knowing if you fixed that bug or not, because the problematic saved games  won't work in version 2.1.1 from April 22th.
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 22, 2007, 08:08:38 pm
My question is: did you load the savegame saved in 2.1.1 from April 20th to 2.1.1 from April 22th? Or the last bug you mentioned is in a completely new singleplayer game started in 2.1.1 from April 22th from the scratch?
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 22, 2007, 09:25:02 pm
You can't load games from the April 20th version in the April 22th version - this would cause a crash.
The last bug I reported happened in version 2.1.1 from April 22th (as I wrote), and it was a completely new game.

Here is a link for the file itself:
http://files-upload.com/183223/slot0.sav.html
I hope this helps.
Title: Testing request: 2.1.1 testinstaller.
Post by: inquisiteur2 on April 22, 2007, 11:14:39 pm
I dont know if im supposed to post this issue in this thread but after the 2nd mission on difficult settings (it was in Guana i think i south africa) i lost the mission and had a CTD.

Going from from a tactical map to option menu (by pressin ESC) and going to "options" CTD too. (this was on first farm map on difficult settings).

In fact everytime now I go on option menu i have CTD...I wonder where this can come from. Once my computer restarted i was able to access option menu again.

(i am using last version 2.1.1) as from April 22nd.
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 23, 2007, 03:30:16 pm
smalul, additional question, which language do you use in game?
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 23, 2007, 05:12:23 pm
Quote from: "Zenerka"
smalul, additional question, which language do you use in game?

Well, by default "set s_language" was set to "", which gave me no text in the intro and research screens, so after searching the forum here, I've learned I had to edit config.cfg and set "set s_language" to "en_GB" to see the texts in English (I haven't seen any option to change the language while playing). I hope this helps.
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 23, 2007, 09:44:26 pm
OK, I've managed to get that "Assertion failed!" with version 2.1.1 from April 22th (couldn't you just called it version 2.1.2?). Here is part of the log:
Saving a game:
Code: [Select]
CL_UpdateHireVar()... aircraft idx: 0, homebase: PHALANX HQ
Activate stage ufos_are_coming
CL_UpdateHireVar()... aircraft idx: 0, homebase: PHALANX HQ
Save 'slot2'
...subsystem 'base' - saved 5963 bytes
...subsystem 'campaign' - saved 348 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6331 bytes
...subsystem 'employee' - saved 31661 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 22 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 28661 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign 'Shai49' saved.


After that save, I've built a second base with 2 radar stations (and the basics - power plant, living quarters...), as well as adding 2 more radar to my first base. Then I saved it:
Code: [Select]
CL_UpdateHireVar()... aircraft idx: 0, homebase: PHALANX HQ
Save 'slot3'
...subsystem 'base' - saved 11463 bytes
...subsystem 'campaign' - saved 348 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6331 bytes
...subsystem 'employee' - saved 31661 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 22 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 28737 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign 'Shai50' saved.


Then I got a few of these errors:
Code: [Select]
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2)
CL_UpdateHireVar()... aircraft idx: 0, homebase: PHALANX HQ
CL_UpdateHireVar()... aircraft idx: 0, homebase: PHALANX HQ


Then I decided to reload the game I just saved:
Code: [Select]
Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size (null)u bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot3'
...subsystem 'base' - loaded 11463 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Cmd_AddCommand: popup_aircraft_action_click already defined
Cmd_AddCommand: ships_click already defined
Cmd_AddCommand: ships_rclick already defined
Cmd_AddCommand: multi_select_click already defined
Activate stage intro
Activate stage ufos_are_coming
...subsystem 'campaign' - loaded 348 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6331 bytes
...subsystem 'employee' - loaded 31661 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 22 bytes
...subsystem 'aircraft' - loaded 1 bytes

And then there was that crash. Actually, it's not really a crash, but it refers you to the C++ debugger (if you have one installed), and if you choose to reply, then you get the crash screen.

Here is a link to slot3.sav save, which cause this problem:
http://www.filefactory.com/file/f2ef1b/
This should help you locate the problem, as it should take you directly to the debugger.

[EDIT] If I choose Ignore, I get a "Error in loading a subsystem" error. Here is the ufoconsole.log for that case:
Code: [Select]
Load 'slot3'
...subsystem 'base' - loaded 11463 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Cmd_AddCommand: popup_aircraft_action_click already defined
Cmd_AddCommand: ships_click already defined
Cmd_AddCommand: ships_rclick already defined
Cmd_AddCommand: multi_select_click already defined
Activate stage intro
Activate stage ufos_are_coming
...subsystem 'campaign' - loaded 348 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6331 bytes
...subsystem 'employee' - loaded 31661 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 22 bytes
...subsystem 'aircraft' - loaded 1 bytes
...subsystem 'messagesystem' - loaded 28831 bytes
...subsystem 'messagesystem' could not be loaded correctly - savegame might be broken (ffffffff)
Changing to Singleplayer


And just in case - here is the previous save:
http://www.filefactory.com/file/f566f6/
I saved just before building the second base with the 2 radar station, and before adding a radar station to my first base. This save Is working fine.
[/EDIT]

To sum all my posts so far - I've managed to get 2 different errors with both versions of version 2.1.1 (from April 20th and April 22th) - 1. "Error in loading a subsystem" error. 2. "Assertion failed!" Error and crash.

I'm sorry for all my posts here, but you did ask people to post about errors in the loading/saving system. I just hope something good will come out of all this.
Title: Testing request: 2.1.1 testinstaller.
Post by: Mattn on April 23, 2007, 10:26:02 pm
Quote
I'm sorry for all my posts here, but you did ask people to post about errors in the loading/saving system. I just hope something good will come out of all this.


Really no need to excuse - we need those reports - thank you

just make sure that you are using new savegames for every new binary - e.g don't use savegames from 20.04 binaries and try to load them into 22.04 binaries. that won't work
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 23, 2007, 10:53:56 pm
Quote from: "Mattn"
just make sure that you are using new savegames for every new binary - e.g don't use savegames from 20.04 binaries and try to load them into 22.04 binaries. that won't work

The files from my previous post are new game started in the April 22th version.  I will always use the newer versions, as long as you release them for download, but please - give each release a different version number - it would make it much easier to refer to the right version.
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 24, 2007, 05:11:13 pm
smalul, you are very good betatester and really no need to apologize for bugreports - that is your "job" here and our job is to read.
So did I, and have additional questions/requests.
I loaded your Shai50 and got assertion hit for (type < MSG_MAX) at cl_menu.c:3977 (writing it here just to not forget). But I suspect that the save is just corrupted. Then I loaded your Shai49 without any problem. Placed second base, added two radars, powerplant and quarters there, then went back to first base, placed two additional radars there - all exactly what you wrote. Then back to geoscape. No errors. Then saved. No errors. Then loaded. No errors. The bytes amount for load/save are ok. So I am asking - can you reproduce that with Shai49? If yes, can you, please, note all the steps you are doing to reproduce that bug? That would really help to identify that.
The B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2) error - just looking to the code, looks impossible to hit. The only way to get this would be to call this function with parameter being base index bigger than or equal to the amount of bases. Actually it can be done if only the baseCurrent pointer DOES NOT point to existing base... but THAT would mean something is really broken somewhere, because baseCurrent should always point to existing base. Otherwise -> KABOOM.
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 24, 2007, 08:05:38 pm
Quote from: "Zenerka"
So I am asking - can you reproduce that with Shai49? If yes, can you, please, note all the steps you are doing to reproduce that bug? That would really help to identify that.

Sorry, but I have not been able to reproduce this bug. I know that in both cases (in games started with both the April 20th and April 22th versions) I had 2 bases, with more than 1 radar station in each.
I will run memtest86 overnight just to make sure I don't have any problems with my computer memory.


Quote from: "Zenerka"
The B_GetNumberOfBuildingsInBaseByTypeIDX: Bad base-index given: 2 (numbases 2) error - just looking to the code, looks impossible to hit. The only way to get this would be to call this function with parameter being base index bigger than or equal to the amount of bases. Actually it can be done if only the baseCurrent pointer DOES NOT point to existing base... but THAT would mean something is really broken somewhere, because baseCurrent should always point to existing base. Otherwise -> KABOOM.

I have had this bug more than once, and now that I think of it - I'm quite sure some kind of saving/loading crash followed this bug.
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 25, 2007, 11:39:35 am
Updated first post here with the links to newest testinstaller. If nothing bad happens, this is the "final" testinstaller before 2.1.1 release. Changes:
- small bugfixes for various things
- one serious bugfix for savegame system (which means saved games from previous versions won't work)
- employee renaming reintroduced.

As always, testing is needed and bugreports should be placed here and additional on sf if they are not about saving/loading.
Thanks to you, people, for your hard betatesting work.
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 25, 2007, 01:19:22 pm
I got another "Assertion failed!" with the April 22th version, but now I see there is a newer version, so I'm downloading it now.

By the way, memtest86 didn't find any problem with my computer memory (after more than 10 hours), so do you have any idea what else could cause such a corruption of the saved games files, if it's not a problem with the load/save system?
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 26, 2007, 10:03:33 am
Sorry folks - two another bugs found. One, serious, in savegame subsystem, leading to crash under several circumstances, and second, also serious, in inventory saving system. These bugs are fixed and new tesinstallers are being prepared right now, so hold your horses with downloading the current one.
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 26, 2007, 12:37:55 pm
I guess I've hit one of those bug in the April 24th version as well. Just in case this isn't one of them, I'm posting the log here.

I've built another base, then saved:
Code: [Select]
]version
"version" is "UFO: Alien Invasion 2.1.1 x86 Apr 24 2007 Win32 DEBUG"
CL_UpdateHireVar()... aircraft idx: 0, homebase: PHALANX HQ
CL_UpdateHireVar()... aircraft idx: 2, homebase: Base #2
Save 'slot6'
...subsystem 'base' - saved 11607 bytes
...subsystem 'campaign' - saved 288 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6331 bytes
...subsystem 'employee' - saved 28459 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 22 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 26811 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign 'Shai31' saved.


Then I tried to load it. I hit the "Error in loading a subsystem" error again.
Code: [Select]
Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size (null)u bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot6'
...subsystem 'base' - loaded 11607 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Cmd_AddCommand: popup_aircraft_action_click already defined
Cmd_AddCommand: ships_click already defined
Cmd_AddCommand: ships_rclick already defined
Cmd_AddCommand: multi_select_click already defined
Activate stage intro
...subsystem 'campaign' - loaded 288 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6331 bytes
...subsystem 'employee' - loaded 28459 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 22 bytes
...subsystem 'aircraft' - loaded 1 bytes
...subsystem 'messagesystem' - loaded 26844 bytes
...subsystem 'messagesystem' could not be loaded correctly - savegame might be broken (3f)
Changing to Singleplayer


I hope the new version already have a fix for this.

Edit:
I hit the "Assertion failed!" bug with the April 24th version. It seems it is somehow related to having more than 1 base, and maybe more than 1 radar station, but I can't be sure. I'll try to reproduce the bug.

Here is the log:

Loading a working saved game:
Code: [Select]
Load 'slot5'
...subsystem 'base' - loaded 11479 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Cmd_AddCommand: popup_aircraft_action_click already defined
Cmd_AddCommand: ships_click already defined
Cmd_AddCommand: ships_rclick already defined
Cmd_AddCommand: multi_select_click already defined
Activate stage intro
...subsystem 'campaign' - loaded 244 bytes
...subsystem 'hospital' - loaded 6 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6331 bytes
...subsystem 'employee' - loaded 24022 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 22 bytes
...subsystem 'aircraft' - loaded 1 bytes
...subsystem 'messagesystem' - loaded 23353 bytes
...subsystem 'stats' - loaded 28 bytes
...subsystem 'nations' - loaded 32 bytes
File 'slot5' loaded.
Changing to Singleplayer


Built another radar station in the second base, let the time run. I saved when a mission popped-up:
Code: [Select]

CL_UpdateHireVar()... aircraft idx: 0, homebase: PHALANX HQ
CL_UpdateHireVar()... aircraft idx: 0, homebase: PHALANX HQ
CL_UpdateHireVar()... aircraft idx: 0, homebase: PHALANX HQ
CL_UpdateHireVar()... aircraft idx: 2, homebase: Base #2
CL_UpdateHireVar()... aircraft idx: 0, homebase: PHALANX HQ
Save 'slot7'
...subsystem 'base' - saved 11607 bytes
...subsystem 'campaign' - saved 292 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6331 bytes
...subsystem 'employee' - saved 28450 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 22 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 26811 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign 'Shai31-2' saved.


I then tried to reload the game I just saved:
Code: [Select]
Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size (null)u bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot7'
...subsystem 'base' - loaded 11607 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Cmd_AddCommand: popup_aircraft_action_click already defined
Cmd_AddCommand: ships_click already defined
Cmd_AddCommand: ships_rclick already defined
Cmd_AddCommand: multi_select_click already defined
Activate stage intro
...subsystem 'campaign' - loaded 292 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6331 bytes
...subsystem 'employee' - loaded 28450 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 22 bytes
...subsystem 'aircraft' - loaded 1 bytes

But then I hit that "Assertion failed!" bug.
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 26, 2007, 03:13:22 pm
I've just updated the first post here about new testinstallers.

smalul, in case of "assertion failed" bug, you for sure has three things on such debug window:
1) expression, which makes such assertion failed
2) filename of the source code
3) line number in the source code
Having all of them would be cool, but 2) and 3) are necessary to identify the problem.
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 26, 2007, 04:06:24 pm
Sorry Zenerka, I always get the same "Assertion failed!" error, and I've already posted a picture of that error in this thread, but here is the message again:
Quote

Assertion failed!

Program: G:\UFOAI-2.1.1\ufo.exe
File: ../../src/client/cl_menu.c
Line: 3977

Expression: type < MSG_MAX

For information on how your program can cause an assertion
failure, see the Visual C++ documentation on asserts

(Press Retry to debug the application - JIT must be enabled)

The picture:
(http://img63.imageshack.us/img63/1729/assertionfailedcrashzb5.th.jpg) (http://img63.imageshack.us/my.php?image=assertionfailedcrashzb5.jpg)

I must note that every time I got this error, it was the exact same error (same line, same file, same program).

I hope this helps.[/quote]
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 26, 2007, 04:43:29 pm
smalul, please, share savegame for this assert problem - I think that this assert is just a result of not saving message system properly, so (type < MSG_MAX) becomes true because of garbage crap in saved game.
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 26, 2007, 07:04:44 pm
OK, here is a link to this file:
http://www.filefactory.com/file/ddc39a/
I'm quite sure this is the right file (I erased the saves when I installed today's update, but luckily it was still in the recycle bin.

I will note again that this file is for the April 24th version, not the April 26th version, which you published today, so it won't work in current version.
And yes, it seems to me this bug is in the message system as well (the log stops just before loading the "messagesystem", there is another problem with the "messagesystem", and the expression is type < MSG_MAX). It seems to me like some sort of buffer overload bug (the size of the string it too big for the declared variable). I personally don't understand the need to save all those messages in the saved files - why don't you just dump them in the console log? I won't mind not seeing those message each time I load a saved game.
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 26, 2007, 07:18:10 pm
Ah, damn. OK, will try to revert to 24th April and test. Please, if you manage to reproduce such bug in today's testinstaller, drop a note and share a savegame as well, please.
Title: Testing request: 2.1.1 testinstaller.
Post by: blondandy on April 26, 2007, 11:45:27 pm
This bug/feature may have been superseded. I am still playing on a slightly old test release 2.1.1 April 22.

I have played through for quite a while (run out of stuff to research), had a base attacked and now the same mission keeps coming up. its "Atacama desert", map "falcon_crash04n". I've done it three times in a row now. So, have I reached the end of the story so far? or is this an unexpected bug?

If you are interested, I will make the .sav and log available.

I am playing on win xp with an amd64.
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 27, 2007, 08:19:32 am
Quote from: "blondandy"
I have played through for quite a while (run out of stuff to research), had a base attacked and now the same mission keeps coming up. its "Atacama desert", map "falcon_crash04n". I've done it three times in a row now. So, have I reached the end of the story so far? or is this an unexpected bug?

This is (currently) expected bug in your version, fixed in one of later versions. Unfortunately we didn't saved last missions in previous versions which lead to such bug.
And the game has its finish, you will for sure notice when The End will come.
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 27, 2007, 04:25:43 pm
There we go again... Another 'messagesystem' error. This time with the April 26th version (again, please - give those versions different numbers, that's the point of the minor version numbers, this should be 2.1.4).
OK, I've played a mission:
Code: [Select]

==== InitGame ====
------- Server Initialization -------
Created AI player (team 0)
Created AI player (team 7)
-------------------------------------
Map: mine_crash05d
                                     
pics
                                     
civilians/female/body02
                                     
civilians/female/head01a
                                     
civilians/female/body01
                                     
civilians/female/head02b
                                     
civilians/male/body01
                                     
civilians/male/head01
                                     
aliens/shevaar/body01
                                     
aliens/shevaar/head01
                                     
aliens/ortnoklight/body01
                                     
aliens/ortnoklight/head02
                                     
aliens/ortnokmedium/body01
                                     
aliens/ortnokmedium/head02
                                     
aliens/tamanlight/body01
                                     
aliens/tamanlight/head01
                                     
aliens/ortnoklight/head03
                                     
images
Shai has joined team 0
Shai has taken control over team 1.
Starting the game...
(player 0) It's team 1's round
CL_GetSkillString: Skill is bigger than max allowed skill value (101/100)
CL_GetSkillString: Skill is bigger than max allowed skill value (101/100)
CL_GetSkillString: Skill is bigger than max allowed skill value (101/100)
CL_GetSkillString: Skill is bigger than max allowed skill value (101/100)
Team 1 ended round, team 7's round started!
Team 7 ended round, team 0's round started!
Team 0 ended round, team 1's round started!
CL_GetSkillString: Skill is bigger than max allowed skill value (101/100)
CL_GetSkillString: Skill is bigger than max allowed skill value (101/100)
Akrokk Uk Kronok is consumed by mad rage!
Team 1 ended round, team 7's round started!
Team 7 ended round, team 0's round started!
==== ShutdownGame ====


Once the mission was over, I saw a UFO in the sky, so I took a picture (I had a feeling there would be a loading problem):
(http://img134.imageshack.us/img134/8582/savebeforeloaderrorapriee1.th.jpg) (http://img134.imageshack.us/my.php?image=savebeforeloaderrorapriee1.jpg)

Then I saved the game:
Code: [Select]

Save 'slot6'
...subsystem 'base' - saved 11588 bytes
...subsystem 'campaign' - saved 373 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6331 bytes
...subsystem 'employee' - saved 23318 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 100 bytes
...subsystem 'aircraft' - saved 125 bytes
...subsystem 'messagesystem' - saved 32146 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign 'Shai46' saved.
Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size (null)u bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8


And then I've decided to load this game (just to see if my feeling was right):
Code: [Select]

Load 'slot6'
...subsystem 'base' - loaded 11588 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Cmd_AddCommand: popup_aircraft_action_click already defined
Cmd_AddCommand: ships_click already defined
Cmd_AddCommand: ships_rclick already defined
Cmd_AddCommand: multi_select_click already defined
Activate stage intro
Activate stage ufos_are_coming
...subsystem 'campaign' - loaded 373 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6331 bytes
...subsystem 'employee' - loaded 23318 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 100 bytes
...subsystem 'aircraft' - loaded 125 bytes
...subsystem 'messagesystem' - loaded 32179 bytes
...subsystem 'messagesystem' could not be loaded correctly - savegame might be broken (3f)
Changing to Singleplayer


I guess my feeling was right...

I still think you should remove this "messagesystem" from the saved games files, and "dump" all the messages to the console. None of those messages are really critical, and you can't even scroll back to see the messages' history (you juse see the last 10 or 15 messages), so I hardly see the point of saving ALL the messages.
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 27, 2007, 05:02:27 pm
smalul
1) does this bug appear only in case of UFO on the geoscape? if yes - can you save when the ufo dissapears and check whether no problem with loading? then, can you shoot them out, save and check whether no problem with loading?
2) we are not going to give any numbers to testinstallers, because these are... testinstallers; of upcoming version 2.1.1; since no vital bugs will be found in these testinstallers we will release 2.1.1 version (based on 2.1.0 released month ago and focused on bugfixes and new savegame system)
3) about message subsystem - the message subsystem contains not only messages visible on the geoscape, but also mails in the mailclient (basicaly, they are the same); not saving all of them is pointless (in case of mails)
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 27, 2007, 06:03:11 pm
1. I don't think this bug has anything to do with the a UFO - I've had it in all the versions since version 2.1 (when I started playing), and in most of the cases it had nothing to do with the UFOs.

2 & 3. Thanks for your answers.

OK, I've loaded the previous game, played the mission, when the mission was over, there was no UFO on the geoscape. I've returned to the base, let the time pass, saved a few times, and loaded each of those saves. In one strange case, when I loaded a game there was a UFO on the geoscape (it wasn't there when I saved), I intercepted it, saved again, let the time pass, and saved again. And once again - I hit that bug:

The latest saving:
Code: [Select]

Save 'slot3'
...subsystem 'base' - saved 11495 bytes
...subsystem 'campaign' - saved 373 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6331 bytes
...subsystem 'employee' - saved 24307 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 87 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 35104 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign 'Shai51' saved.


The latest loading (with this bug):
Code: [Select]

Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size (null)u bytes
...techs: 132
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot3'
...subsystem 'base' - loaded 11495 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Cmd_AddCommand: popup_aircraft_action_click already defined
Cmd_AddCommand: ships_click already defined
Cmd_AddCommand: ships_rclick already defined
Cmd_AddCommand: multi_select_click already defined
Activate stage intro
Activate stage ufos_are_coming
...subsystem 'campaign' - loaded 373 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6331 bytes
...subsystem 'employee' - loaded 24307 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 87 bytes
...subsystem 'aircraft' - loaded 1 bytes
...subsystem 'messagesystem' - loaded 35137 bytes
...subsystem 'messagesystem' could not be loaded correctly - savegame might be broken (3f)
Changing to Singleplayer


You probably noticed this already, but when I save, a certain amount of bytes are saved in the "messagesystem" subsystem (...subsystem "messagesystem" - saved 35104 bytes), but when I load and this bug appears, more bytes are loaded from the "messagesystem" subsystem (...subsystem 'messagesystem' - loaded 35137 bytes). This has always been the case when this bug occurs. When everything works fine, the exact same amount of bytes are saved and loaded into and from the "messagesystem" subsystem.

I would also like to know if other players are having this bug, or is it just my problem? I've checked my computer memory with memtest86 and everything is fine, and I don't have any other problems with my computer, so I don't think this is a local problem.
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 27, 2007, 10:36:40 pm
Quote from: "smalul"
You probably noticed this already, but when I save, a certain amount of bytes are saved in the "messagesystem" subsystem (...subsystem "messagesystem" - saved 35104 bytes), but when I load and this bug appears, more bytes are loaded from the "messagesystem" subsystem (...subsystem 'messagesystem' - loaded 35137 bytes). This has always been the case when this bug occurs. When everything works fine, the exact same amount of bytes are saved and loaded into and from the "messagesystem" subsystem.

We have no idea what is causing this - really. :( Moreover, we cannot reproduce this, but the fact that you have such problems means that there is a bug somewhere, no doubt. The amount of loaded bytes for subsystem should be the same as amount of saved bytes.
This would be a wild guess... but we just uploaded new testinstallers (27.04.2007) - the same place as usual (szklo.eu.org) - there is a slightly modified (safer) way of message subsystem saving - could you try it, please? If this bug won't be fixed we will have to postpone 2.1.1 release. :(
Quote from: "smalul"
I would also like to know if other players are having this bug, or is it just my problem?

Last days and last testinstallers - no, but some other people also reported such problems with message subsystem saving some days ago. So I believe it is not "only you", but indeed, there is a bug somewhere.
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 28, 2007, 12:14:07 am
Quote from: "Zenerka"
We have no idea what is causing this - really. :( Moreover, we cannot reproduce this, but the fact that you have such problems means that there is a bug somewhere, no doubt. The amount of loaded bytes for subsystem should be the same as amount of saved bytes.
This would be a wild guess... but we just uploaded new testinstallers (27.04.2007) - the same place as usual (szklo.eu.org) - there is a slightly modified (safer) way of message subsystem saving - could you try it, please? If this bug won't be fixed we will have to postpone 2.1.1 release. :(

OK, downloading now.
You know, I actually thought of a way to help locate the bug - save the save games as simple text (disable the current encoding of the saved games files). This would probably make the saved games files bigger, and would allow cheating (by editing the files), but it would also show what information is saved into those files. Now, if and when this bug occurs again, you could just look at the text to see what exactly are those extra bytes, and you might get some idea as for their source. Once the problem is found and fixed, you could just re-enable that encoding.
This should help locate the problem, unless the bug is in the encoding algorithm itself.
 
I hope you won't have to postpone the next release, because repeating everything over and over again (I had to start a new game every time a new beta was released) is starting to get boring. I would love to to be able to do some new research, capture UFOs, kill new aliens and so on.

By the way - isn't it a problem for you that people are downloading about 260MB for each beta version (I'm assuming you have some kind of bandwidth limit)? Is there a way to download just the files you changed between the beta versions, just to help you with the bandwidth (I have no problem downloading 260MB each time, it only takes a few minutes)?

Quote from: "Zenerka"
Last days and last testinstallers - no, but some other people also reported such problems with message subsystem saving some days ago. So I believe it is not "only you", but indeed, there is a bug somewhere.

OK, thanks.

Edit:
OK, downloaded and installed. It seems I can load the games from the previous version (April 26th) in this version (April 27th) and play them just fine. Should I start a new game or can I continue my current game?
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 28, 2007, 12:49:51 am
Quote from: "smalul"
OK, downloaded and installed. It seems I can load the games from the previous version (April 26th) in this version (April 27th) and play them just fine. Should I start a new game or can I continue my current game?

It should be ok if you are sure that you loaded the same amount of bytes for message subsystem as saved.
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on April 29, 2007, 02:20:58 pm
Updated first post with new testinstaller links.
smalul, how things going apart of those bugs you reported on SF? Any problems with "message system loading" so far?
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 29, 2007, 03:30:10 pm
No, the load/save system seems to be working fine for me (as for the April 27th, 2007 version).
Downloading the April 29th, 2007 version now.
If I get one of those error messages again I'll post here as usual.
Title: Testing request: 2.1.1 testinstaller.
Post by: smalul on April 29, 2007, 10:10:04 pm
OK, this is probably nothing, but since it has something to do with the load/save system, I've decided to post it here.

I started the game and loaded a saved game:
Code: [Select]

====== UFO Initialized ======

Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size (null)u bytes
...techs: 131
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot0'
...subsystem 'base' - loaded 12287 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Activate stage invasion
...subsystem 'campaign' - loaded 210 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6288 bytes
...subsystem 'employee' - loaded 47198 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 61 bytes
...subsystem 'aircraft' - loaded 1 bytes
...subsystem 'messagesystem' - loaded 51335 bytes
...subsystem 'stats' - loaded 28 bytes
...subsystem 'nations' - loaded 32 bytes
File 'slot0' loaded.
Changing to Singleplayer


Then I passed the time a bit, and I wanted to save. But I clicked the wrong slot to save into, so I pressed ESC and saved to the right slot.
This is the save I tried to cancel. Notice the error message, and also - the fact that the game was actually saved (I thought pressing ESC would cancel the saving)
Code: [Select]

Save 'slot2'
MSG_WriteByte: range error -1 ('../../src/client/cl_basemanagement.c', line 2515)
...subsystem 'base' - saved 11839 bytes
...subsystem 'campaign' - saved 157 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6288 bytes
...subsystem 'employee' - saved 47198 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 48 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 51550 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign 'Shai79' saved.


Then I saved the game in the right slot, but again I got the same error message:
Code: [Select]

Save 'slot1'
MSG_WriteByte: range error -1 ('../../src/client/cl_basemanagement.c', line 2515)
...subsystem 'base' - saved 11839 bytes
...subsystem 'campaign' - saved 157 bytes
...subsystem 'hospital' - saved 2 bytes
...subsystem 'market' - saved 2176 bytes
...subsystem 'research' - saved 6288 bytes
...subsystem 'employee' - saved 47198 bytes
...subsystem 'aliencont' - saved 0 bytes
...subsystem 'production' - saved 48 bytes
...subsystem 'aircraft' - saved 1 bytes
...subsystem 'messagesystem' - saved 51550 bytes
...subsystem 'stats' - saved 28 bytes
...subsystem 'nations' - saved 32 bytes
Campaign 'Shai86' saved.


I then played a mission and saved a few more times after that. In those saves there was no error, and they can be loaded.
Just to clam you - there was no problem loading the game which was saved into slot1:

Code: [Select]

Loading savegame
...version: 1
...game version: 2.1.1
Global data loaded - size (null)u bytes
...techs: 131
...buildings: 18
...ranks: 8
...nations: 8

Load 'slot1'
...subsystem 'base' - loaded 11839 bytes
Initializing aircraft and aircraft-items ...
...aircraft and aircraft-items inited
Activate stage invasion
...subsystem 'campaign' - loaded 157 bytes
...subsystem 'hospital' - loaded 2 bytes
...subsystem 'market' - loaded 2176 bytes
...subsystem 'research' - loaded 6288 bytes
...subsystem 'employee' - loaded 47198 bytes
...subsystem 'aliencont' - loaded 0 bytes
...subsystem 'production' - loaded 48 bytes
...subsystem 'aircraft' - loaded 1 bytes
...subsystem 'messagesystem' - loaded 51550 bytes
...subsystem 'stats' - loaded 28 bytes
...subsystem 'nations' - loaded 32 bytes
File 'slot1' loaded.
Changing to Singleplayer


Like I said - this is probably noting, but I thought I should let you know.

Edit:
I'm of course using the latest version - 2.1.1 from April 29th, 2007.
Title: Testing request: 2.1.1 testinstaller.
Post by: Zenerka on May 01, 2007, 12:52:22 pm
Thanks for your hard work with betatesting and your reported bugs we managed to fix a lot of issues in 2.1 branch.

Earlier today 2.1.1 was released. Have fun playing.
Title: Testing request: 2.1.1 testinstaller.
Post by: cyb3rj on June 26, 2007, 12:39:08 pm
Quote from: "blondandy"
This bug/feature may have been superseded. I am still playing on a slightly old test release 2.1.1 April 22.

I have played through for quite a while (run out of stuff to research), had a base attacked and now the same mission keeps coming up. its "Atacama desert", map "falcon_crash04n". I've done it three times in a row now. So, have I reached the end of the story so far? or is this an unexpected bug?

If you are interested, I will make the .sav and log available.

I am playing on win xp with an amd64.


I am experiencing a problem with the same series of events on Kubuntu 7.04 (32-bit) in version 2.1.1.  However, the problem that happens with me is a crash.  When I click "Enter" to go into the mission, the game crashes.

I installed using the file from sourceforge.

Is this the official place where I report bugs?
Title: Testing request: 2.1.1 testinstaller.
Post by: BTAxis on June 26, 2007, 12:47:23 pm
Quote from: "cyb3rj"
Is this the official place where I report bugs?

This forum is meant for bug reports, but you can also have a look here (http://ufoai.ninex.info/wiki/index.php/Bugs).
Title: Testing request: 2.1.1 testinstaller.
Post by: Mattn on June 26, 2007, 01:40:42 pm
could you please post a backtrace of that crash - or your ufoconsole.log? maybe open up a sourceforge.net bug tracker item and attach the info