Debian: feedback and tests welcome

[Mattn]

Ok, I have built the latest stuff from the ufoai_2.5 branch and everything seems to work fine.

A few observations:

1. I would like to use a verbose build to detect possible issues as early as possible. Currently I see lines like that

Code: [Select]

===> CXX [uforadiant] src/tools/radiant/radiant/sound/SoundManagerModule.cpp
===> CXX [uforadiant] src/tools/radiant/radiant/sound/SoundPlayer.cpp
===> CXX [uforadiant] src/tools/radiant/radiant/script/ScriptLibrary.cpp
===> CXX [uforadiant] src/tools/radiant/radiant/script/ScriptLibraryModule.cpp
===> CXX [uforadiant] src/tools/radiant/radiant/script/ScriptTokeniser.cpp
===> CXX [uforadiant] src/tools/radiant/radiant/script/ScriptTokenWriter.cpp
How can I make the compiler commands and all flags visible?

make Q=

2. I have mostly tested UFO:AI under GNOME 3. It takes some time until the games starts up which is absolutely fine. However during this process a pop-up window with a message is shown which asks me if I want to "kill the application" or if I want to wait until the task finishes. (Obviously the game triggers a timeout somewhere) Screenshot with the message in German: ftp://46.182.19.209/images/GNOME3_warning.png
It could be a GNOME 3 issue. It's slightly annoying, unfortunately I don't know how to fix it. Did anyone see a similar message sometime?

Hm. We don't pump the event queue on loading all data. I don't think this is something that could be changed for 2.5 - but the precaching could be disabled.

Cvar cl_precache should be set to 0 (it's the default - but maybe you changed that?)

3. Fonts:
Here are two screenshots showing the in-game menu in English and German. I am old and my eyes are dim but I think the fonts are not really crisp. Is this normal?
ftp://46.182.19.209/images/ufoai_fonts_1.png
ftp://46.182.19.209/images/ufoai_fonts_2.png

The problem here is, that we scale after we rendered to the bitmap texture - this is a known issue and will most likely get fixed in 2.6 - but no promises on that.

[apo]

make Q=

Excellent. Thanks!

Hm. We don't pump the event queue on loading all data. I don't think this is something that could be changed for 2.5 - but the precaching could be disabled.

Cvar cl_precache should be set to 0 (it's the default - but maybe you changed that?)

I haven't touched cl_precache and it is still set to 0. I'm quite sure that I didn't see this issue when I tested the game for the first time back in August 2013. I think we have to monitor this issue for a while.

The problem here is, that we scale after we rendered to the bitmap texture - this is a known issue and will most likely get fixed in 2.6 - but no promises on that.

Ok, no problem. It's good to know it is not related to the packaging.

I currently don't see any other obstacles. As soon as you release 2.5, I will finish the last bits, test everything again and then I'm going to find a Debian developer who can upload the game. Since it is a new package, it has to go to the so-called "NEW queue". I keep you informed about this procedure and the next steps.

[Mattn]

awesome - thanks a lot

[apo]

Congratulations for your latest release. Back to Work now...

[solbu]

What is the reasoning for displaying: "Download this game for free" at the intro screen?

Personally I would like that the text was changed to something like "Download this free game", since that is more correct for a Free software project such as this. It implies that it is both "for free" and "free software", whereas the current text only suggest that is is for free and not necessarily free software.

[apo]

Bad news first:

It will take more time than anticipated to get UFO:AI officially into Debian because I can't find someone who wants to do a peer-review of the game. The game also has to be approved by Debian's "ftp masters" and their queue with new packages is stuck with hundreds of packages at the moment. There is also another random problem when it comes to compiling the maps. Sometimes the compilation terminates with a segmentation fault at different compilation steps. Happens on 64bit and 32bit systems.

Good news:

To shorten the time a little I have created two Ubuntu PPA's for Ubuntu 14.04 aka Trusty and the upcoming 14.10 aka Utopic.

https://launchpad.net/~apoleon/+archive/ubuntu/ufoai-ppa

https://launchpad.net/~apoleon/+archive/ubuntu/ufoai-ppa-trusty

Just follow the install instructions on those pages. The packages are based on the official Debian packaging. They were simply recompiled.

[apo]

Hi folks,

We have found the following possible mistakes in UFO:AI's LICENSES file and it would be really great if you could take a look at it. The first bulk of files seems like a pattern to me. The sources were obtained from commons.wikimedia.org. The website always states that those files are either licensed under the GFDL or CC-BY-SA-3.0. LICENSES mentions they are all GPL-2+. What is correct?

base/textures/tex_buildings/carpet001.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Antique_tabriz_carpet_413021.jpg
base/textures/tex_buildings/carpet007.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Ziegler_wiki_01.jpg
base/textures/tex_buildings/carpet013.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Gendje-rug.jpg
base/textures/tex_buildings/carpet015.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:44199reg.jpg
base/texturs/tex_buildings/carpet017.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Antique_kerman_persian.jpg
base/textures/tex_buildings/carpet019.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Antique_Serapi_carpet_26854.jpg
base/textures/tex_buildings/carpet022.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Nain_rug.jpg
base/textures/tex_buildings/carpet024.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:42556-Antique-Persian-Tabriz-Carpets-hires.jpg
base/textures/tex_buildings/carpet026.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Antique_rug_42432.jpg
base/textures/tex_buildings/carpet027.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Swatches_of_carpet_1.jpg
base/textures/tex_buildings/carpet028.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Swatches_of_carpet_1.jpg
base/textures/tex_buildings/carpet029.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Swatches_of_carpet_1.jpg
base/textures/tex_buildings/carpet030.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Swatches_of_carpet_1.jpg
base/textures/tex_buildings/carpet031.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Swatches_of_carpet_1.jpg
base/textures/tex_pics/art_africa005.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Zulu_Krieger.jpg
base/textures/tex_buildings/floor010.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Altmannshofen_St_Vitus_Boden_Chor.jpg
base/textures/tex_pics/art_africa009.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Masaidance.jpg

Those files are either licensed under GPL-3 or CC-BY-SA-3.0 according to the referenced source links.

base/textures/tex_buildings/wall007.png | GNU General Public License 2.0 or later | Sindwiller | http://opengameart.org/content/muddy-concrete-wall-01
base/textures/tex_buildings/wall007_2.png | GNU General Public License 2.0 or later | Sindwiller | http://opengameart.org/content/muddy-concrete-wall-02

This one is a possible copyright violation and the picture was deleted.

base/textures/tex_buildings/carpet016.png | Public Domain | MCR | http://commons.wikimedia.org/wiki/File:Amritsar_rug.jpg

Comments are much appreciated.

[DarkRain]

Hi,

My thoughts:

Seems like we'll have to remove base/textures/tex_buildings/carpet016.png, this texture is used in the following maps:

Code: [Select]

base/maps/oriental/or_house_e.map
base/maps/italy/it_main.map (x5)
base/maps/africa/af_craft_crash_fighter.map (x5)
base/maps/africa/af_house4a.map (x5)
base/maps/africa/af_house4.map (x5)
If mappers could replace these with some other texture ASAP it would be great

In the of the images by Sindwiller, it seem to me like a case of copypaste editing gone wrong, but Mattn should be able to clarify things here (see commit 1f7a9bf5)

In the case of the textures by MCR (sourced form Commons) it seems we have an infringement of the license, which I want to think was unintentional, MCR has left the project but maybe we could contact him about this, if that fails, I think (but I'm not a lawyer) that we can invoke clause 7a of the CC-BY-SA (CC-BY in one case!) license

[apo]

Seems like we'll have to remove base/textures/tex_buildings/carpet016.png, this texture is used in the following maps:

Hi DarkRain,

thanks for your reply. Then I will wait until you have found a replacement for carpet016.png and then use this one instead. Since the other images are all under a free license, I don't see any problems if you switch from GPL-2+ to CC-BY-SA-3.0 and note that in LICENSES. Clause 7a might be helpful but of course, if MCR agreed to a license change, that would be even better.

[apo]

Hi,

I have converted the LICENSES file into a machine-readable copyright file that is used across the Debian distribution. One of its benefits is that you can easily spot missing copyright information. The following files are not accounted for in LICENSES hence I assume they are covered by your general GPL-2+ license. If this is not true, please let me know. You can find the "ufoai_copyright.py" script that I used to convert the LICENSES file here:

http://anonscm.debian.org/cgit/pkg-games/ufoai.git


Missing copyright information:

base/materials/africa.mat
base/materials/alienbase.mat
base/materials/baseattack.mat
base/materials/beach.mat
base/materials/bridge.mat
base/materials/bunker.mat
base/materials/city2.mat
base/materials/city3.mat
base/materials/city_industry.mat
base/materials/city_train.mat
base/materials/construction.mat
base/materials/corrupter_crash.mat
base/materials/country.mat
base/materials/desert.mat
base/materials/druglord.mat
base/materials/eaglenest.mat
base/materials/england.mat
base/materials/estate.mat
base/materials/excavation.mat
base/materials/farm.mat
base/materials/ferry.mat
base/materials/forest.mat
base/materials/frozen.mat
base/materials/gasstation.mat
base/materials/gate.mat
base/materials/harbor.mat
base/materials/hills.mat
base/materials/industrial.mat
base/materials/italy.mat
base/materials/japan.mat
base/materials/mansion.mat
base/materials/military_convoy.mat
base/materials/mine.mat
base/materials/neighbourhood.mat
base/materials/office.mat
base/materials/oriental.mat
base/materials/oriental_mosque.mat
base/materials/pipes_const.mat
base/materials/resort.mat
base/materials/rivertown.mat
base/materials/scout_crash.mat
base/materials/small_street.mat
base/materials/solarplant.mat
base/materials/spedition.mat
base/materials/tower.mat
base/materials/transport.mat
base/materials/tropic.mat
base/materials/ufocrash.mat
base/materials/urban.mat
base/materials/village.mat
base/materials/village2.mat
base/materials/wilderness.mat
base/models/animals/crocodile/croc.anm
base/models/civilians/male/soldier01.anm
base/models/objects/cameras/camera1.anm
base/models/objects/vegi/palm_a/palm1.anm
base/pics/icons/delete.png
base/pics/icons/delete_hovered.png
base/pics/implants/implant_amphetamine.png
base/pics/implants/implant_muscular.png
base/pics/maps/shots/beach.jpg
base/shaders/cook-torrance_fs.glsl
base/shaders/lerp_vs.glsl
base/shaders/simple_glow_fs.glsl
base/shaders/simple_glow_vs.glsl


base/maps/africa/af_house4a.map
base/maps/africa/af_house6.map
base/maps/africa/af_house6a.map
base/maps/africa/af_house6b.map
base/maps/alienb/ab_antimatter.map
base/maps/alienb/ab_entrance.map
base/maps/alienb/ab_hall_4way1.map
base/maps/alienb/ab_hall_cne1.map
base/maps/alienb/ab_hall_cnw1.map
base/maps/alienb/ab_hall_cse1.map
base/maps/alienb/ab_hall_csw1.map
base/maps/alienb/ab_hall_h1.map
base/maps/alienb/ab_hall_tbtm1.map
base/maps/alienb/ab_hall_ttop1.map
base/maps/alienb/ab_hall_v1.map
base/maps/alienb/ab_hall_v2.map
base/maps/alienb/ab_hangar.map
base/maps/alienb/ab_hub.map
base/maps/alienb/ab_lab.map
base/maps/alienb/ab_powercore.map
base/maps/alienb/ab_storage_v.map
base/maps/alienb/ab_ventl.map
base/maps/alienb/ab_ventr.map
base/maps/alienb/ab_wormhole.map
base/maps/alienbase.ump
base/maps/b/construction.map
base/maps/baseattack.ump
base/maps/bridge/br_craft_crash_scout.map
base/maps/compile.pl
base/maps/compile.py
base/maps/desert.ump
base/maps/farm2.ump
base/maps/farm2/f_craft_drop_firebird.map
base/maps/farm2/f_craft_drop_herakles.map
base/maps/farm2/f_craft_drop_raptor.map
base/maps/farm2/f_craft_ufo_fighter.map
base/maps/farm2/f_craft_ufo_scout.map
base/maps/forest/fr_f31.map
base/maps/forest/fr_f32.map
base/maps/forest/fr_f33.map
base/maps/forest/fr_f34.map
base/maps/forest/fr_f35.map
base/maps/forest/fr_f36.map
base/maps/forest/fr_f37.map
base/maps/forest/fr_f38.map
base/maps/forest/fr_f39.map
base/maps/forest/fr_f40.map
base/maps/forest/fr_f41.map
base/maps/forest/fr_f42.map
base/maps/forest/fr_f43.map
base/maps/forest/fr_f44.map
base/maps/forest/fr_f45.map
base/maps/forest/fr_f46.map
base/maps/forest/fr_f47.map
base/maps/forest/fr_f48.map
base/maps/forest/fr_f49.map
base/maps/forest/fr_f50.map
base/maps/forest/fr_f51.map
base/maps/forest/fr_f52.map
base/maps/forest/fr_f53.map
base/maps/forest/fr_f54.map
base/maps/forest/fr_h5.map
base/maps/forest/fr_h6.map
base/maps/forest/fr_h7.map
base/maps/gate.map
base/maps/hills.ump
base/maps/hills/craft_drop_herakles.map
base/maps/hills/craft_drop_raptor.map
base/maps/hills/craft_ufo_scout.map
base/maps/hills/filler_1s3_d.map
base/maps/hills/filler_1s4_d.map
base/maps/hills/filler_1s5.map
base/maps/hills/filler_1s6.map
base/maps/hills/house_15.map
base/maps/japan/ja_p_btl.map
base/maps/oriental/or_house_i.map
base/maps/oriental/or_house_k.map
base/maps/oriental/or_house_l.map
base/maps/oriental/or_house_m.map
base/maps/oriental/or_house_n.map
base/maps/oriental/or_minaret01.map
base/maps/oriental/or_minaret02.map
base/maps/oriental/or_minaret03.map
base/maps/oriental/or_minaret04.map
base/maps/oriental/or_shed_b.map
base/maps/oriental/or_shed_c.map
base/maps/oriental/or_stand_c.map
base/maps/oriental/or_stand_d.map
base/maps/oriental/or_stand_e.map
base/maps/oriental_mosque.ump
base/maps/oriental_mosque/om_craft_drop_firebird.map
base/maps/oriental_mosque/om_craft_drop_herakles.map
base/maps/oriental_mosque/om_craft_drop_raptor.map
base/maps/rescue.ump
base/maps/scout_crash.ump
base/maps/scout_crash/sc_craft_drop_firebird.map
base/maps/scout_crash/sc_craft_drop_herakles.map
base/maps/scout_crash/sc_craft_drop_raptor.map
base/maps/shared.ump
base/maps/small_house.map
base/maps/small_street.map
base/maps/tower.ump
base/maps/tower/t_craft_drop_herakles.map
base/maps/tower/t_craft_drop_raptor.map
base/maps/training_a.map
base/maps/training_b.map
base/maps/village2.ump
base/maps/village2/vil_b2x2_dentist01.map
base/maps/village2/vil_b2x2_diner01.map
base/maps/village2/vil_b2x2_house01.map
base/maps/village2/vil_b2x2_house02.map
base/maps/village2/vil_b2x2_house03.map
base/maps/village2/vil_b2x2_house05.map
base/maps/village2/vil_b2x2_house08.map
base/maps/village2/vil_b2x2_house09.map
base/maps/village2/vil_b2x4_house04.map
base/maps/village2/vil_b2x4_house06.map
base/maps/village2/vil_b2x4_house07.map
base/maps/village2/vil_b2x4_mart01.map
base/maps/village2/vil_b2x4_station01.map
base/maps/village2/vil_craft_drop_firebird.map
base/maps/village2/vil_craft_ufo_fighter.map
base/maps/village2/vil_craft_ufo_scout.map
base/maps/village2/vil_mp1.map
base/maps/village2/vil_mp2.map
base/maps/village2/vil_mp3.map
base/maps/village2/vil_p2x2_garden01.map
base/maps/village2/vil_p2x2_playground01.map
base/maps/village2/vil_p2x2_playground02.map
base/maps/village2/vil_p4x4_fountain01.map
base/maps/village2/vil_sc_ne01.map
base/maps/village2/vil_sc_nw01.map
base/maps/village2/vil_sc_sw01.map
base/maps/village2/vil_sh1x1_01.map
base/maps/village2/vil_sh_01.map
base/maps/village2/vil_sh_02.map
base/maps/village2/vil_sh_03.map
base/maps/village2/vil_st_east01.map
base/maps/village2/vil_st_north01.map
base/maps/village2/vil_st_north02.map
base/maps/village2/vil_st_south01.map
base/maps/village2/vil_st_west01.map
base/maps/village2/vil_sv1x1_01.map
base/maps/village2/vil_sv_01.map
base/maps/village2/vil_sv_02.map
base/maps/village2/vil_sv_03.map
base/maps/village2/vil_sv_04.map
base/maps/village2/vil_sx_01.map
base/textures/tex_buildings/concrete024.png
base/textures/tex_buildings/concrete024_nm.png
base/textures/tex_buildings/concrete_slabs01.png
base/textures/tex_buildings/concrete_slabs01_nm.png
base/textures/tex_buildings/concrete_slabs02.png
base/textures/tex_buildings/concrete_slabs02_nm.png
base/textures/tex_buildings/floor002.png
base/textures/tex_buildings/floor002_nm.png
base/textures/tex_buildings/floor011.png
base/textures/tex_buildings/floor022.png
base/textures/tex_buildings/floor022_nm.png
base/textures/tex_buildings/japwall003.png
base/textures/tex_buildings/japwall004.png
base/textures/tex_buildings/japwall005.png
base/textures/tex_buildings/japwall006.png
base/textures/tex_buildings/japwall007.png
base/textures/tex_buildings/wall019.png
base/textures/tex_buildings/wall_brick01.png
base/textures/tex_buildings/wall_brick01_nm.png
base/textures/tex_buildings/wall_brick01_sm.png
base/textures/tex_buildings/wall_se08.png

[DarkRain]

Hi,

I have converted the LICENSES file into a machine-readable copyright file that is used across the Debian distribution. One of its benefits is that you can easily spot missing copyright information. The following files are not accounted for in LICENSES hence I assume they are covered by your general GPL-2+ license. If this is not true, please let me know. You can find the "ufoai_copyright.py" script that I used to convert the LICENSES file here:

http://anonscm.debian.org/cgit/pkg-games/ufoai.git

<snip>

Your assumption is good, except in the case of all those base/textures/* files mentioned in your post, in fact each of those has its own entry in LICENSES, maybe there was an error during the conversion?

[apo]

I see the difference now:


Creative Commons Attribution-ShareAlike 3.0 Unported

Creative Commons Attribution-Share Alike 3.0

Seems I missed that ShareAlike is written in one word and the other time it's split into two words.

[DarkRain]

Ah, of course (and I should have looked at your script before) Mattn already unified the spelling in master*, of course, the 'MIT License' vs 'MIT/X11 license (GPL compatible)' issue remains

*commit: a01d047 (it goes cleanly into 2.5, if that will help)

[apo]

I fixed the "MIT License" vs "MIT/X11 license (GPL compatible)" in my script but the unified license names will surely be useful for the next release.

[DarkRain]

Ok, so MCR agreed to re-license his files (he mistook the GFDL for the GPL at the time) (see commits: master: 67f0620, 2.5: f2373b8)
I also corrected the licenses for Sindwiller's files, (unlike the previous ones those weren't changed so i just outright crrected the license) (master: cd5cb33, 2.5: 9061377)
ShipIt replaced all instances of carpet016.png with carpet017.png in our maps and removed the offending file (master: 21ee171, 2.5:f516da3)

So, any other issues remaining?