General > Discussion

Will 2.3.1 fix reaction fire?

<< < (6/6)

DarkRain:
I think Mattn preferes format-patch

Waldschrat:
Well, here we go, two commits.
The first one fixes the build (at least the missing files problem, ufo_model still got undefined references).
The second one makes reaction fire ignore reserved TUs.

It's not tested, because starting a skirmish game gets stuck at the end of the load with "Awaiting game start (0)".

Mattn:
thanks a lot - it would be better to post patches on the patch tracker - this time i've seen them - but they might get lost on the forum.

Mattn:
i can't accept your first patch - at it break compilation via normal make

Waldschrat:
I don't know enough about the build system to properly fix it, I just did the obvious thing such that it again worked for me. If make and c::b handle things differently, it must probably be fixed somewhere else.

I didn't know about the patch tracker, I just asked in the thread where to put the patches and was told to attach them. However I just had a look at the tracker and saw that there is another patch (3082295) that also fixes the reaction fire. I'm not sure which one is the better solution, I think this one work better on 2.3 and mine on master, but anyway: Do not apply both or we'll end up with negative TUs, I think.

Navigation

[0] Message Index

[*] Previous page