General > Discussion

Will 2.3.1 fix reaction fire?

<< < (4/6) > >>

Mattn:
feel free to just attach a patch here.

bayo:
Or reset the reservation TU when we end the round, which make sens, cause reservation is only need when we are playing.

Waldschrat:
What commit shall I base the patch on?
- Current master: Doesn't even build, so no way to test it.
- Older commit (94ad32cb) fixing some other reaction fire action check problem: Builds, but crashes on start.
- 2.3 branch: Builds and works, but won't merge into the current master.

So, pick your poison: Untested or merge conflicts?

Mattn:
* why isn't the build working? what is the problem?
* backtrace available about the crash (or already fixed?)

if you have a patch for 2.3 available, just attach it - if it can't get merged into master we should fix you build problems and you should base it upon master

DarkRain:

--- Quote from: Waldschrat on October 12, 2010, 10:36:15 pm ---- Current master: Doesn't even build, so no way to test it.

--- End quote ---
Did you make clean before building? That solved the problem for me.

Navigation

[0] Message Index

[#] Next page

[*] Previous page