INV_EquipmentSanityCheck

[DarkRain]

While looking at the code I found this in cl_inventory.c (INV_EquipmentSanityCheck):

Code: [Select]

for (i = 0; i < csi.numEDs; i++) {
const equipDef_t const *ed = &csi.eds[i];
/* only check definitions used for generating teams */
if (strncmp(ed->name, "alien", 5) && strncmp(ed->name, "phalanx", 7)) <---- Line 176
continue;
That condition does not make sense to me, but maybe this is no bug but just somthing I utterly fail to understand?

[Mattn]

only alien* and phalanx* equipment ids should be checked here (equipment.ufo) - stuff like civilian_soldier or whatever they are called should not get checked - but i'm not sure why

[geever]

only alien* and phalanx* equipment ids should be checked here (equipment.ufo) - stuff like civilian_soldier or whatever they are called should not get checked - but i'm not sure why

But a string cannot start with "alien" and "phalanx" at the same time. Isn't this AND rather an OR?

-geever

[DarkRain]

only alien* and phalanx* equipment ids should be checked here (equipment.ufo) - stuff like civilian_soldier or whatever they are called should not get checked - but i'm not sure why

I see, hope that does not cause any problems...
but not really a bug then

But a string cannot start with "alien" and "phalanx" at the same time. Isn't this AND rather an OR?

That is confusing it seems to do what it's supposed to  -- will be true when the string does not start with "alien" nor "phalanx" as both comparisions will return non zero

[geever]

That is confusing it seems to do what it's supposed to  -- will be true when the string does not start with "alien" nor "phalanx" as both comparisions will return non zero

Yeah, I always forget that it returns an index and we use it for boolean checks. My fault, sorry.
(Maybe a macro could help not getting confused on this.) 

-geever

[DarkRain]

Still it might be good to check the civilian* equipments -- you never know who will change the scripts...
But once again not really a bug...

[squishles]

Still it might be good to check the civilian* equipments -- you never know who will change the scripts...
But once again not really a bug...

is that civilian packn' heat O.o that might actually be a nifty thing to add like have a few of them with some underpowered pea shooter