Suggestion about chance to hit calculation

[Rani]

In CL_TargetingToHit [cl_actor.c , line 1671] ,
change all the call for CM_TestLine to CM_EntTestLine
to reflect that the firing arc can be blocked by
other actors [other team members, civilians, other aliens].

Also , before making the soldier shoot in reaction
fire, make sure the chance to hit is larger
then some given percentage [unless in panic] .

[Bandobras]

In CL_TargetingToHit [cl_actor.c , line 1671] ,
change all the call for CM_TestLine to CM_EntTestLine
to reflect that the firing arc can be blocked by
other actors [other team members, civilians, other aliens].

Nice idea. Is it tested?

Also , before making the soldier shoot in reaction
fire, make sure the chance to hit is larger
then some given percentage [unless in panic] .

I think it's already done, but the chance to hit calculations are buggy. Could you verify (and fix:-)?

[Rani]

No, there is no "hit chance" check in
reaction fire. It just shoots if visibility>0.4,
which doesnt say anything on range ect.

Also, sadly i cant "test&fix" anything , becouse ,
like i stated in my other post, i cant get into a mission
with the svn version.

[Bandobras]

No, there is no "hit chance" check in
reaction fire. It just shoots if visibility>0.4,
which doesnt say anything on range ect.

Yes, no range, but perhaps an incomplete (and buggy) probability to hit friendly units, after all?

Also, sadly i cant "test&fix" anything , becouse ,
like i stated in my other post, i cant get into a mission
with the svn version.

Wow, you contribute without being even able to run the game once! =*-O

P.S. Unfortunately there is no difference when using CM_TestLine and CM_EntTestLine. I don't know why...

[Rani]

Probably the function is broken.
I suspect that "inline" list, what ever it is.

At any rate, I guess it can be replaced with a trace.

[Bandobras]

When you have any patch ready, please post...

[Rani]

Just as I suspected. Inline list is always empty.

I'v seached, and nothing is actually added to the
list anywhere in the code...

Any idea whats it for/where should it be updated,
and with what?

Edit: Did some sniffing. Looks like inline is only used
for models inside the map files.
If this is correct, then this function
ignores actors. What a shame.

Can someone verify that?

[Bandobras]

As far as I can tell, Inline list is updated with whatever a function wants to put there. And then it's usually emptied right before the function end. So, you can probably put there also the soldiers...