[trunk 30149] pk3 error

[jerikojerk]

I saved a game with a revision previous to 30111. I can not load the game with rev 30149. I'm playing with french translation on ubuntu/lucid.

error message

Loading savegame xml (size 78773)
Loading savegame
...version: 4
...game version: 2.4-dev
...xml Size: 967300, compressed? y
Shutdown gametype 'Campaign mode'
Change gametype to 'Campaign mode'

--- save subsystem initialization --
added base subsystem
added research subsystem
added campaign subsystem
added hospital subsystem
added market subsystem
added employee subsystem
added aliencont subsystem
added aircraft subsystem
added installation subsystem
added ufostores subsystem
added production subsystem
added messagesystem subsystem
added stats subsystem
added nations subsystem
added transfer subsystem
added alien base subsystem
added xvirate subsystem
added messageoptions subsystem
Campaign data loaded - size 4466980 bytes
...techs: 201
...buildings: 19
...ranks: 16
...nations: 8
...cities: 457

Load 'slot4' 18 subsystems
...Running subsystem 'base'
...subsystem 'base' - loaded.
...Running subsystem 'research'
...subsystem 'research' - loaded.
...Running subsystem 'campaign'
...subsystem 'campaign' - loaded.
...Running subsystem 'hospital'
...subsystem 'hospital' - loaded.
...Running subsystem 'market'
...subsystem 'market' - loaded.
...Running subsystem 'employee'
Invalid TeamDefIDX 16 for Mahmoud Novak (ucn: 0)
Error loading character definition for employee
...subsystem 'employee' returned false - savegame could not be loaded

/projets/ufoai/trunk$ svn info
Chemin : .
URL : http://ufoai.svn.sourceforge.net/svnroot/ufoai/ufoai/trunk
Racine du dépôt : http://ufoai.svn.sourceforge.net/svnroot/ufoai
UUID du dépôt : 39b98707-f80d-0410-bc7e-c6b02f5409da
Révision : 30149
Type de nœud : répertoire
Tâche programmée : normale
Auteur de la dernière modification : tlh2000
Révision de la dernière modification : 30144
Date de la dernière modification: 2010-05-24 20:09:04 +0200 (lun. 24 mai 2010)

thanks

[geever]

Your savegame loads fine with r30169. 16 is a valid teamDefIDX, we have 22 team definitions. Please check if you have all the team_*.ufo files in base/ufos/ (or in 0ufos.pk3).

There should be:
04 team definitions in team_aliens.ufo
12 team definitions in team_civilians.ufo
06 team definitions in team_humans.ufo

-geever

[jerikojerk]

what did (not) happen when i did make install?


i found this in my trunk:

Code: [Select]

jerikojerk@hp:~/projets/ufoai/trunk$ locate *team_*s.ufo
/home/jerikojerk/projets/ufoai/trunk/base/ufos/team_aliens.ufo
/home/jerikojerk/projets/ufoai/trunk/base/ufos/team_civilians.ufo
/home/jerikojerk/projets/ufoai/trunk/base/ufos/team_humans.ufo
they where not copied in /usr but they were in the pk3 archive.

Code: [Select]

ls -R /usr/local/ufoai
/usr/local/share/ufoai/:
base
ufo
ufo2map
ufoded
ufomodel

/usr/local/share/ufoai/base:
-rw-r--r--  1 root root      4828 2010-06-01 22:14 0base.pk3
-rw-r--r--  1 root root 140682895 2010-06-01 22:14 0maps.pk3
-rw-r--r--  1 root root     16079 2010-06-01 22:14 0materials.pk3
-rw-r--r--  1 root root  11578623 2010-06-01 22:14 0media.pk3
-rw-r--r--  1 root root 100841155 2010-06-01 22:14 0models.pk3
-rw-r--r--  1 root root 165693600 2010-06-01 22:14 0music.pk3
-rw-r--r--  1 root root 242944275 2010-06-01 22:14 0pics.pk3
-rw-r--r--  1 root root     15003 2010-06-01 22:14 0shaders.pk3
-rw-r--r--  1 root root   9488464 2010-06-01 22:14 0snd.pk3
-rw-r--r--  1 root root    203614 2010-06-01 22:14 0ufos.pk3
-rw-r--r--  1 root root   7005295 2010-06-01 22:14 0videos.pk3
-rwxr-xr-x  1 root root   1160644 2010-06-01 22:14 game.so
drwxr-xr-x 28 root root      4096 2010-05-24 17:36 i18n

/usr/local/share/ufoai/base/i18n:
bg_BG
cs
da
de
el
en
es
es_ES
et
fi
fr
hu
it
ja
ko
nl_NL
no
pl
pt
pt_BR
ru
sl
sv
th
uk
zh_CN

/usr/local/share/ufoai/base/i18n/bg_BG:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/bg_BG/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/cs:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/cs/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/da:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/da/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/de:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/de/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/el:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/el/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/en:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/en/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/es:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/es/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/es_ES:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/es_ES/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/et:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/et/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/fi:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/fi/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/fr:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/fr/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/hu:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/hu/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/it:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/it/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/ja:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/ja/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/ko:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/ko/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/nl_NL:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/nl_NL/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/no:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/no/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/pl:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/pl/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/pt:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/pt/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/pt_BR:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/pt_BR/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/ru:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/ru/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/sl:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/sl/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/sv:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/sv/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/th:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/th/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/uk:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/uk/LC_MESSAGES:
ufoai.mo

/usr/local/share/ufoai/base/i18n/zh_CN:
LC_MESSAGES

/usr/local/share/ufoai/base/i18n/zh_CN/LC_MESSAGES:
ufoai.mo
i do simple check on team_*s.ufo files in the trunk, of course they look ok, as my repository is up to date.

Code: [Select]

jerikojerk@hp:~/projets/ufoai/trunk$ grep team  base/ufos/team_civilians.ufo
// Please see team_humans.ufo
// The civilian teams must match the nation ids
team latin
team states
team europe
team asia
team middle
team africa
team russia
team oceania
team armysoldier
team scientist
team worker
team miner


Code: [Select]

jerikojerk@hp:~/projets/ufoai/trunk$ grep team  base/ufos/team_humans.ufo
// team <team-id> {}
// Defines a team.
// The particle that is shown if an actor from the given team was hit
// The name of the team (translatable)
// Boolean - team is for robots
// Boolean - team can carry armour
// Boolean - team can carry weapons
team phalanx
team phalanx_scientist
team phalanx_pilot
team phalanx_worker
team phalanx_ugv_phoenix
team phalanx_ugv_ares_w


Code: [Select]

jerikojerk@hp:~/projets/ufoai/trunk$ grep team  base/ufos/team_aliens.ufo
// Please see team_humans.ufo
// race Race of the team (see CL_GetAlienRaceByID() for available values). Default value is phalanx race.
// robot Team is a robot team
// name Translatable team name
// the team specific footsteps
team taman
team ortnok
team shevaar
team bloodspider
i did copy manualy them in /usr/local/share/ufoai (not the pk3 file but the whole base/ufos directory) ... and it works !

thanks a lot.

i think there is something to be done in the installer.

[jerikojerk]

just to check if pk3 file is used or not i remove the copy and change 0ufos.pk3 right ( chmod 777 ) but i did not get the thing working.

is there a "fixed" button?

[geever]

just to check if pk3 file is used or not i remove the copy and change 0ufos.pk3 right ( chmod 777 ) but i did not get the thing working.

pk3s are used. you could check if the pk3 contains the necessary ufo files and recreate it if needed. (pk3 is a renamed zip)

is there a "fixed" button?

No, this is not a Bugtracker, thats here!

-geever

[jerikojerk]

Yes, you find it. 0ufos.pk3 does not contain a team_humans.ufo ( i'm at rev 30293 ).

Gnome show me a zip icon, so i gessed it quickly

thanks a lot !

[jerikojerk]

to be sure i did a svn up (get rev  30303) ./configure && make pk3 and i get:

  adding: ufos/team_humans.ufo (deflated 84%)

[geever]

Anyway it is good that this turned out. Savegames could have broken if we put in a new alien race or a civilian type.
I changed saves not saving the index but the scripted id of the team. Thanks!

-geever

[jerikojerk]

i'm sorry but i'm still experimenting the bug now(i'm at Révision : 30394 ), BUT i know how to reproduce it.

• i remove all pk3 files (rm ./trunk/base/.../*.pk3)
• i type "make pk3", and the pk3 are ok. great.
• some days later i do svn up, get on update in a file which is in 0ufos.pk3.
• there my bug happens:

jerikojerk@hp:~/projets/ufoai/trunk$ make pk3
make -f build/data.mk pk3
make[1]: entrant dans le répertoire « /home/jerikojerk/projets/ufoai/trunk »
cd base; zip -u9  0ufos.pk3 ufos/ui/basedefence.ufo
updating: ufos/ui/basedefence.ufo (deflated 78%)
zip -d base/0ufos.pk3 ufos/team_humans.ufo
deleting: ufos/team_humans.ufo
make[1]: quittant le répertoire « /home/jerikojerk/projets/ufoai/trunk »

i think there is a feature allowing to remove obsolete files in the archives, for some reason, there is a trouble when updating.
During the first creation of the pk3, the delete command is executed too, but with void arguments, so there is just a ignored error.

jerikojerk@hp:~/projets/ufoai/trunk$ rm base/0ufos.pk3
jerikojerk@hp:~/projets/ufoai/trunk$ make pk3
make -f build/data.mk pk3
zipinfo:  cannot find or open base/0ufos.pk3, base/0ufos.pk3.zip or base/0ufos.pk3.ZIP.
make[1]: entrant dans le répertoire « /home/jerikojerk/projets/ufoai/trunk »
cd base; zip -u9  0ufos.pk3 ufos/team_humans.ufo ufos/armour.ufo ufos/cities.ufo ufos/entities.ufo ufos/tips.ufo ufos/version.ufo ufos/msgcategories.ufo ufos/weapons_human.ufo ufos/aircraftmanagement.ufo ufos/weapons_multiplayer.ufo ufos/weapons_laser.ufo ufos/ptl_weather.ufo ufos/research.ufo ufos/research_logic.ufo ufos/alientype_missions.ufo ufos/equipment.ufo ufos/researched_list.ufo ufos/installation.ufo ufos/nations.ufo ufos/ui/modeltest.ufo ufos/ui/production.ufo ufos/ui/main.ufo ufos/ui/skirmish.ufo ufos/ui/aircraft.ufo ufos/ui/hospital.ufo ufos/ui/multiplayeringame.ufo ufos/ui/irc.ufo ufos/ui/material_editor.ufo ufos/ui/bases.ufo ufos/ui/aircraft_equip.ufo ufos/ui/market.ufo ufos/ui/sys_popup.ufo ufos/ui/singleplayer.ufo ufos/ui/messageoptions.ufo ufos/ui/transfer.ufo ufos/ui/research.ufo ufos/ui/multiplayer_team.ufo ufos/ui/hud.ufo ufos/ui/equipment.ufo ufos/ui/multiplayer.ufo ufos/ui/_hud.ufo ufos/ui/tutorials.ufo ufos/ui/aliencont.ufo ufos/ui/options.ufo ufos/ui/geoscape.ufo ufos/ui/aircraft_soldiers.ufo ufos/ui/aircraft_info.ufo ufos/ui/aircraft_pilots.ufo ufos/ui/physdat.ufo ufos/ui/hire.ufo ufos/ui/ufopedia.ufo ufos/ui/_menu.ufo ufos/ui/inventory.ufo ufos/ui/nohud.ufo ufos/ui/lostwon.ufo ufos/ui/basesummary.ufo ufos/ui/sys_editor.ufo ufos/ui/basedefence.ufo ufos/ui/_objectinfo.ufo ufos/ui/campaign.ufo ufos/ui/stats.ufo ufos/ui/genradarhud.ufo ufos/ui/sequence.ufo ufos/ui/mailclient.ufo ufos/ui/althud.ufo ufos/ui/buildings.ufo ufos/seq_tutorials.ufo ufos/weapons.ufo ufos/team_civilians.ufo ufos/team_aliens.ufo ufos/language.ufo ufos/seq_modelview.ufo ufos/medals.ufo ufos/maps.ufo ufos/weapons_ugv.ufo ufos/models.ufo ufos/weapons_aliens.ufo ufos/equipment_missions.ufo ufos/inventory.ufo ufos/fonts.ufo ufos/ptl_misc.ufo ufos/events.ufo ufos/icons.ufo ufos/seq_intro.ufo ufos/gametypes.ufo ufos/basemanagement.ufo ufos/campaign.ufo ufos/weapons_melee.ufo ufos/msgoptions.ufo ufos/terrain.ufo ufos/weapons_particle.ufo ufos/ptl_weaponsfx.ufo ufos/otheritems.ufo ufos/music.ufo ufos/components.ufo ufos/seq_credits.ufo ufos/weapons_plasma.ufo
   zip warning: 0ufos.pk3 not found or empty
  adding: ufos/team_humans.ufo (deflated 84%)
  adding: lot of files....
  adding: ufos/seq_credits.ufo (deflated 83%)
  adding: ufos/weapons_plasma.ufo (deflated 83%)
zip -d base/0ufos.pk3

zip error: Nothing to do! (base/0ufos.pk3)
make[1]: [base/0ufos.pk3] Erreur 12 (ignorée)
make[1]: quittant le répertoire « /home/jerikojerk/projets/ufoai/trunk »

---
Please notice: makefile's target "pk3" could be build when invoking  "make" instead of "make install". make is run with user privileges and make install with root privileges, so if you don't run make pk3 before installing you get files owned by root in your home directory and  it's a real pained to get rid of them. it's linux specific, i know...

[Mattn]

feel free to submit patches that will fix these problems - btw. there is no need to run make pk3 - or make install. just type make and ./ufo from trunk/

[jerikojerk]

ok i will do, but it's a very long time i wrote a simplier make... (if it were simple for me, i would already have provided a diff ). 
i use gnu make 3.81, does this happens on other version/platerform?