Issues with build 24055 (Muton Diff patch)

[vedrit]

I downloaded and installed Mutons patch, and started to play. In mission, I noticed that there were several issues.
The first, regard the attached screen shot. I told a soldier to move to a group on the other side of the drop ship, and she started walking on top of the ship.

The second, was that, after I got her down, she was stuck. Full TU, but couldnt go anywhere

Third, there are whole sections of the map that are unavailable for movement.

Fourth, there were a few times when the soldier would move to strange places to go to the clicked location

And, fifth, the medic wouldnt heal a second time. It consumed TU, but the health never went above 50, and the medic would be stuck in the animation until given another command (move, shoot, etc)

[attachment deleted by admin]

[geever]

The "walk on dropship" issue should be fixed already i guess this diff-update missed some change (map recompilation maybe).

The inaccessible areas are known problem. I hope wilminator and duke can fix it soon.

-geever

[odie]

The "walk on dropship" issue should be fixed already i guess this diff-update missed some change (map recompilation maybe).

The inaccessible areas are known problem. I hope wilminator and duke can fix it soon.

-geever

Oh, geever,

u mentioned map recompilation?
I tot that the map recompilation (/contrib/scripts/compile_maps.bat) should be automatically updating maps??

[Muton]

recompile the maps won't fix that
ufo2map has not changed (I will recompile the whole thing to be shure that the diff pack is ok or not)

The problem here is not the old bug
If you move into the dropship you move on top of it

The problem is
If you set the groundlevel 2 and klick on a roof
you'll got a blue cuboid (not moveable) *edit coul'd be green too
but the soldier moves an that roof anyway.
So you'r able to "climb"
but you shouldn't.

[geever]

I tot that the map recompilation (/contrib/scripts/compile_maps.bat) should be automatically updating maps??

I think I explained it many times already. Scripts detect map changes but not map compiler changes. After the "soldier goes up on dropship" issue there was a map compiler change that effected maps. There was no BPSVERSION change (so the maps could be loaded) but recompilation of all maps were needed to fix the issues.

-geever

[Mattn]

....and there will be more of those sneaking fixes until the pathfinding patch is finished - we can't increase the bsp version with every commit.

[Muton]

As expected
after uninstall the game (complete remove)
and complete recompile of the game including all maps
i can still climb the dropship or roofs

So the diff patch is ok!

> After the "soldier goes up on dropship" issue there was a map compiler change

I hope you reflect changes on ufo2map in variable VERSION

Code: [Select]

for /f "tokens=3" %%a in ('type %~dps0src\tools\ufo2map\ufo2map.c ^| find /I "define" ^| find /I "VERSION"') do (
if NOT "%%~a" == "1.2.4" (
@echo ufo2map changed
pause
)
)


[odie]

I think I explained it many times already. Scripts detect map changes but not map compiler changes. After the "soldier goes up on dropship" issue there was a map compiler change that effected maps. There was no BPSVERSION change (so the maps could be loaded) but recompilation of all maps were needed to fix the issues.

-geever

*enlightened*

Ooooo. If that is the case, could you point me to the page where it details the map recompilation procedures pls?

In short, does it meant that not only do i have to rebuild the workspace each time, i need to del the bsp files before i do the archives.bat and the compile_maps.bat scripts before NSIS-scripting into an installer?

What is the missing step in b/w the procedures??

Thanks geever!

[Mattn]

Code: [Select]

for /f "tokens=3" %%a in ('type %~dps0src\tools\ufo2map\ufo2map.c ^| find /I "define" ^| find /I "VERSION"') do (
if NOT "%%~a" == "1.2.4" (
@echo ufo2map changed
pause
)
)


holy shit muton, what are you? one of the aliens? how the heck could one understand such a syntax? but a nice example anyway - i've searched for something lke that for a task at work.

I hope you reflect changes on ufo2map in variable VERSION

No, not every change would increase the ufo2map version. there are many changes on just one day, we can't increase the version number for every one of them.

[geever]

What is the missing step in b/w the procedures??

Run compile_maps.bat with /clean parameter so it will recompile all.

Full map recompilation isn't needed on every ufo2map change it can be minor but nowdays the pathfinding is changin' which does need it.

Note that there was a pathfinding commit today again so happy recompiling!

-geever

[Muton]

>No, not every change would increase the ufo2map version

Than i make a proposal
please add a comment in ufo2map.c

Code: [Select]

// RecompileALLmaps 0     this is for binarymakers. Increase the number by 1 if a complete recompilation of maps is necessary


[odie]

Run compile_maps.bat with /clean parameter so it will recompile all.

Full map recompilation isn't needed on every ufo2map change it can be minor but nowdays the pathfinding is changin' which does need it.

Note that there was a pathfinding commit today again so happy recompiling!

-geever

Ah, thanks geever!

I used to do that, but at one point, i thnk the /clean para was broken, so i tot it did not work animore.

Tried it just and its in the midst of recompilation.

So, ya, back to compilation indeed, and very happy to do it. lol

[Muton]

I've found a way to determine
if its necessary to recompile all maps or not.

The logic behind
Take one map and build it always with option "-t 1"
hash this one map before and after the sourceupdate (and maprecompiling)
if the summ is different you need to recompile all maps

To do this you'll need fsum!

Code: [Select]

:: here we hash one of the biggest maps
:: recompile it using only one core (very important)
:: and check if both hashsumms are identical
:: if not all maps need to be recompiled
:: %~dps0 == ufoai root (install-sh, Makefile.in, ...)
for /f "skip=4" %%a in (fsum -d"%~dps0base\maps" bunker.bsp') do (
del /F /Q "%~dps0base\maps\bunker.bsp"
ufo2map.exe -v 4 -extra -t 1 maps/bunker || (
@echo I was unable to compile bunker.map
call :error
)

for /f "skip=4" %%b in (fsum -d"%~dps0base\maps" bunker.bsp') do (
if NOT "%%a"=="%%b" (
move "%~dps0base\maps\bunker.bsp" "%~dps0\bunker.bsp"
del /Q /F /S "%~dps0base\maps\*.bsp"
move "%~dps0\bunker.bsp" "%~dps0base\maps\bunker.bsp"
)
)
)


[odie]

I've found a way to determine
if its necessary to recompile all maps or not.

The logic behind
Take one map and build it always with option "-t 1"
hash this one map before and after the sourceupdate (and maprecompiling)
if the summ is different you need to recompile all maps

To do this you'll need fsum!

Code: [Select]

:: here we hash one of the biggest maps
:: recompile it using only one core (very important)
:: and check if both hashsumms are identical
:: if not all maps need to be recompiled
:: %~dps0 == ufoai root (install-sh, Makefile.in, ...)
for /f "skip=4" %%a in (fsum -d"%~dps0base\maps" bunker.bsp') do (
del /F /Q "%~dps0base\maps\bunker.bsp"
ufo2map.exe -v 4 -extra -t 1 maps/bunker || (
@echo I was unable to compile bunker.map
call :error
)

for /f "skip=4" %%b in (fsum -d"%~dps0base\maps" bunker.bsp') do (
if NOT "%%a"=="%%b" (
move "%~dps0base\maps\bunker.bsp" "%~dps0\bunker.bsp"
del /Q /F /S "%~dps0base\maps\*.bsp"
move "%~dps0\bunker.bsp" "%~dps0base\maps\bunker.bsp"
)
)
)


Ooooo, interesting.
I saw one of the mods sent this link in a diff thread:
UFOAI revision logs

I think, developers might be able to help us further by:
1) Whenever all maps requires recompilations, to indicate in log - though this might get cluttered.
2) Post a sticky note! Lol.