Mapeditor Improvement: Clipper tool

[RudolfoWood]

There is a bug/feature request regarding the clipper tool. Actually on cutting brushes results look different from expected. Level/content flags are not applied to new faces, shader is set to default (nodraw).

There are different ways how this could be improved:
level/contentflags
1) apply diff of content/surfaceflags of all brush faces to new one (e.g. all have levelflags set -> apply those)
2) apply some voting diff (e.g. most of the faces have one flag set -> apply those flags that have some majority)

texture
actually it seems that texture is set to nodraw. Here we also could set
a) diff texture (if all have the same, set it to new, otherwise nodraw)
b) voting diff: apply the texture that is used by most of the faces

I did not look into the code, but this could probably also be applied to subtract and other face-generating tools.
Any suggestions?

[BTAxis]

I'm not fond of the voting idea. It behaves unpredictably, and that's not good in an editor.

[Mattn]

shader is set to default (nodraw).

This is an option you can set in the editor settings

[RudolfoWood]

I saw that nodraw after my post, I'll have to check how it influences the system...

I got an idea of a third option:
3) try diff, if inconsistent texture is used, pop up an texture selection dialog for new face

[RudolfoWood]

I tested the clipper setting, it does not seem to work for me - results in nodraw texture both enabled or disabled (on a structure that has all sides same texture)
edit: I found by looking into the code that it uses current selection from texture browser as a new texture. This was not known to me and feels somehow not intuitive.

Best solution in my opinion would be something like I stated with 3) which should have been a c) , try to diff from current selection, if not all same pop up a selection dialog with combo : selection from texture browser / nodraw (if checked), textures in current selection and additional button to choose texture (from texture browser).
Opinions?

[richlv]

contentfalgs are supposed to be the same for all faces, so that's easy - just set the same as the other faces have.

surfaceflags and texture are a bit harder. voting of the remaining faces sounds usable.

popup might be problematic when you keep both sides after clipping - you'd get two popups and maybe you intended to remove on of the sides anyway, so i'd vote against popup.