General > Discussion

Fix for bug #1890695 -- what should be the desired behaviour

(1/3) > >>

nemchenk:
I'm looking at fixing bug #1890695, where craftitems mounted on an aircraft that is sold disappear from the player's inventory.

The bug poster wants these items to be added to the base Stores, but it occurs to me that this would make for an exploit! Normally, it takes several hours to remove items from an aircraft. This would allow the player to do it instantly! Say I decide I can't wait 24 hours to take the armour off my Firebird and put it on my Stiletto -- I sell the Stiletto, then buy it back. Hey presto, I have armour ready to install, instantly.

Do we care? Should I submit a patch that pops up a "You cannot sell this aircraft as it has equipment installed. You must remove all equipment before sale."? This solution is simpler to code :P and has the merits of using existing "game rules" instead of introducing new ones. However, it means more micro-management for the player :(

Or shall we just let this slight workaround exist, given that stuff sells for 90% of its value at the moment? This lets the player have what he wants, and NOW, but at the risk of creating a slight "bug" in the game.

Perhaps the third solution is best, but the most difficult? :D The aircraft is "queued" for decommissioning -- it is sold once all gear is removed from it. Is the craft available for use while gear is being stripped from it? Or does it disappear from the inventory straight away, and some hours later money and craft items appear?

Or even: do it XCOM3-style. Add the price of the items to the craft sale price?

What do you think?

kracken:

--- Quote from: nemchenk on February 19, 2008, 02:00:08 pm ---The bug poster wants these items to be added to the base Stores, but it occurs to me that this would make for an exploit! Normally, it takes several hours to remove items from an aircraft.

--- End quote ---
You're right, I didn't think about that when I commited this bug.

I think the best solution is to sell items at the same time than the aircraft. Anyway, we will probably need to add some delay in the futur when you buy items before being able to use them (at the moment, there's no point in transfering items. For example: if you sell an item in one base and buy it in another one, you will manage to perform an immediate transfer)

You can't sell items at 90% of their price because this is not what is done when you sell them directly. The "queue for decommissioning" seems difficult IMHO.

nemchenk:
Hi Kracken :)


--- Quote from: kracken on February 19, 2008, 02:10:35 pm ---You can't sell items at 90% of their price because this is not what is done when you sell them directly.
--- End quote ---
Beg your pardon, but it is: try buying something, then selling it immediately. You will loose 10% of its value :) I think it is undocumented, but it is happening.

kracken:

--- Quote from: nemchenk on February 19, 2008, 02:23:41 pm ---Hi Kracken :)
Beg your pardon, but it is: try buying something, then selling it immediately. You will loose 10% of its value :) I think it is undocumented, but it is happening.

--- End quote ---
Sorry, I can't try it at the moment, but I didn't know that :P
Anyway, you should sell it at the same amount than if you sell the item in the airequip menu.

nemchenk:
Ok, I see :)

Would anyone else care to comment, so we can build an idea of everyone's thoughts on the matter?

Navigation

[0] Message Index

[#] Next page