the patch is in svn now.
Cool! I'm honoured.
If there is no user/previous authors outrage I will try my hand with the other weapon script files...
there were some discussion about the skills moving to weapons and removed from ammo/shoottypes. i disagree with this idea because some weapons may fire high explosives (secondary) and normal bullets (primary)
You may be right, but I think you contradict yourself, or I misunderstood you. You said
this is just an error.
have a look at http://ufo.myexp.de/wiki/index.php/Equipment/Human_Weapons
there should be the skill classes.
And in the wiki the skill fields in weapon descriptions are void and the only indication of skill is the heading under which a weapon appears. Based on that I changed Rocket Launcher skill from "explosive" to "heavy". Isn't that the thing you refered to as "an error"? So I corrected the error, but then Rocket Launcher fires only explosive ammunition, despite having "heavy" skill.
Perhaps we could change "explosive" skill to "grenades" skill (this is how wiki calls it) and the problem of multiple skill weapons would be solved? After all there are no other skills based on damage type --- no "fire", "plasma", "tachyon" skill, etc. Perhaps also move Bolter Rifle to "precision" or "assault" skill, and/or move Grenade Launcher from "heavy" to "grenades" so that "heavy" is not overcrowded?
I do not insist, but multiple skills for one weapon result in considerable complication for the player. How to categorize documentation about weapons (and, currently, the wiki)? How to display the double weapon skills while buying, equiping soldiers, and even shooting (for double skill weapons this would be useful, for single skill weapons not so, because you know your soldier is equally good with both shooting modes)? Actually the optimization of equipment for soldiers based on two weapon skills, instead of one, could be really nice mini-game in itself, but this is already quite complex for the average Joe with both "accuracy" and the weapon skill influencing a weapon choice...
What do you think?