UFO:Alien Invasion

Technical support => Linux => Topic started by: apo on August 21, 2013, 01:22:11 pm

Title: Debian: feedback and tests welcome
Post by: apo on August 21, 2013, 01:22:11 pm
I have committed my latest work for UFO:AI here:

http://anonscm.debian.org/gitweb/?p=pkg-games/ufoai.git
http://anonscm.debian.org/gitweb/?p=pkg-games/ufoai-data.git
http://anonscm.debian.org/gitweb/?p=pkg-games/ufoai-music.git
http://anonscm.debian.org/gitweb/?p=pkg-games/ufoai-maps.git

I invite every Debian/Ubuntu/Mint gamer to test those packages by cloning the git repositories and building the game from source. I can also provide binaries in a later development stage of 2.5, when it is clear that a release is only a few weeks away.

Edit: 02/11/2013
Debian packages for amd64 and i386,  from 1st of November 2013.

Edit: 28.06.2014
I have removed the binary packages from the server since they are outdated. The next ones will hopefully be official. :)



I still need to write the copyright files for the -data, -music and -maps source packages. I think I'm already done with the main ufoai source package which contains all source code. Another important point is creating identical and compatible maps. See also this thread: http://ufoai.org/forum/index.php/topic,7853.0.html

Debian provides a tool called Lintian which is mainly for checking Debian packages for policy compliance. But it can also detect common spelling mistakes in source packages. I'm attaching a patch that fixes a bunch of them.

What is the reasoning for displaying: "Download this game for free" at the intro screen? From the point of view of a Linux distribution this message shouldn't be necessary because it is clear that all users download the game from official Debian and Ubuntu servers. There are also various pointers to http://ufoai.org within the packages, so that I think it makes sense to omit this string in /src/client/cl_screen.cpp. What do you think?


Title: Re: Debian: feedback and tests welcome
Post by: H-Hour on August 21, 2013, 02:25:50 pm
What is the reasoning for displaying: "Download this game for free" at the intro screen? From the point of view of a Linux distribution this message shouldn't be necessary because it is clear that all users download the game from official Debian and Ubuntu servers. There are also various pointers to http://ufoai.org within the packages, so that I think it makes sense to omit this string in /src/client/cl_screen.cpp. What do you think?

We can't adjust the UI for each platform, and most of our users will have downloaded and installed the game from a distributed package that isn't necessarily connected to Debian/Ubuntu servers. For instance, some people even end up buying the game (http://www.bidorbuy.co.za/item/110339591/UFO_Alien_Invasion_UFO_AI_Defense_X_COM_Type_Strategy_Classic_PC_Game.html).

Would it help if we posted your repo on our news/twitter/facebook pages, to try and get more testers?
Title: Re: Debian: feedback and tests welcome
Post by: apo on August 21, 2013, 03:26:24 pm
We can't adjust the UI for each platform, and most of our users will have downloaded and installed the game from a distributed package that isn't necessarily connected to Debian/Ubuntu servers. For instance, some people even end up buying the game (http://www.bidorbuy.co.za/item/110339591/UFO_Alien_Invasion_UFO_AI_Defense_X_COM_Type_Strategy_Classic_PC_Game.html).

There is nothing particularly wrong with selling UFO:AI because it is licensed almost exclusively under the GPL. However if the vendor's product isn't accompanied by the source code or proper credits, you can and should enforce your rights. https://www.gnu.org/licenses/gpl-violation.html

If your game is truely free software this message seems to be redundant and I don't believe it will prevent those people from buying the game.

Would it help if we posted your repo on our news/twitter/facebook pages, to try and get more testers?

Sure. That would be great. The more feedback, the better.
Title: Re: Debian: feedback and tests welcome
Post by: H-Hour on August 21, 2013, 05:41:15 pm
OK, posted on Twitter and our Desura page. Mattn just made another news post today on our site, so I'll wait a day or two before posting on our front page. Remind me if I forget.
Title: Re: Debian: feedback and tests welcome
Post by: apo on August 24, 2013, 09:57:30 pm
*ping* front page post still welcome. My offer to provide binaries for testing at a later development stage still stands.
Title: Re: Debian: feedback and tests welcome
Post by: Mattn on August 25, 2013, 12:29:16 pm
front page post is there - thanks H-Hour.

offering binaries would be nice.

btw. i've seen your ufo wrappers support backtraces. if that is using the debian internal bug report stuff, you might want to disable the ufoai backtrace support:
see USE_SIGNALS in unix_shared.cpp (Sys_Signal)

use configure --disable-signals if you wanna disable that. but keep in mind, that we are not informed about the segfault then anymore.
Title: Re: Debian: feedback and tests welcome
Post by: Mattn on August 25, 2013, 12:34:52 pm
just thought about another thing. There are bashcompletion scripts for ufo2map and ufomodel. It would be cool if you could add them, too. They are located in contrib/scripts/bashcompletion
Title: Re: Debian: feedback and tests welcome
Post by: apo on August 25, 2013, 06:30:53 pm
front page post is there - thanks H-Hour.
Thanks!

offering binaries would be nice.
I'll upload all packages to my private VPS tomorrow and report back.

btw. i've seen your ufo wrappers support backtraces. if that is using the debian internal bug report stuff, you might want to disable the ufoai backtrace support:
see USE_SIGNALS in unix_shared.cpp (Sys_Signal)

use configure --disable-signals if you wanna disable that. but keep in mind, that we are not informed about the segfault then anymore.

Debian doesn't provide debugging symbols for all packages like Ubuntu does (apport) and those packages are only provided on a case by case basis. I think it makes sense to supply a -dbg package for ufo:ai and I have already created such a package. However I presume for a useful backtrace someone has to compile the binaries with no optimizations but I believe that the debug package will provide enough information, so that I or anyone else can reproduce the issue.

I will add --disable-signals to configure because I bet otherwise someone would file a bug report about privacy concerns.

just thought about another thing. There are bashcompletion scripts for ufo2map and ufomodel. It would be cool if you could add them, too. They are located in contrib/scripts/bashcompletion

Yes, they are already included. If you think something else from contrib might be useful, then now is the time. :)
Title: Re: Debian: feedback and tests welcome
Post by: Mattn on August 25, 2013, 08:05:41 pm
I will add --disable-signals to configure because I bet otherwise someone would file a bug report about privacy concerns.

use the cvar uploadcrashdump and set this to 0 if you want to disable the crashdump upload. the crashdump is then still created, but only kept locally.
Title: Re: Debian: feedback and tests welcome
Post by: apo on August 26, 2013, 05:19:11 pm
use the cvar uploadcrashdump and set this to 0 if you want to disable the crashdump upload. the crashdump is then still created, but only kept locally.

Actually I would like to keep your internal backtrace in case of segfaults but I would also like to disable uploadcrashdump by default. So just for clarification:  I have to set uploadcrashdump to 0 in my config.cfg manually? How can I make this behaviour the default for all users?

By the way I have uploaded the binaries to my VPS. As long as there are not hundreds of testers, the bandwith should be sufficient, otherwise it would be better to mirror the packages somewhere.
Title: Re: Debian: feedback and tests welcome
Post by: Mattn on August 26, 2013, 08:17:00 pm
you can add this via commandline

./ufo +set uploadcrashdump 0 (just add this to your wrapper)
Title: Re: Debian: feedback and tests welcome
Post by: apo on August 26, 2013, 10:39:23 pm
Alright, thanks.

As a side note: I can't no longer reproduce the crash when clicking on exit or when I disable the sound in-game. I presume this has been fixed by one of the last commits or by a Debian package upgrade.
Title: Re: Debian: feedback and tests welcome
Post by: Mattn on August 26, 2013, 10:51:59 pm
that's good news.
Title: Re: Debian: feedback and tests welcome
Post by: Popi on August 27, 2013, 08:50:34 pm
Hi there,

Downloaded and installed all but the music package.

Debian Jessie (3.10-2-amd64)

Radiant package required me to add the following packages:
  libgtksourceview2.0-0
  libgtkglext1


Everything installed like a breeze and game runs "as well as the compiled version" (mouse fps drops under 0 when mouse moves while in mission, so i haven't tested much gameplay -sadly-).

I don't know if you need anything else to "test" about the packages.
Title: Re: Debian: feedback and tests welcome
Post by: apo on August 27, 2013, 10:04:12 pm
Hi Popi,

thanks for your feedback! I'm always looking for things which I haven't anticipated yet. So I'm interested in things like

- does the game work for you on your system
- what do you think about the ufoai-server package, does it suit your needs as a server admin?
- does the uforadiant package work, shall I suggest/recommend other packages which are useful for creating ufo:ai maps?

Well, in short everything might be useful, especially if it doesn't work for you (then I would like to know why? :) )

Regarding the ufoai-uforadiant package: I also discovered that the package could avoid useless dependencies. It seems that the radiant binary is linked against libraries that are not strictly needed because the map editor uses non of the library's symbols. I need to experiment with build/modules/uforadiant.mk a little to avoid the unnecessary linking. I get this message in my build log:

dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai/usr/lib/ufoai/ufo was not linked against libdl.so.2 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-server/usr/lib/ufoai-server/ufoded was not linked against libdl.so.2 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libXt.so.6 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libfontconfig.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libatk-1.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libpangocairo-1.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libogg.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libfreetype.so.6 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libICE.so.6 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libvorbis.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libpangox-1.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libGLU.so.1 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libXmu.so.6 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libgio-2.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libcairo.so.2 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libgmodule-2.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libSM.so.6 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libgthread-2.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-uforadiant/usr/lib/uforadiant/uforadiant was not linked against libpangoft2-1.0.so.0 (it uses none of the library's symbols)
dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/ufoai-tools/usr/bin/ufo2map debian/ufoai-tools/usr/bin/ufoslicer debian/ufoai-tools/usr/bin/ufomodel were not linked against libgcc_s.so.1 (they use none of the library's symbols)


Title: Re: Debian: feedback and tests welcome
Post by: Mattn on August 28, 2013, 08:21:04 pm
that might be a little bit hard to do. because we are using pkg-config's pc files, and there almost everything gtk related is included.
Title: Re: Debian: feedback and tests welcome
Post by: apo on September 05, 2013, 05:59:34 pm
that might be a little bit hard to do. because we are using pkg-config's pc files, and there almost everything gtk related is included.

Unfortunately I haven't identified the root cause of this issue yet. Normally this could be avoided by excluding the unneeded gtk libraries in the final linker stage and I usually add "Wl,--as-needed to LDFLAGS to compensate for that. In this case it doesn't work.

Besides: I've built the game with SDL2 for the first time and it works flawlessy so far. 
Title: Re: Debian: feedback and tests welcome
Post by: wolfer on October 01, 2013, 07:42:07 pm
Hi all,

Registered to give some info on my run with these packages.

Before going into details I'm on amd64 / SID.

So,
Install goes as expected I had most prerequisites, the ones which I did not were libxml1 (for ufoai-uforadiant-data) and  libgtkglext1 (for ufoai-uforadiant). Sadly there is no package named libxml1 in the official debian repo, thus I wasn't able to get the mapeditor working.
Also after installing the game server component starts up, and listens on 0.0.0.0:27910 TCP, which is in my opinion rather unwanted. As such I think it would make a lot more sense to either start the server on a need to basis or have it only listen on localhost.

Also when trying to start the game it dies with the following error:
/usr/lib/ufoai/ufo: error while loading shared libraries: libmxml.so.1: cannot open shared object file: No such file or directory
Title: Re: Debian: feedback and tests welcome
Post by: apo on October 02, 2013, 12:02:35 am
Hi!

Thanks for your feedback.

Quote
So,
Install goes as expected I had most prerequisites, the ones which I did not were libxml1 (for ufoai-uforadiant-data) and  libgtkglext1 (for ufoai-uforadiant). Sadly there is no package named libxml1 in the official debian repo, thus I wasn't able to get the mapeditor working.

I believe you are looking for libmxml1
http://packages.debian.org/sid/libmxml1

Quote
Also after installing the game server component starts up, and listens on 0.0.0.0:27910 TCP, which is in my opinion rather unwanted. As such I think it would make a lot more sense to either start the server on a need to basis or have it only listen on localhost.

The ufoai-server package contains the dedicated server. You don't need this package if you want to start a listen server, the ufoai package is then sufficient. The dedicated server is intended for server admins who want to setup a headless server with as little dependencies as possible. Normally you can set a cvar value for net_ip (at least for openarena) in your server.cfg and make the server listen only on one interface instead of all.

So in short: If you only want to play the game and host some games in your local network, the ufoai package and its dependencies is all that you need.

Title: Re: Debian: feedback and tests welcome
Post by: Mattn on October 02, 2013, 02:15:46 pm
the mapeditor needs libxml2
Title: Re: Debian: feedback and tests welcome
Post by: Grug on October 31, 2013, 06:56:50 pm
Firstly, great to see this finally becoming official in Debian. The more quality games we get in Debian the better!

So, here is my experience so far....
I'm running Debian Jessie with some Sid packages and using the binary debs from this thread. I also have 2.4 compiled from source in my home directory, but it shouldn't be interfering unless there is a big packaging issue.

Due to the change in the soldiers my 2.4 saved games weren't really playable so decided to start a new campaign. The first UFO arrived and I sent out my dropship but couldn't enter the battle scene. After trying a few times I checked the console and discovered this:
...
2013/10/31 21:54:52 ...subsystem 'triggerevents' - saved
2013/10/31 21:54:52 XML Written to buffer (120728 Bytes)
2013/10/31 21:54:52 Can't find maps/gasstation.ump
2013/10/31 21:55:00 Calling subsystems
2013/10/31 21:55:00 ...subsystem 'campaign' - saved
...
2013/10/31 21:55:00 ...subsystem 'triggerevents' - saved
2013/10/31 21:55:00 XML Written to buffer (120728 Bytes)
2013/10/31 21:55:00 Can't find maps/gasstation.ump
2013/10/31 21:55:02 Calling subsystems
2013/10/31 21:55:02 ...subsystem 'campaign' - saved
...
(etc)

After starting a new campaign I ended up 3 out of 5 maps (for a total of 4 from 6) failing to load.
The maps I got  in the new campaign were:
...
2013/10/31 23:25:34 checksum for the map 'subway': 2414773207
...
2013/11/01 02:50:25 Can't find maps/industrial.ump
...
2013/11/01 02:54:13 Can't find maps/scout_crash.ump
...
2013/11/01 03:09:24 checksum for the map 'harbour': 3665197658
...
2013/11/01 03:38:00 Can't find maps/city3.ump
...

I unzipped the /usr/share/games/ufoai/base/0maps.pk3 file and there are no .ump files, only .bsp files but the missing maps do match directories in the resulting maps folder. The maps that did work match .bsp files in the root of the /maps/ directory.
I haven't looked at the source code to try to find the issue yet as those times are local time (yes it is now 5:00am) but I'll have a poke around and see what I can come up if no-one knows the problem already.

I couldn't see anything drastic about maps in the forums and I asked on IRC and it was suggested my experience might be a packaging issue hence giving some feedback here.



This one probably isn't a packaging issue but a separate bug, but I also got this mess trying to load one map (I don't remember what the map was). It tried to load but crashed back to the Geoscope:
2013/11/01 03:01:10 XML Written to buffer (141063 Bytes)
2013/11/01 03:01:10 g_notu is a developer cvar.
2013/11/01 03:01:10 g_nospawn is a developer cvar.
2013/11/01 03:01:10 setting game random seed to 13655235
2013/11/01 03:01:10 ********************
2013/11/01 03:01:10 ERROR: CMod_LoadEntityString: closing brace without data for keyname worldspawn
2013/11/01 03:01:10 ********************
2013/11/01 03:01:10 failed to upload file 'crashdump.txt': Failed to open/read local data from file/application
2013/11/01 03:01:13 Shutdown server: Server crashed.
Title: Re: Debian: feedback and tests welcome
Post by: Grug on November 01, 2013, 04:07:35 pm
I unzipped the /usr/share/games/ufoai/base/0maps.pk3 file and there are no .ump files, only .bsp files but the missing maps do match directories in the resulting maps folder. The maps that did work match .bsp files in the root of the /maps/ directory.
I haven't looked at the source code to try to find the issue yet as those times are local time (yes it is now 5:00am) but I'll have a poke around and see what I can come up if no-one knows the problem already.
Having a quick look at git, I noticed there were .ump files in the /base/maps/ directory of the source. A git clone was taking too long (stupid net connection) so I just went back to playing, but when a map couldn't load, I grabbed the missing file from the git repo, created a new directory /usr/share/games/ufoai/base/maps/ and added the missing .ump file and low and behold*, it worked. I could now play the missing maps.

I'm surprised this worked because the only files in the new /base/maps/ dir is the missing .ump files, the other maps files are still being sourced from the .pk3 pack. I unzipped the maps pack file to a separate sub-dir on a drive with more space. :-P
Title: Re: Debian: feedback and tests welcome
Post by: apo on November 02, 2013, 11:57:17 am
Quote
Firstly, great to see this finally becoming official in Debian. The more quality games we get in Debian the better!

Absolutely. :)

Thank you very much for your bug report. I forgot to add an asterisk sign in a very important place, so that the *.ump files couldn't be copied to the right place. This should be fixed now. I will upload new packages with the latest git snapshot in the course of the day.
Title: Re: Debian: feedback and tests welcome
Post by: Grug on November 02, 2013, 12:07:51 pm
I forgot to add an asterisk sign in a very important place, so that the *.ump files couldn't be copied to the right place. This should be fixed now. I will upload new packages with the latest git snapshot in the course of the day.
Ahhh yes. Glad it was an easy fix. :-)
Title: Re: Debian: feedback and tests welcome
Post by: apo on November 02, 2013, 09:29:59 pm
I have uploaded the new deb packages.

ftp://46.182.19.209/ufoai/
Title: Re: Debian: feedback and tests welcome
Post by: erome5578 on February 25, 2014, 11:28:05 pm
Tech spt, When is Version 2.5 scheduled to be available?
Title: Re: Debian: feedback and tests welcome
Post by: Mattn on June 01, 2014, 06:25:49 pm
with june 1st we should be fully debian license compatible. i've just replaced the last sound files with gpled versions. now we can really start to release 2.5 and hopefully also get it officially into debian :)
Title: Re: Debian: feedback and tests welcome
Post by: apo on June 05, 2014, 10:29:00 pm
Hi folks, hi Mattn

sorry I was quite busy this week but I promise to update the packaging this weekend. I guess the only thing that's left is to release 2.5. I'll be back tomorrow with more information. Let's get this game into Debian.  :)
Title: Re: Debian: feedback and tests welcome
Post by: Mattn on June 05, 2014, 10:30:53 pm
yes - there is nothing more left than that

great to hear that.
Title: Re: Debian: feedback and tests welcome
Post by: apo on June 07, 2014, 12:17:04 am
Ok, I have built the latest stuff from the ufoai_2.5 branch and everything seems to work fine.

A few observations:

1. I would like to use a verbose build to detect possible issues as early as possible. Currently I see lines like that

Code: [Select]
===> CXX [uforadiant] src/tools/radiant/radiant/sound/SoundManagerModule.cpp
===> CXX [uforadiant] src/tools/radiant/radiant/sound/SoundPlayer.cpp
===> CXX [uforadiant] src/tools/radiant/radiant/script/ScriptLibrary.cpp
===> CXX [uforadiant] src/tools/radiant/radiant/script/ScriptLibraryModule.cpp
===> CXX [uforadiant] src/tools/radiant/radiant/script/ScriptTokeniser.cpp
===> CXX [uforadiant] src/tools/radiant/radiant/script/ScriptTokenWriter.cpp

How can I make the compiler commands and all flags visible?

2. I have mostly tested UFO:AI under GNOME 3. It takes some time until the games starts up which is absolutely fine. However during this process a pop-up window with a message is shown which asks me if I want to "kill the application" or if I want to wait until the task finishes. (Obviously the game triggers a timeout somewhere) Screenshot with the message in German: ftp://46.182.19.209/images/GNOME3_warning.png
It could be a GNOME 3 issue. It's slightly annoying, unfortunately I don't know how to fix it. Did anyone see a similar message sometime?

3. Fonts:

Here are two screenshots showing the in-game menu in English and German. I am old and my eyes are dim but I think the fonts are not really crisp. Is this normal?
ftp://46.182.19.209/images/ufoai_fonts_1.png
ftp://46.182.19.209/images/ufoai_fonts_2.png


Title: Re: Debian: feedback and tests welcome
Post by: Mattn on June 07, 2014, 12:23:44 pm
Ok, I have built the latest stuff from the ufoai_2.5 branch and everything seems to work fine.

A few observations:

1. I would like to use a verbose build to detect possible issues as early as possible. Currently I see lines like that


Code: [Select]
===> CXX [uforadiant] src/tools/radiant/radiant/sound/SoundManagerModule.cpp
===> CXX [uforadiant] src/tools/radiant/radiant/sound/SoundPlayer.cpp
===> CXX [uforadiant] src/tools/radiant/radiant/script/ScriptLibrary.cpp
===> CXX [uforadiant] src/tools/radiant/radiant/script/ScriptLibraryModule.cpp
===> CXX [uforadiant] src/tools/radiant/radiant/script/ScriptTokeniser.cpp
===> CXX [uforadiant] src/tools/radiant/radiant/script/ScriptTokenWriter.cpp

How can I make the compiler commands and all flags visible?


make Q=

2. I have mostly tested UFO:AI under GNOME 3. It takes some time until the games starts up which is absolutely fine. However during this process a pop-up window with a message is shown which asks me if I want to "kill the application" or if I want to wait until the task finishes. (Obviously the game triggers a timeout somewhere) Screenshot with the message in German: ftp://46.182.19.209/images/GNOME3_warning.png
It could be a GNOME 3 issue. It's slightly annoying, unfortunately I don't know how to fix it. Did anyone see a similar message sometime?

Hm. We don't pump the event queue on loading all data. I don't think this is something that could be changed for 2.5 - but the precaching could be disabled.

Cvar cl_precache should be set to 0 (it's the default - but maybe you changed that?)

3. Fonts:
Here are two screenshots showing the in-game menu in English and German. I am old and my eyes are dim but I think the fonts are not really crisp. Is this normal?
ftp://46.182.19.209/images/ufoai_fonts_1.png
ftp://46.182.19.209/images/ufoai_fonts_2.png

The problem here is, that we scale after we rendered to the bitmap texture - this is a known issue and will most likely get fixed in 2.6 - but no promises on that.
Title: Re: Debian: feedback and tests welcome
Post by: apo on June 07, 2014, 12:48:32 pm
Quote
make Q=

Excellent. Thanks!

Quote
Hm. We don't pump the event queue on loading all data. I don't think this is something that could be changed for 2.5 - but the precaching could be disabled.

Cvar cl_precache should be set to 0 (it's the default - but maybe you changed that?)

I haven't touched cl_precache and it is still set to 0. I'm quite sure that I didn't see this issue when I tested the game for the first time back in August 2013. I think we have to monitor this issue for a while.

Quote
The problem here is, that we scale after we rendered to the bitmap texture - this is a known issue and will most likely get fixed in 2.6 - but no promises on that.

Ok, no problem. It's good to know it is not related to the packaging.

I currently don't see any other obstacles. As soon as you release 2.5, I will finish the last bits, test everything again and then I'm going to find a Debian developer who can upload the game. Since it is a new package, it has to go to the so-called "NEW queue". I keep you informed about this procedure and the next steps.
Title: Re: Debian: feedback and tests welcome
Post by: Mattn on June 07, 2014, 01:11:05 pm
awesome - thanks a lot
Title: Re: Debian: feedback and tests welcome
Post by: apo on June 28, 2014, 06:42:43 pm
Congratulations for your latest release. Back to Work now... :)
Title: Re: Debian: feedback and tests welcome
Post by: solbu on July 01, 2014, 04:41:27 pm
What is the reasoning for displaying: "Download this game for free" at the intro screen?
Personally I would like that the text was changed to something like "Download this free game", since that is more correct for a Free software project such as this. It implies that it is both "for free" and "free software", whereas the current text only suggest that is is for free and not necessarily free software.
Title: Re: Debian: feedback and tests welcome
Post by: apo on August 26, 2014, 01:41:07 pm
Bad news first:

It will take more time than anticipated to get UFO:AI officially into Debian because I can't find someone who wants to do a peer-review of the game. The game also has to be approved by Debian's "ftp masters" and their queue with new packages is stuck with hundreds of packages at the moment. There is also another random problem when it comes to compiling the maps. Sometimes the compilation terminates with a segmentation fault at different compilation steps. Happens on 64bit and 32bit systems.

Good news:

To shorten the time a little I have created two Ubuntu PPA's for Ubuntu 14.04 aka Trusty and the upcoming 14.10 aka Utopic.

https://launchpad.net/~apoleon/+archive/ubuntu/ufoai-ppa

https://launchpad.net/~apoleon/+archive/ubuntu/ufoai-ppa-trusty

Just follow the install instructions on those pages. The packages are based on the official Debian packaging. They were simply recompiled.
Title: Re: Debian: feedback and tests welcome
Post by: apo on September 21, 2014, 07:18:08 pm
Hi folks,

We have found the following possible mistakes in UFO:AI's LICENSES file and it would be really great if you could take a look at it. The first bulk of files seems like a pattern to me. The sources were obtained from commons.wikimedia.org. The website always states that those files are either licensed under the GFDL or CC-BY-SA-3.0. LICENSES mentions they are all GPL-2+. What is correct?

base/textures/tex_buildings/carpet001.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Antique_tabriz_carpet_413021.jpg
base/textures/tex_buildings/carpet007.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Ziegler_wiki_01.jpg
base/textures/tex_buildings/carpet013.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Gendje-rug.jpg
base/textures/tex_buildings/carpet015.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:44199reg.jpg
base/texturs/tex_buildings/carpet017.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Antique_kerman_persian.jpg
base/textures/tex_buildings/carpet019.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Antique_Serapi_carpet_26854.jpg
base/textures/tex_buildings/carpet022.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Nain_rug.jpg
base/textures/tex_buildings/carpet024.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:42556-Antique-Persian-Tabriz-Carpets-hires.jpg
base/textures/tex_buildings/carpet026.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Antique_rug_42432.jpg
base/textures/tex_buildings/carpet027.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Swatches_of_carpet_1.jpg
base/textures/tex_buildings/carpet028.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Swatches_of_carpet_1.jpg
base/textures/tex_buildings/carpet029.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Swatches_of_carpet_1.jpg
base/textures/tex_buildings/carpet030.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Swatches_of_carpet_1.jpg
base/textures/tex_buildings/carpet031.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Swatches_of_carpet_1.jpg
base/textures/tex_pics/art_africa005.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Zulu_Krieger.jpg
base/textures/tex_buildings/floor010.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Altmannshofen_St_Vitus_Boden_Chor.jpg
base/textures/tex_pics/art_africa009.png | GNU General Public License 2.0 or later | MCR | http://commons.wikimedia.org/wiki/File:Masaidance.jpg

Those files are either licensed under GPL-3 or CC-BY-SA-3.0 according to the referenced source links.

base/textures/tex_buildings/wall007.png | GNU General Public License 2.0 or later | Sindwiller | http://opengameart.org/content/muddy-concrete-wall-01
base/textures/tex_buildings/wall007_2.png | GNU General Public License 2.0 or later | Sindwiller | http://opengameart.org/content/muddy-concrete-wall-02

This one is a possible copyright violation and the picture was deleted.

base/textures/tex_buildings/carpet016.png | Public Domain | MCR | http://commons.wikimedia.org/wiki/File:Amritsar_rug.jpg

Comments are much appreciated.
Title: Re: Debian: feedback and tests welcome
Post by: DarkRain on September 23, 2014, 04:54:46 am
Hi,

My thoughts:

Seems like we'll have to remove base/textures/tex_buildings/carpet016.png, this texture is used in the following maps:
Code: [Select]
base/maps/oriental/or_house_e.map
base/maps/italy/it_main.map (x5)
base/maps/africa/af_craft_crash_fighter.map (x5)
base/maps/africa/af_house4a.map (x5)
base/maps/africa/af_house4.map (x5)
If mappers could replace these with some other texture ASAP it would be great

In the of the images by Sindwiller, it seem to me like a case of copypaste editing gone wrong, but Mattn should be able to clarify things here (see commit 1f7a9bf5)

In the case of the textures by MCR (sourced form Commons) it seems we have an infringement of the license, which I want to think was unintentional, MCR has left the project but maybe we could contact him about this, if that fails, I think (but I'm not a lawyer) that we can invoke clause 7a of the CC-BY-SA (CC-BY in one case!) license
Title: Re: Debian: feedback and tests welcome
Post by: apo on September 23, 2014, 08:50:52 pm
Seems like we'll have to remove base/textures/tex_buildings/carpet016.png, this texture is used in the following maps:

Hi DarkRain,

thanks for your reply. Then I will wait until you have found a replacement for carpet016.png and then use this one instead. Since the other images are all under a free license, I don't see any problems if you switch from GPL-2+ to CC-BY-SA-3.0 and note that in LICENSES. Clause 7a might be helpful but of course, if MCR agreed to a license change, that would be even better.
Title: Re: Debian: feedback and tests welcome
Post by: apo on September 28, 2014, 02:35:00 pm
Hi,

I have converted the LICENSES file into a machine-readable copyright file that is used across the Debian distribution. One of its benefits is that you can easily spot missing copyright information. The following files are not accounted for in LICENSES hence I assume they are covered by your general GPL-2+ license. If this is not true, please let me know. You can find the "ufoai_copyright.py" script that I used to convert the LICENSES file here:

http://anonscm.debian.org/cgit/pkg-games/ufoai.git


Missing copyright information:

base/materials/africa.mat
base/materials/alienbase.mat
base/materials/baseattack.mat
base/materials/beach.mat
base/materials/bridge.mat
base/materials/bunker.mat
base/materials/city2.mat
base/materials/city3.mat
base/materials/city_industry.mat
base/materials/city_train.mat
base/materials/construction.mat
base/materials/corrupter_crash.mat
base/materials/country.mat
base/materials/desert.mat
base/materials/druglord.mat
base/materials/eaglenest.mat
base/materials/england.mat
base/materials/estate.mat
base/materials/excavation.mat
base/materials/farm.mat
base/materials/ferry.mat
base/materials/forest.mat
base/materials/frozen.mat
base/materials/gasstation.mat
base/materials/gate.mat
base/materials/harbor.mat
base/materials/hills.mat
base/materials/industrial.mat
base/materials/italy.mat
base/materials/japan.mat
base/materials/mansion.mat
base/materials/military_convoy.mat
base/materials/mine.mat
base/materials/neighbourhood.mat
base/materials/office.mat
base/materials/oriental.mat
base/materials/oriental_mosque.mat
base/materials/pipes_const.mat
base/materials/resort.mat
base/materials/rivertown.mat
base/materials/scout_crash.mat
base/materials/small_street.mat
base/materials/solarplant.mat
base/materials/spedition.mat
base/materials/tower.mat
base/materials/transport.mat
base/materials/tropic.mat
base/materials/ufocrash.mat
base/materials/urban.mat
base/materials/village.mat
base/materials/village2.mat
base/materials/wilderness.mat
base/models/animals/crocodile/croc.anm
base/models/civilians/male/soldier01.anm
base/models/objects/cameras/camera1.anm
base/models/objects/vegi/palm_a/palm1.anm
base/pics/icons/delete.png
base/pics/icons/delete_hovered.png
base/pics/implants/implant_amphetamine.png
base/pics/implants/implant_muscular.png
base/pics/maps/shots/beach.jpg
base/shaders/cook-torrance_fs.glsl
base/shaders/lerp_vs.glsl
base/shaders/simple_glow_fs.glsl
base/shaders/simple_glow_vs.glsl


base/maps/africa/af_house4a.map
base/maps/africa/af_house6.map
base/maps/africa/af_house6a.map
base/maps/africa/af_house6b.map
base/maps/alienb/ab_antimatter.map
base/maps/alienb/ab_entrance.map
base/maps/alienb/ab_hall_4way1.map
base/maps/alienb/ab_hall_cne1.map
base/maps/alienb/ab_hall_cnw1.map
base/maps/alienb/ab_hall_cse1.map
base/maps/alienb/ab_hall_csw1.map
base/maps/alienb/ab_hall_h1.map
base/maps/alienb/ab_hall_tbtm1.map
base/maps/alienb/ab_hall_ttop1.map
base/maps/alienb/ab_hall_v1.map
base/maps/alienb/ab_hall_v2.map
base/maps/alienb/ab_hangar.map
base/maps/alienb/ab_hub.map
base/maps/alienb/ab_lab.map
base/maps/alienb/ab_powercore.map
base/maps/alienb/ab_storage_v.map
base/maps/alienb/ab_ventl.map
base/maps/alienb/ab_ventr.map
base/maps/alienb/ab_wormhole.map
base/maps/alienbase.ump
base/maps/b/construction.map
base/maps/baseattack.ump
base/maps/bridge/br_craft_crash_scout.map
base/maps/compile.pl
base/maps/compile.py
base/maps/desert.ump
base/maps/farm2.ump
base/maps/farm2/f_craft_drop_firebird.map
base/maps/farm2/f_craft_drop_herakles.map
base/maps/farm2/f_craft_drop_raptor.map
base/maps/farm2/f_craft_ufo_fighter.map
base/maps/farm2/f_craft_ufo_scout.map
base/maps/forest/fr_f31.map
base/maps/forest/fr_f32.map
base/maps/forest/fr_f33.map
base/maps/forest/fr_f34.map
base/maps/forest/fr_f35.map
base/maps/forest/fr_f36.map
base/maps/forest/fr_f37.map
base/maps/forest/fr_f38.map
base/maps/forest/fr_f39.map
base/maps/forest/fr_f40.map
base/maps/forest/fr_f41.map
base/maps/forest/fr_f42.map
base/maps/forest/fr_f43.map
base/maps/forest/fr_f44.map
base/maps/forest/fr_f45.map
base/maps/forest/fr_f46.map
base/maps/forest/fr_f47.map
base/maps/forest/fr_f48.map
base/maps/forest/fr_f49.map
base/maps/forest/fr_f50.map
base/maps/forest/fr_f51.map
base/maps/forest/fr_f52.map
base/maps/forest/fr_f53.map
base/maps/forest/fr_f54.map
base/maps/forest/fr_h5.map
base/maps/forest/fr_h6.map
base/maps/forest/fr_h7.map
base/maps/gate.map
base/maps/hills.ump
base/maps/hills/craft_drop_herakles.map
base/maps/hills/craft_drop_raptor.map
base/maps/hills/craft_ufo_scout.map
base/maps/hills/filler_1s3_d.map
base/maps/hills/filler_1s4_d.map
base/maps/hills/filler_1s5.map
base/maps/hills/filler_1s6.map
base/maps/hills/house_15.map
base/maps/japan/ja_p_btl.map
base/maps/oriental/or_house_i.map
base/maps/oriental/or_house_k.map
base/maps/oriental/or_house_l.map
base/maps/oriental/or_house_m.map
base/maps/oriental/or_house_n.map
base/maps/oriental/or_minaret01.map
base/maps/oriental/or_minaret02.map
base/maps/oriental/or_minaret03.map
base/maps/oriental/or_minaret04.map
base/maps/oriental/or_shed_b.map
base/maps/oriental/or_shed_c.map
base/maps/oriental/or_stand_c.map
base/maps/oriental/or_stand_d.map
base/maps/oriental/or_stand_e.map
base/maps/oriental_mosque.ump
base/maps/oriental_mosque/om_craft_drop_firebird.map
base/maps/oriental_mosque/om_craft_drop_herakles.map
base/maps/oriental_mosque/om_craft_drop_raptor.map
base/maps/rescue.ump
base/maps/scout_crash.ump
base/maps/scout_crash/sc_craft_drop_firebird.map
base/maps/scout_crash/sc_craft_drop_herakles.map
base/maps/scout_crash/sc_craft_drop_raptor.map
base/maps/shared.ump
base/maps/small_house.map
base/maps/small_street.map
base/maps/tower.ump
base/maps/tower/t_craft_drop_herakles.map
base/maps/tower/t_craft_drop_raptor.map
base/maps/training_a.map
base/maps/training_b.map
base/maps/village2.ump
base/maps/village2/vil_b2x2_dentist01.map
base/maps/village2/vil_b2x2_diner01.map
base/maps/village2/vil_b2x2_house01.map
base/maps/village2/vil_b2x2_house02.map
base/maps/village2/vil_b2x2_house03.map
base/maps/village2/vil_b2x2_house05.map
base/maps/village2/vil_b2x2_house08.map
base/maps/village2/vil_b2x2_house09.map
base/maps/village2/vil_b2x4_house04.map
base/maps/village2/vil_b2x4_house06.map
base/maps/village2/vil_b2x4_house07.map
base/maps/village2/vil_b2x4_mart01.map
base/maps/village2/vil_b2x4_station01.map
base/maps/village2/vil_craft_drop_firebird.map
base/maps/village2/vil_craft_ufo_fighter.map
base/maps/village2/vil_craft_ufo_scout.map
base/maps/village2/vil_mp1.map
base/maps/village2/vil_mp2.map
base/maps/village2/vil_mp3.map
base/maps/village2/vil_p2x2_garden01.map
base/maps/village2/vil_p2x2_playground01.map
base/maps/village2/vil_p2x2_playground02.map
base/maps/village2/vil_p4x4_fountain01.map
base/maps/village2/vil_sc_ne01.map
base/maps/village2/vil_sc_nw01.map
base/maps/village2/vil_sc_sw01.map
base/maps/village2/vil_sh1x1_01.map
base/maps/village2/vil_sh_01.map
base/maps/village2/vil_sh_02.map
base/maps/village2/vil_sh_03.map
base/maps/village2/vil_st_east01.map
base/maps/village2/vil_st_north01.map
base/maps/village2/vil_st_north02.map
base/maps/village2/vil_st_south01.map
base/maps/village2/vil_st_west01.map
base/maps/village2/vil_sv1x1_01.map
base/maps/village2/vil_sv_01.map
base/maps/village2/vil_sv_02.map
base/maps/village2/vil_sv_03.map
base/maps/village2/vil_sv_04.map
base/maps/village2/vil_sx_01.map
base/textures/tex_buildings/concrete024.png
base/textures/tex_buildings/concrete024_nm.png
base/textures/tex_buildings/concrete_slabs01.png
base/textures/tex_buildings/concrete_slabs01_nm.png
base/textures/tex_buildings/concrete_slabs02.png
base/textures/tex_buildings/concrete_slabs02_nm.png
base/textures/tex_buildings/floor002.png
base/textures/tex_buildings/floor002_nm.png
base/textures/tex_buildings/floor011.png
base/textures/tex_buildings/floor022.png
base/textures/tex_buildings/floor022_nm.png
base/textures/tex_buildings/japwall003.png
base/textures/tex_buildings/japwall004.png
base/textures/tex_buildings/japwall005.png
base/textures/tex_buildings/japwall006.png
base/textures/tex_buildings/japwall007.png
base/textures/tex_buildings/wall019.png
base/textures/tex_buildings/wall_brick01.png
base/textures/tex_buildings/wall_brick01_nm.png
base/textures/tex_buildings/wall_brick01_sm.png
base/textures/tex_buildings/wall_se08.png
Title: Re: Debian: feedback and tests welcome
Post by: DarkRain on September 30, 2014, 11:57:56 pm
Hi,

I have converted the LICENSES file into a machine-readable copyright file that is used across the Debian distribution. One of its benefits is that you can easily spot missing copyright information. The following files are not accounted for in LICENSES hence I assume they are covered by your general GPL-2+ license. If this is not true, please let me know. You can find the "ufoai_copyright.py" script that I used to convert the LICENSES file here:

http://anonscm.debian.org/cgit/pkg-games/ufoai.git

<snip>

Your assumption is good, except in the case of all those base/textures/* files mentioned in your post, in fact each of those has its own entry in LICENSES, maybe there was an error during the conversion?
Title: Re: Debian: feedback and tests welcome
Post by: apo on October 04, 2014, 03:14:40 pm
I see the difference now:


Creative Commons Attribution-ShareAlike 3.0 Unported

Creative Commons Attribution-Share Alike 3.0

Seems I missed that ShareAlike is written in one word and the other time it's split into two words.
Title: Re: Debian: feedback and tests welcome
Post by: DarkRain on October 05, 2014, 10:15:19 pm
Ah, of course (and I should have looked at your script before) Mattn already unified the spelling in master*, of course, the 'MIT License' vs 'MIT/X11 license (GPL compatible)' issue remains

*commit: a01d047 (it goes cleanly into 2.5, if that will help)
Title: Re: Debian: feedback and tests welcome
Post by: apo on October 06, 2014, 07:14:24 pm
I fixed the "MIT License" vs "MIT/X11 license (GPL compatible)" in my script but the unified license names will surely be useful for the next release.
Title: Re: Debian: feedback and tests welcome
Post by: DarkRain on October 07, 2014, 07:20:53 pm
Ok, so MCR agreed to re-license his files (he mistook the GFDL for the GPL at the time) (see commits: master: 67f0620, 2.5: f2373b8)
I also corrected the licenses for Sindwiller's files, (unlike the previous ones those weren't changed so i just outright crrected the license) (master: cd5cb33, 2.5: 9061377)
ShipIt (http://ufoai.org/forum/index.php?action=profile;u=52880) replaced all instances of carpet016.png with carpet017.png in our maps and removed the offending file (master: 21ee171, 2.5:f516da3)

So, any other issues remaining?
Title: Re: Debian: feedback and tests welcome
Post by: apo on October 09, 2014, 09:17:58 pm
So, any other issues remaining?

Thanks. I'm currently not aware of other issues except the random segmentation fault when I compile the maps from scratch. Since I can't reproduce it I have a hard time with debugging the problem. Any idea what needs to be done to make the map compilation as verbose as possible? Perhaps this would provide the necessary hint in the future.
Title: Re: Debian: feedback and tests welcome
Post by: DarkRain on October 10, 2014, 12:33:23 am
You could try with:
Code: [Select]
make maps UFO2MAPFLAGS="-v 5 -quant 4 -soft"Maybe even try -v 6 (default flags are "-v 4 -nice 19 -quant 4 -soft")